All of lore.kernel.org
 help / color / mirror / Atom feed
* Should I choose SLOW_WORK?
@ 2009-04-05 23:09 Jeff Garzik
  2009-04-05 23:33 ` Jesper Juhl
  0 siblings, 1 reply; 2+ messages in thread
From: Jeff Garzik @ 2009-04-05 23:09 UTC (permalink / raw)
  To: David Howells; +Cc: LKML, linux-fsdevel

I am newly presented with


> Enable slow work thread pool (SLOW_WORK) [N/y/?] (NEW) ?
> 
> The slow work thread pool provides a number of dynamically allocated
> threads that can be used by the kernel to perform operations that
> take a relatively long time.
> 
> An example of this would be CacheFiles doing a path lookup followed
> by a series of mkdirs and a create call, all of which have to touch
> disk.


However, this does not tell me whether I need or want this.

And, why must the user make this choice at all?  Surely it can be 
auto-selected, if cachefs is enabled?  At a minimum, hide this under 
CONFIG_EMBEDDED or whatnot, so that most users don't see this choice, IMO.

	Jeff



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Should I choose SLOW_WORK?
  2009-04-05 23:09 Should I choose SLOW_WORK? Jeff Garzik
@ 2009-04-05 23:33 ` Jesper Juhl
  0 siblings, 0 replies; 2+ messages in thread
From: Jesper Juhl @ 2009-04-05 23:33 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: David Howells, LKML, linux-fsdevel

On Sun, 5 Apr 2009, Jeff Garzik wrote:

> I am newly presented with
> 
> 
> > Enable slow work thread pool (SLOW_WORK) [N/y/?] (NEW) ?
> > 
> > The slow work thread pool provides a number of dynamically allocated
> > threads that can be used by the kernel to perform operations that
> > take a relatively long time.
> > 
> > An example of this would be CacheFiles doing a path lookup followed
> > by a series of mkdirs and a create call, all of which have to touch
> > disk.
> 
> 
> However, this does not tell me whether I need or want this.
> 
> And, why must the user make this choice at all?  Surely it can be
> auto-selected, if cachefs is enabled?  At a minimum, hide this under
> CONFIG_EMBEDDED or whatnot, so that most users don't see this choice, IMO.
> 

I very much agree. I was confused by that option as well when I first saw 
it and the help text didn't really help much in determining if I wanted it 
or not.
If it's something that's generally useful, the kernel should just 
enable/use it. If other things depend on it they should auto-select it.


-- 
Jesper Juhl <jj@chaosbits.net>             http://www.chaosbits.net/
Plain text mails only, please      http://www.expita.com/nomime.html
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-04-05 23:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-05 23:09 Should I choose SLOW_WORK? Jeff Garzik
2009-04-05 23:33 ` Jesper Juhl

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.