All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [6989] Fix display breakage when resizing the screen (v2) (Avi Kivity)
Date: Mon, 06 Apr 2009 17:53:31 +0300	[thread overview]
Message-ID: <49DA176B.4090102@redhat.com> (raw)
In-Reply-To: <49DA14A5.4060301@redhat.com>

Avi Kivity wrote:
>> Secondly it doesn't follow the basic idea behind the DisplayState
>> surface: it is supposed to be a pixel surface provided by the vga
>> emulator to the frontends, cirrus shouldn't have to care what size it 
>> is.
>> In fact cirrus emulates bitblit operations on the emulated framebuffer,
>> not on the DisplayState surface; if it does so is a bug and should be 
>> fixed.
>>   
>
> This happens through cirrus_do_copy(), which implies that the display 
> surface is involved.  Is that wrong?

I think what you're saying is, we shouldn't call qemu_console_copy() in 
cirrus_do_copy() if vga is not displayed on the console?

(and conversely, if it is displayed, we shouldn't call 
cirrus_invalidate_region).

-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2009-04-06 14:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-05 18:41 [Qemu-devel] [6989] Fix display breakage when resizing the screen (v2) (Avi Kivity) Anthony Liguori
2009-04-06 14:21 ` Stefano Stabellini
2009-04-06 14:29   ` Anthony Liguori
2009-04-06 14:33     ` Stefano Stabellini
2009-04-06 14:44       ` Avi Kivity
2009-04-07  1:44         ` Ryan Harper
2009-04-07  9:28           ` Avi Kivity
2009-04-07  9:32             ` Stefano Stabellini
2009-04-06 14:41   ` Avi Kivity
2009-04-06 14:53     ` Avi Kivity [this message]
2009-04-06 17:35       ` Stefano Stabellini
2009-04-06 17:46         ` Avi Kivity
2009-04-06 18:01           ` Stefano Stabellini
2009-04-06 18:32             ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49DA176B.4090102@redhat.com \
    --to=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.