Re: [Qemu-devel] [6989] Fix display breakage when resizing the screen (v2) (Avi Kivity)

[Stefano Stabellini <stefano.stabellini@eu.citrix.com>]

Avi Kivity wrote:

> I found the real cause - vga_screen_dump() left values for the current 
> display resolution in s->last_width and s->last_height.  This caused the 
> next vga_draw_graphic() to render to the 640x400 display surface it had 
> without resizing it.
> 
> The bug is triggered if you manage to screendump after a screen 
> resolution change, but before the next bitblit or console refresh.  If 
> no vnc or sdl client is connected, that's just the next bitblt so the 
> window is considerably longer.


This explains why it is so hard to reproduce.

 
> I'll follow up with a patch.  Anthony, please revert 6989 before 
> applying it.  Thanks to Stefano for pointing out the problems with the 
> patch.
> 


No problem :)