Re: [Qemu-devel] [6989] Fix display breakage when resizing the screen (v2) (Avi Kivity)

[Avi Kivity <avi@redhat.com>]

Stefano Stabellini wrote:
> Avi Kivity wrote:
>
>   
>> Stefano Stabellini wrote:
>>     
>>> I tried several times to manually reproduce the issue with no luck: if
>>> no vnc clients are supposed to be connected, how do you make the cirrus
>>> emulated hw do a bitblit?
>>>   
>>>       
>> The guest will boot and do it by itself.
>>     
>
>
> what is the OS?
>   

In the cases I saw, I think it was Windows.  Sorry, I can't be sure and 
I didn't keep any records.

>>> In any case it makes sense that the problem is in qemu_console_copy()
>>> rather than in the rop function itself that only operates on the
>>> emulated framebuffer.
>>> But calling qemu_console_copy() in cirrus_do_copy() shouldn't be risky
>>> because before that, we call vga_hw_update() that should do the resize.
>>>   
>>>       
>> vga_hw_update() may not actually do anything if the conditions are 
>> right, and maybe that's the case here.
>>     
>
> I thought about it, but if vga_hw_update does nothing, then
> qemu_console_copy does nothing too.
>   

True.

>>> Without a better understanding of the bug I will refrain from making any
>>> suggestion.
>>>
>>>   
>>>       
>> There's a backtrace in 
>> https://bugzilla.redhat.com/show_bug.cgi?id=494002.  I'll also try to 
>> generate a good scenario for reproducing this.
>>
>>     
>
>
> thanks, that would be very useful (if it doesn't require me to compile
> kvm it would be even better :)).
>   

If you're running a recent distro it's already built in :)

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.