[RFC] make "LDFLAGS ignored" QA errors fatal

["Jeremy Lainé" <jeremy.laine@bolloretelecom.eu>]

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I have spent quite some time cleaning up a bunch of recipes which were
triggering "LDFLAGS ignored" QA errors, and I don't really want to
have to do this again in the future. I suggest we stop whitelisting
this kind of QA error, using the attached patch.

To track down the faulty packages I have made use of oestats output
(note that not all QA errors are "LDFLAGS ignored"):

http://tinderbox.openembedded.net/packages/?qalog=1

In most cases, the problem is that recipes simply pass
- -L${STAGING_LIBDIR} as LDFLAGS instead of using the full ${LDFLAGS}
variable. The result is that flags such as --hash-style=gnu are
getting ignored.

What are your thoughts?

- --
Jeremy LAINE
Bolloré telecom | 11bis, rue Scribe | F-75009 Paris
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAknaLysACgkQCL1n3lVB9EZgbQCgoQpUwdae7elUHWag8wqAROY7
D0sAmQGjH0zrO8OxgI5MPfSAshQz9Fuu
=to11
-----END PGP SIGNATURE-----


[-- Attachment #2: fatal_ldflags.patch --]
[-- Type: text/x-diff, Size: 450 bytes --]

diff --git a/classes/insane.bbclass b/classes/insane.bbclass
index 3e519c3..9fc5f07 100644
--- a/classes/insane.bbclass
+++ b/classes/insane.bbclass
@@ -184,7 +184,7 @@ def package_qa_make_fatal_error(error_class, name, path,d):
 
     TODO: Load a whitelist of known errors
     """
-    return not error_class in [0, 5, 7, 9]
+    return not error_class in [0, 5, 7]
 
 def package_qa_write_error(error_class, name, path, d):
     """

[-- Attachment #3: fatal_ldflags.patch.sig --]
[-- Type: application/octet-stream, Size: 72 bytes --]