Re: [RFC] make "LDFLAGS ignored" QA errors fatal

[Koen Kooi <k.kooi@student.utwente.nl>]

On 06-04-09 18:34, Jeremy Lainé wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> I have spent quite some time cleaning up a bunch of recipes which were
> triggering "LDFLAGS ignored" QA errors, and I don't really want to
> have to do this again in the future. I suggest we stop whitelisting
> this kind of QA error, using the attached patch.
>
> To track down the faulty packages I have made use of oestats output
> (note that not all QA errors are "LDFLAGS ignored"):
>
> http://tinderbox.openembedded.net/packages/?qalog=1
>
> In most cases, the problem is that recipes simply pass
> - -L${STAGING_LIBDIR} as LDFLAGS instead of using the full ${LDFLAGS}
> variable. The result is that flags such as --hash-style=gnu are
> getting ignored.
>
> What are your thoughts?

I think making them fatal is a good idea. I do have some recipes where I 
can't fix LDFLAGS properly yet, but I can do INSANE_SKIP = 1 inside 
those for the time being.

So: +1

regards,

Koen