Re: [RFC] make "LDFLAGS ignored" QA errors fatal

[Koen Kooi <k.kooi@student.utwente.nl>]

On 06-04-09 23:49, Khem Raj wrote:
> On 4/6/09, Jeremy Lainé<jeremy.laine@bolloretelecom.eu>  wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> I have spent quite some time cleaning up a bunch of recipes which were
>> triggering "LDFLAGS ignored" QA errors, and I don't really want to
>> have to do this again in the future. I suggest we stop whitelisting
>> this kind of QA error, using the attached patch.
>>
>> To track down the faulty packages I have made use of oestats output
>> (note that not all QA errors are "LDFLAGS ignored"):
>>
>> http://tinderbox.openembedded.net/packages/?qalog=1
>>
>> In most cases, the problem is that recipes simply pass
>> - -L${STAGING_LIBDIR} as LDFLAGS instead of using the full ${LDFLAGS}
>> variable. The result is that flags such as --hash-style=gnu are
>> getting ignored.
>
> I think we should configure toolchain to pass this flags by gcc driver
> while linking instead of making it a part of LDFLAGS it should help in
> recipes which use gcc to link.

While that would improve the situation a bit, it would also mean that 
we'll have a harder time detecting which recipes ignore LDFLAGS.

regards,

Koen