From: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
To: Kumar Gala <galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
Cc: Linux/PPC Development
<linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org>,
devicetree-discuss
<devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
Subject: Re: [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable
Date: Wed, 08 Apr 2009 21:55:48 +0200 [thread overview]
Message-ID: <49DD0144.7050902@grandegger.com> (raw)
In-Reply-To: <E9E24C93-F147-49F0-9FBE-FCE4883D11BF-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
Kumar Gala wrote:
>
> On Apr 8, 2009, at 2:25 AM, Wolfgang Grandegger wrote:
>
>>> So I'm a bit concerned with the output we now get:
>>>
>>> mpc-i2c fffe03000.i2c: clock 0 Hz (dfsrr=16 fdr=49)
>>>
>>> why 0? is that right?
>>
>> This is the backward compatibility mode using hard-coded FDR values. The
>> output is missleading, I agree.
>>
>> Wolfgang.
>
> Can the output be fixed. 0 Hz seemed bad to me.
Of course. No info message will be printed for the legacy case
like it was with the old driver version. I just realized a bug in the
MPC52xx part. Will send patches tomorrow, after some more thorough testing.
Wolfgang.
WARNING: multiple messages have this Message-ID (diff)
From: Wolfgang Grandegger <wg@grandegger.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Linux/PPC Development <linuxppc-dev@ozlabs.org>,
devicetree-discuss <devicetree-discuss@ozlabs.org>,
linux-i2c@vger.kernel.org, Ben Dooks <ben-linux@fluff.org>
Subject: Re: [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable
Date: Wed, 08 Apr 2009 21:55:48 +0200 [thread overview]
Message-ID: <49DD0144.7050902@grandegger.com> (raw)
In-Reply-To: <E9E24C93-F147-49F0-9FBE-FCE4883D11BF@kernel.crashing.org>
Kumar Gala wrote:
>
> On Apr 8, 2009, at 2:25 AM, Wolfgang Grandegger wrote:
>
>>> So I'm a bit concerned with the output we now get:
>>>
>>> mpc-i2c fffe03000.i2c: clock 0 Hz (dfsrr=16 fdr=49)
>>>
>>> why 0? is that right?
>>
>> This is the backward compatibility mode using hard-coded FDR values. The
>> output is missleading, I agree.
>>
>> Wolfgang.
>
> Can the output be fixed. 0 Hz seemed bad to me.
Of course. No info message will be printed for the legacy case
like it was with the old driver version. I just realized a bug in the
MPC52xx part. Will send patches tomorrow, after some more thorough testing.
Wolfgang.
next prev parent reply other threads:[~2009-04-08 19:55 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-07 8:20 [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable Wolfgang Grandegger
2009-04-07 8:20 ` [PATCH v3 1/5] i2c: i2c-mpc: various coding style fixes Wolfgang Grandegger
2009-04-07 8:20 ` Wolfgang Grandegger
[not found] ` <20090407082231.177941706-ynQEQJNshbs@public.gmane.org>
2009-04-07 15:36 ` Grant Likely
2009-04-07 15:36 ` Grant Likely
2009-04-07 8:20 ` [PATCH v3 2/5] i2c: i2c-mpc: use dev based printout function Wolfgang Grandegger
2009-04-07 8:20 ` Wolfgang Grandegger
[not found] ` <20090407082231.335327816-ynQEQJNshbs@public.gmane.org>
2009-04-07 15:37 ` Grant Likely
2009-04-07 15:37 ` Grant Likely
2009-04-07 8:20 ` [PATCH v3 3/5] i2c: i2c-mpc: make I2C bus speed configurable Wolfgang Grandegger
2009-04-07 8:20 ` Wolfgang Grandegger
[not found] ` <20090407082231.500525932-ynQEQJNshbs@public.gmane.org>
2009-04-07 15:36 ` Grant Likely
2009-04-07 15:36 ` Grant Likely
2012-11-01 19:19 ` Tabi Timur-B04825
2012-11-07 16:40 ` Timur Tabi
[not found] ` <509A8F0F.4070806-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-11-16 13:29 ` Wolfram Sang
[not found] ` <20121116132939.GB7313-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-11-16 16:09 ` Timur Tabi
2009-04-07 8:20 ` [PATCH v3 4/5] powerpc: i2c-mpc: document new FSL I2C bindings and cleanup Wolfgang Grandegger
2009-04-07 8:20 ` Wolfgang Grandegger
[not found] ` <20090407082231.646648985-ynQEQJNshbs@public.gmane.org>
2009-04-07 15:43 ` Grant Likely
2009-04-07 15:43 ` Grant Likely
2009-04-08 5:13 ` Kumar Gala
2009-04-08 5:13 ` Kumar Gala
2009-04-07 8:20 ` [PATCH v3 5/5] powerpc/85xx: i2c-mpc: use new I2C bindings for the Socates board Wolfgang Grandegger
2009-04-07 8:20 ` Wolfgang Grandegger
[not found] ` <20090407082231.803193635-ynQEQJNshbs@public.gmane.org>
2009-04-07 15:43 ` Grant Likely
2009-04-07 15:43 ` Grant Likely
2009-04-08 7:16 ` Wolfgang Grandegger
2009-04-08 14:53 ` Grant Likely
2009-04-08 14:53 ` Grant Likely
[not found] ` <fa686aa40904080753p2b282338r9ba463c47f897fb-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-04-08 18:27 ` Wolfgang Grandegger
2009-04-08 18:27 ` Wolfgang Grandegger
[not found] ` <49DCEC80.2050507-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2009-04-08 18:43 ` Kumar Gala
2009-04-08 18:43 ` Kumar Gala
[not found] ` <C3323B74-40FE-41BC-A49C-C94D7DB3FF5A-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2009-04-08 18:53 ` Wolfgang Grandegger
2009-04-08 18:53 ` Wolfgang Grandegger
[not found] ` <20090407082052.477328750-ynQEQJNshbs@public.gmane.org>
2009-04-08 5:11 ` [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable Kumar Gala
2009-04-08 5:11 ` Kumar Gala
[not found] ` <53B42D49-C040-442E-8448-7BC3190220A5-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2009-04-08 5:16 ` Grant Likely
2009-04-08 5:16 ` Grant Likely
2009-04-08 5:22 ` Kumar Gala
2009-04-08 5:32 ` Grant Likely
2009-04-08 5:32 ` Grant Likely
[not found] ` <5FDB097C-7D71-41DF-A4F4-2DE34FD710C5-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2009-04-08 7:21 ` Wolfgang Grandegger
2009-04-08 7:21 ` Wolfgang Grandegger
2009-04-08 17:03 ` Scott Wood
2009-04-08 17:49 ` Kumar Gala
2009-04-08 5:28 ` Kumar Gala
[not found] ` <F4E3E1FF-C544-460A-AC27-DB9501C13ED3-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2009-04-08 7:25 ` Wolfgang Grandegger
2009-04-08 7:25 ` Wolfgang Grandegger
[not found] ` <49DC515F.3040100-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2009-04-08 15:21 ` Kumar Gala
2009-04-08 15:21 ` Kumar Gala
[not found] ` <E9E24C93-F147-49F0-9FBE-FCE4883D11BF-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2009-04-08 19:55 ` Wolfgang Grandegger [this message]
2009-04-08 19:55 ` Wolfgang Grandegger
2009-04-09 9:59 ` Wolfgang Grandegger
2009-04-20 9:01 ` Wolfgang Grandegger
2009-04-20 13:26 ` Grant Likely
2009-04-20 13:26 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49DD0144.7050902@grandegger.com \
--to=wg-5yr1bzd7o62+xt7jha+gda@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
--cc=galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.