* grub-fstest build issue in grub2-r2071 +
@ 2009-04-14 1:06 John Stanley
2009-04-14 1:54 ` Pavel Roskin
0 siblings, 1 reply; 6+ messages in thread
From: John Stanley @ 2009-04-14 1:06 UTC (permalink / raw)
To: grub-devel
Hi all,
I have built grub2-r2065 and it works nicely for me so far for linux
boots (love the graphics!!). However, beginning with r2071, I am unable
to build it with the "--enable-grub-fstest" option due to several
undefined refs:
#
---------------------------------------------------------------------------------------------------------
# Fix grub_fstest-normal_misc.o unresolve ref error:
# In function `grub_normal_print_device_info':
# /build/grub2-r2077-jps_src/grub2-r2077/normal/misc.c:74: undefined
reference to `grub_unixtime2datetime'
# /build/grub2-r2077-jps_src/grub2-r2077/normal/misc.c:75: undefined
reference to `grub_get_weekday_name'
# grub_fstest-commands_ls.o: In function `print_files_long':
# /build/grub2-r2077-jps_src/grub2-r2077/commands/ls.c:149: undefined
reference to `grub_unixtime2datetime'
# /build/grub2-r2077-jps_src/grub2-r2077/commands/ls.c:151: undefined
reference to `grub_get_weekday_name'
# collect2: ld returned 1 exit status
# make: *** [grub-fstest] Error 1
#
----------------------------------------------------------------------------------------------------------
# conf/common.rmk is used by configure to generate conf/common.mk, so
modify the former.
To handle this (I'm now building r2101), I add normal/datetime to the
grub-fstest build specs,
as follows:
#
-----------------------------------------------------------------------------------------------------------------
# Only add normal/datetime.c if not present:
sed '/grub-fstest.c_DEPENDENCIES/,/For /{s:normal/datetime.c:jps:}' \
conf/common.rmk |grep -q jps ||
sed -i 's:^grub_fstest_SOURCES =:& normal/datetime.c:' conf/common.rmk
#
------------------------------------------------------------------------------------------------------------------
Has anyone come across this ? Actually, I'm not even sure what fstest is
used for, so I could simply remove the option when I do configure...
John
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: grub-fstest build issue in grub2-r2071 +
2009-04-14 1:06 grub-fstest build issue in grub2-r2071 + John Stanley
@ 2009-04-14 1:54 ` Pavel Roskin
2009-04-14 7:04 ` John Stanley
2009-04-14 9:17 ` John Stanley
0 siblings, 2 replies; 6+ messages in thread
From: Pavel Roskin @ 2009-04-14 1:54 UTC (permalink / raw)
To: The development of GRUB 2
On Mon, 2009-04-13 at 21:06 -0400, John Stanley wrote:
> Hi all,
>
> I have built grub2-r2065 and it works nicely for me so far for linux
> boots (love the graphics!!). However, beginning with r2071, I am unable
> to build it with the "--enable-grub-fstest" option due to several
> undefined refs:
It started in r2067.
> To handle this (I'm now building r2101), I add normal/datetime to the
> grub-fstest build specs,
Fixed in subversion. Thank you!
--
Regards,
Pavel Roskin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: grub-fstest build issue in grub2-r2071 +
2009-04-14 1:54 ` Pavel Roskin
@ 2009-04-14 7:04 ` John Stanley
2009-04-14 9:17 ` John Stanley
1 sibling, 0 replies; 6+ messages in thread
From: John Stanley @ 2009-04-14 7:04 UTC (permalink / raw)
To: The development of GRUB 2
Hi Again,
Thanks, r2104 builds with --enable-grub-fstest now, but a new problem,
not present in r2101 has surfaced: the command grub-probe now aborts on
my system with xfs filesystems. Therefore, I cannot run grub-install
(even with --modules=xfs). With rev's 2101, 2087, 2077, 2071, and 2065
grub-probe ran without error. Here's my hd config:
#device mount-point fs type options dump fsck
/dev/hda1 swap swap defaults 0 0
/dev/hda2 / xfs defaults 1 1
and here's the output of grub-probe (r2104):
# grub-probe -v --target=fs --device /dev/hda2
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd1 is 156301488
grub-probe: info: the size of hd1 is 156301488
grub-probe: info: the size of hd1 is 156301488
grub-probe: info: the size of hd1 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd1 is 156301488
grub-probe: info: the size of hd1 is 156301488
grub-probe: info: the size of hd1 is 156301488
grub-probe: info: the size of hd1 is 156301488
grub-probe: info: /dev/hda2 starts from 2056320
grub-probe: info: opening the device hd0
grub-probe: info: the size of hd0 is 156301488
Aborted
thanks again,
John
Pavel Roskin wrote:
> On Mon, 2009-04-13 at 21:06 -0400, John Stanley wrote:
>
>> Hi all,
>>
>> I have built grub2-r2065 and it works nicely for me so far for linux
>> boots (love the graphics!!). However, beginning with r2071, I am unable
>> to build it with the "--enable-grub-fstest" option due to several
>> undefined refs:
>>
>
> It started in r2067.
>
>
>> To handle this (I'm now building r2101), I add normal/datetime to the
>> grub-fstest build specs,
>>
>
> Fixed in subversion. Thank you!
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: grub-fstest build issue in grub2-r2071 +
2009-04-14 9:17 ` John Stanley
@ 2009-04-14 8:53 ` David Miller
2009-04-14 9:07 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2009-04-14 8:53 UTC (permalink / raw)
To: grub-devel, jpsinthemix
From: John Stanley <jpsinthemix@verizon.net>
Date: Tue, 14 Apr 2009 05:17:44 -0400
> An update: I looked at the change between r2077 and r2104 and it looks
> like the relevant code is util/hostdisk.c; I've attached a patch that
> appears to fix the problem.
Sorry about that bug.
I did test that patch, I wonder why it worked for me :-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: grub-fstest build issue in grub2-r2071 +
2009-04-14 8:53 ` David Miller
@ 2009-04-14 9:07 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2009-04-14 9:07 UTC (permalink / raw)
To: grub-devel
From: David Miller <davem@davemloft.net>
Date: Tue, 14 Apr 2009 01:53:00 -0700 (PDT)
> From: John Stanley <jpsinthemix@verizon.net>
> Date: Tue, 14 Apr 2009 05:17:44 -0400
>
>> An update: I looked at the change between r2077 and r2104 and it looks
>> like the relevant code is util/hostdisk.c; I've attached a patch that
>> appears to fix the problem.
>
> Sorry about that bug.
>
> I did test that patch, I wonder why it worked for me :-)
I commited your fix with some minor coding style fixes.
Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: grub-fstest build issue in grub2-r2071 +
2009-04-14 1:54 ` Pavel Roskin
2009-04-14 7:04 ` John Stanley
@ 2009-04-14 9:17 ` John Stanley
2009-04-14 8:53 ` David Miller
1 sibling, 1 reply; 6+ messages in thread
From: John Stanley @ 2009-04-14 9:17 UTC (permalink / raw)
To: The development of GRUB 2, The development of GRUB 2
[-- Attachment #1: Type: text/plain, Size: 2697 bytes --]
An update: I looked at the change between r2077 and r2104 and it looks
like the relevant code is util/hostdisk.c; I've attached a patch that
appears to fix the problem.
John
Hi Again,
Thanks, r2104 builds with --enable-grub-fstest now, but a new problem,
not present in r2101 has surfaced: the command grub-probe now aborts on
my system with xfs filesystems. Therefore, I cannot run grub-install
(even with --modules=xfs). With rev's 2101, 2087, 2077, 2071, and 2065
grub-probe ran without error. Here's my hd config:
#device mount-point fs type options dump fsck
/dev/hda1 swap swap defaults 0 0
/dev/hda2 / xfs defaults 1 1
and here's the output of grub-probe (r2104):
# grub-probe -v --target=fs --device /dev/hda2
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd1 is 156301488
grub-probe: info: the size of hd1 is 156301488
grub-probe: info: the size of hd1 is 156301488
grub-probe: info: the size of hd1 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd1 is 156301488
grub-probe: info: the size of hd1 is 156301488
grub-probe: info: the size of hd1 is 156301488
grub-probe: info: the size of hd1 is 156301488
grub-probe: info: /dev/hda2 starts from 2056320
grub-probe: info: opening the device hd0
grub-probe: info: the size of hd0 is 156301488
Aborted
thanks again,
John
Pavel Roskin wrote:
> On Mon, 2009-04-13 at 21:06 -0400, John Stanley wrote:
>
>> Hi all,
>>
>> I have built grub2-r2065 and it works nicely for me so far for linux
>> boots (love the graphics!!). However, beginning with r2071, I am unable
>> to build it with the "--enable-grub-fstest" option due to several
>> undefined refs:
>>
>
> It started in r2067.
>
>
>> To handle this (I'm now building r2101), I add normal/datetime to the
>> grub-fstest build specs,
>>
>
> Fixed in subversion. Thank you!
>
>
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
[-- Attachment #2: grub2-r2104-util_hostdisk.c.diff --]
[-- Type: text/plain, Size: 1004 bytes --]
*** grub2-r2104.orig/util/hostdisk.c 2009-04-13 23:06:08.000000000 -0400
--- grub2-r2104/util/hostdisk.c 2009-04-14 04:57:48.736246452 -0400
***************
*** 625,636 ****
int len = strlen(map[drive].drive);
char *p;
! if (dos_part >= 0)
! len += 1 + ((dos_part + 1) / 10);
if (bsd_part >= 0)
len += 2;
! p = xmalloc (len);
sprintf (p, "%s", map[drive].drive);
if (dos_part >= 0)
--- 625,644 ----
int len = strlen(map[drive].drive);
char *p;
! if (dos_part >= 0) {
! // Add in char length of dos_part+1
! int tmp = dos_part + 1;
! ++len;
! while ( (tmp /= 10) ) len++;
! }
if (bsd_part >= 0)
len += 2;
! // Length to alloc is: char length of map[drive].drive, plus
! // char length of (dos_part+1) or of bsd_part, plus
! // 2 for the comma and a null/end of string (\0)
! p = xmalloc (len+2);
!
sprintf (p, "%s", map[drive].drive);
if (dos_part >= 0)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-04-14 9:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-14 1:06 grub-fstest build issue in grub2-r2071 + John Stanley
2009-04-14 1:54 ` Pavel Roskin
2009-04-14 7:04 ` John Stanley
2009-04-14 9:17 ` John Stanley
2009-04-14 8:53 ` David Miller
2009-04-14 9:07 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.