All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Jens Axboe <jens.axboe@oracle.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Theodore Ts'o <tytso@mit.edu>, Shawn Du <duyuyang@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-btrace@vger.kernel.org
Subject: Re: PATCH 1/3] blktrace: support per-partition tracing
Date: Tue, 14 Apr 2009 08:14:03 +0000	[thread overview]
Message-ID: <49E445CB.4030001@cn.fujitsu.com> (raw)
In-Reply-To: <20090414075947.GA27003@elte.hu>

>> @@ -193,6 +194,7 @@ extern void __trace_note_message(struct blk_trace *, const char *fmt, ...);
>>  extern void blk_add_driver_data(struct request_queue *q, struct request *rq,
>>  				void *data, size_t len);
>>  extern int blk_trace_setup(struct request_queue *q, char *name, dev_t dev,
>> +			   struct block_device *bdev,
>>  			   char __user *arg);
>>  extern int blk_trace_startstop(struct request_queue *q, int start);
>>  extern int blk_trace_remove(struct request_queue *q);
> 
> Small detail: you forgot about the !CONFIG_BLK_DEV_IO_TRACE case 
> here, the wrapper macros there need to be updated.
> 

Ah, sorry..

> (no need to resend - i fixed this up in the 1/3 and 3/3 patches)
> 

and thanks! (But I think only 1/3 patch needs to be fixed)

The 3rd patch can be for 2.6.30, if Ted or somene else wants to use
ftrace-plugin blktrace to trace dm devices in 2.6.30.

--
Zefan

WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizf@cn.fujitsu.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Jens Axboe <jens.axboe@oracle.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	"Theodore Ts'o" <tytso@mit.edu>, Shawn Du <duyuyang@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-btrace@vger.kernel.org
Subject: Re: PATCH 1/3] blktrace: support per-partition tracing
Date: Tue, 14 Apr 2009 16:14:03 +0800	[thread overview]
Message-ID: <49E445CB.4030001@cn.fujitsu.com> (raw)
In-Reply-To: <20090414075947.GA27003@elte.hu>

>> @@ -193,6 +194,7 @@ extern void __trace_note_message(struct blk_trace *, const char *fmt, ...);
>>  extern void blk_add_driver_data(struct request_queue *q, struct request *rq,
>>  				void *data, size_t len);
>>  extern int blk_trace_setup(struct request_queue *q, char *name, dev_t dev,
>> +			   struct block_device *bdev,
>>  			   char __user *arg);
>>  extern int blk_trace_startstop(struct request_queue *q, int start);
>>  extern int blk_trace_remove(struct request_queue *q);
> 
> Small detail: you forgot about the !CONFIG_BLK_DEV_IO_TRACE case 
> here, the wrapper macros there need to be updated.
> 

Ah, sorry..

> (no need to resend - i fixed this up in the 1/3 and 3/3 patches)
> 

and thanks! (But I think only 1/3 patch needs to be fixed)

The 3rd patch can be for 2.6.30, if Ted or somene else wants to use
ftrace-plugin blktrace to trace dm devices in 2.6.30.

--
Zefan

  reply	other threads:[~2009-04-14  8:14 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-14  5:58 PATCH 1/3] blktrace: support per-partition tracing Li Zefan
2009-04-14  5:58 ` Li Zefan
2009-04-14  5:59 ` [PATCH 2/3] blktrace: support per-partition tracing for ftrace plugin Li Zefan
2009-04-14  5:59   ` Li Zefan
2009-04-15 10:13   ` [tip:tracing/core] " tip-bot for Li Zefan
2009-04-16 16:15   ` tip-bot for Li Zefan
2009-04-14  6:00 ` [PATCH 3/3] blktrace: add trace/ to /sys/block/sda Li Zefan
2009-04-14  6:00   ` Li Zefan
2009-04-15 10:13   ` [tip:tracing/core] " tip-bot for Li Zefan
2009-04-16 16:15   ` tip-bot for Li Zefan
2009-04-14  7:59 ` PATCH 1/3] blktrace: support per-partition tracing Ingo Molnar
2009-04-14  7:59   ` Ingo Molnar
2009-04-14  8:14   ` Li Zefan [this message]
2009-04-14  8:14     ` Li Zefan
2009-04-14  8:34     ` Ingo Molnar
2009-04-14  8:34       ` Ingo Molnar
2009-04-14  8:09 ` Ingo Molnar
2009-04-14  8:09   ` Ingo Molnar
2009-04-14  8:27   ` Li Zefan
2009-04-14  8:27     ` Li Zefan
2009-04-14  8:38     ` Ingo Molnar
2009-04-14  8:38       ` Ingo Molnar
2009-04-14  8:53       ` Li Zefan
2009-04-14  8:53         ` Li Zefan
2009-04-14  9:43         ` Ingo Molnar
2009-04-14  9:43           ` Ingo Molnar
2009-04-15 10:12 ` [tip:tracing/core] " tip-bot for Shawn Du
2009-04-16 16:15 ` tip-bot for Shawn Du

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49E445CB.4030001@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=acme@redhat.com \
    --cc=duyuyang@gmail.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-btrace@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.