All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Tom Zanussi <tzanussi@gmail.com>,
	Jens Axboe <jens.axboe@oracle.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Theodore Ts'o <tytso@mit.edu>, Shawn Du <duyuyang@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-btrace@vger.kernel.org
Subject: Re: PATCH 1/3] blktrace: support per-partition tracing
Date: Tue, 14 Apr 2009 08:53:41 +0000	[thread overview]
Message-ID: <49E44F15.9030906@cn.fujitsu.com> (raw)
In-Reply-To: <20090414083856.GF27003@elte.hu>

>>> Lets note that this approach still has the (long existing) 
>>> limitation that only one device can be block-traced at a time.
>>>
>> No, both userspace blktrace and ftrace-plugin trace can trace
>> more than one device at a time.
>>
>>  # btrace /dev/sda /dev/dm-0
>>
>> or
>>
>>  # echo 1 > /sys/block/sda/trace/enable
>>  # echo 1 > /sys/block/dm-0/trace/enable
> 
> When they are independent - but not multiple partitions at a time:
> 

The only way to trace multipl partitions is to trace the whole
sda, or set trace/start_lsa and trace/end_lsa properly.

>  [root@aldebaran ~]# echo 1 > /sys/block/sda/sda1/trace/enable 
>  [root@aldebaran ~]# echo 1 > /sys/block/sda/sda2/trace/enable 
>  -bash: echo: write error: Device or resource busy

That's because struct blk_trace is attached to struct request_queue,
sda1 and sda2 share the same rq:

  # echo 1 > /sys/block/sda/sda1/trace/enable 
  # cat /sys/block/sda/sda1/trace/enable 
  1
  # cat /sys/block/sda/sda2/trace/enable 
  1

>  [root@aldebaran ~]#
> 
> Nor did i see any "trace all block IO in the system" kind of 
> functionality in blktrace. (or maybe there's one that i missed?)
> 

Right, and the only way to do this is 'blktrace sda sdb sdc ...'

WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizf@cn.fujitsu.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Tom Zanussi <tzanussi@gmail.com>,
	Jens Axboe <jens.axboe@oracle.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	"Theodore Ts'o" <tytso@mit.edu>, Shawn Du <duyuyang@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-btrace@vger.kernel.org
Subject: Re: PATCH 1/3] blktrace: support per-partition tracing
Date: Tue, 14 Apr 2009 16:53:41 +0800	[thread overview]
Message-ID: <49E44F15.9030906@cn.fujitsu.com> (raw)
In-Reply-To: <20090414083856.GF27003@elte.hu>

>>> Lets note that this approach still has the (long existing) 
>>> limitation that only one device can be block-traced at a time.
>>>
>> No, both userspace blktrace and ftrace-plugin trace can trace
>> more than one device at a time.
>>
>>  # btrace /dev/sda /dev/dm-0
>>
>> or
>>
>>  # echo 1 > /sys/block/sda/trace/enable
>>  # echo 1 > /sys/block/dm-0/trace/enable
> 
> When they are independent - but not multiple partitions at a time:
> 

The only way to trace multipl partitions is to trace the whole
sda, or set trace/start_lsa and trace/end_lsa properly.

>  [root@aldebaran ~]# echo 1 > /sys/block/sda/sda1/trace/enable 
>  [root@aldebaran ~]# echo 1 > /sys/block/sda/sda2/trace/enable 
>  -bash: echo: write error: Device or resource busy

That's because struct blk_trace is attached to struct request_queue,
sda1 and sda2 share the same rq:

  # echo 1 > /sys/block/sda/sda1/trace/enable 
  # cat /sys/block/sda/sda1/trace/enable 
  1
  # cat /sys/block/sda/sda2/trace/enable 
  1

>  [root@aldebaran ~]#
> 
> Nor did i see any "trace all block IO in the system" kind of 
> functionality in blktrace. (or maybe there's one that i missed?)
> 

Right, and the only way to do this is 'blktrace sda sdb sdc ...'

  reply	other threads:[~2009-04-14  8:53 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-14  5:58 PATCH 1/3] blktrace: support per-partition tracing Li Zefan
2009-04-14  5:58 ` Li Zefan
2009-04-14  5:59 ` [PATCH 2/3] blktrace: support per-partition tracing for ftrace plugin Li Zefan
2009-04-14  5:59   ` Li Zefan
2009-04-15 10:13   ` [tip:tracing/core] " tip-bot for Li Zefan
2009-04-16 16:15   ` tip-bot for Li Zefan
2009-04-14  6:00 ` [PATCH 3/3] blktrace: add trace/ to /sys/block/sda Li Zefan
2009-04-14  6:00   ` Li Zefan
2009-04-15 10:13   ` [tip:tracing/core] " tip-bot for Li Zefan
2009-04-16 16:15   ` tip-bot for Li Zefan
2009-04-14  7:59 ` PATCH 1/3] blktrace: support per-partition tracing Ingo Molnar
2009-04-14  7:59   ` Ingo Molnar
2009-04-14  8:14   ` Li Zefan
2009-04-14  8:14     ` Li Zefan
2009-04-14  8:34     ` Ingo Molnar
2009-04-14  8:34       ` Ingo Molnar
2009-04-14  8:09 ` Ingo Molnar
2009-04-14  8:09   ` Ingo Molnar
2009-04-14  8:27   ` Li Zefan
2009-04-14  8:27     ` Li Zefan
2009-04-14  8:38     ` Ingo Molnar
2009-04-14  8:38       ` Ingo Molnar
2009-04-14  8:53       ` Li Zefan [this message]
2009-04-14  8:53         ` Li Zefan
2009-04-14  9:43         ` Ingo Molnar
2009-04-14  9:43           ` Ingo Molnar
2009-04-15 10:12 ` [tip:tracing/core] " tip-bot for Shawn Du
2009-04-16 16:15 ` tip-bot for Shawn Du

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49E44F15.9030906@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=acme@redhat.com \
    --cc=duyuyang@gmail.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-btrace@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=tytso@mit.edu \
    --cc=tzanussi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.