From: Gerd Hoffmann <kraxel@redhat.com>
To: Jiri Denemark <jdenemar@redhat.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] Fix xenconsole after aborted save
Date: Mon, 20 Apr 2009 16:09:25 +0200 [thread overview]
Message-ID: <49EC8215.6040800@redhat.com> (raw)
In-Reply-To: <20090420140436.GB18963@orkuz.home>
On 04/20/09 16:04, Jiri Denemark wrote:
> On Mon, Apr 20, 2009 at 15:38:41 +0200, Gerd Hoffmann wrote:
>> On 04/20/09 15:23, Jiri Denemark wrote:
>>> This patch modifies xenconsoled to check current status of open event channels
>>> and rebind them if necessary.
>> close() + open() is the sledge hammer approach (will work though). Just
>> unbind(local_port) should be enough.
>
> It doesn't close() and open(), it just calls xc_evtchn_bind_interdomain() in
> case the event channel is unbound. The close() + open() combination was there
> before... I haven't touched that code except for skipping it when only rebind
> is required.
Oh, ok, got the logic wrong. The patch looks fine to me then.
cheers,
Gerd
next prev parent reply other threads:[~2009-04-20 14:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-20 13:23 [PATCH] Fix xenconsole after aborted save Jiri Denemark
2009-04-20 13:38 ` Gerd Hoffmann
2009-04-20 14:04 ` Jiri Denemark
2009-04-20 14:09 ` Gerd Hoffmann [this message]
2009-04-20 14:41 ` Keir Fraser
2009-04-20 15:58 ` Jiri Denemark
2009-04-22 9:49 ` Chris Lalancette
2009-04-22 10:22 ` Keir Fraser
2009-04-22 12:41 ` John Levon
2009-04-22 14:24 ` Chris Lalancette
2009-04-22 16:15 ` Neil Turton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49EC8215.6040800@redhat.com \
--to=kraxel@redhat.com \
--cc=jdenemar@redhat.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.