From: Neil Turton <nturton@solarflare.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: Jiri Denemark <jdenemar@redhat.com>,
Chris Lalancette <clalance@redhat.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH] Fix xenconsole after aborted save
Date: Wed, 22 Apr 2009 17:15:17 +0100 [thread overview]
Message-ID: <49EF4295.8010803@solarflare.com> (raw)
In-Reply-To: <C614AE59.9293%keir.fraser@eu.citrix.com>
Keir Fraser wrote:
> The suspend_cancel hook you are thinking of is for any PV devices which *do*
> need to know that a suspend was cancelled. Netaccel does for some reason
> which I cannot recall.
For the record, netaccel needs to remove any mappings of the hardware
during the suspend callback since those mappings are not valid after the
suspend has completed. Those hardware mappings (or the mappings
appropriate for the new machine) are restored on resume as a result of
the standard netfront/netback connection being re-established. If the
suspend is cancelled, the netfront/netback connection stays in place but
the hardware mappings need to be re-established which is why the
suspend_cancel callback is used.
Cheers, Neil.
prev parent reply other threads:[~2009-04-22 16:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-20 13:23 [PATCH] Fix xenconsole after aborted save Jiri Denemark
2009-04-20 13:38 ` Gerd Hoffmann
2009-04-20 14:04 ` Jiri Denemark
2009-04-20 14:09 ` Gerd Hoffmann
2009-04-20 14:41 ` Keir Fraser
2009-04-20 15:58 ` Jiri Denemark
2009-04-22 9:49 ` Chris Lalancette
2009-04-22 10:22 ` Keir Fraser
2009-04-22 12:41 ` John Levon
2009-04-22 14:24 ` Chris Lalancette
2009-04-22 16:15 ` Neil Turton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49EF4295.8010803@solarflare.com \
--to=nturton@solarflare.com \
--cc=clalance@redhat.com \
--cc=jdenemar@redhat.com \
--cc=keir.fraser@eu.citrix.com \
--cc=kraxel@redhat.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.