* [PATCH] OMAP OneNAND: add missing __devexit_p wrappers
@ 2009-04-29 11:59 Mika Korhonen
2009-04-29 13:15 ` Adrian Hunter
0 siblings, 1 reply; 6+ messages in thread
From: Mika Korhonen @ 2009-04-29 11:59 UTC (permalink / raw)
To: linux-omap
[-- Attachment #1: Type: text/plain, Size: 115 bytes --]
The patch follows as attachment as gmail damages whitespaces and
git-send-mail is right now out of question.
Mika
[-- Attachment #2: 0001-OMAP-OneNAND-add-missing-__devexit_p-wrappers.patch --]
[-- Type: text/x-patch, Size: 1046 bytes --]
From b72b537ff229a8d62540569bc543c419702ecb05 Mon Sep 17 00:00:00 2001
From: Mika Korhonen <mika.j.korhonen@gmail.com>
Date: Wed, 29 Apr 2009 14:10:34 +0300
Subject: [PATCH] OMAP OneNAND: add missing __devexit_p wrappers
Fixes build in configurations where devexit functions get discarded
Signed-off-by: Mika Korhonen <mika.j.korhonen@gmail.com>
---
drivers/mtd/onenand/omap2.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c
index f2e9de1..4882935 100644
--- a/drivers/mtd/onenand/omap2.c
+++ b/drivers/mtd/onenand/omap2.c
@@ -778,8 +778,8 @@ static int __devexit omap2_onenand_remove(struct platform_device *pdev)
static struct platform_driver omap2_onenand_driver = {
.probe = omap2_onenand_probe,
- .remove = omap2_onenand_remove,
- .shutdown = omap2_onenand_shutdown,
+ .remove = __devexit_p(omap2_onenand_remove),
+ .shutdown = __devexit_p(omap2_onenand_shutdown),
.driver = {
.name = DRIVER_NAME,
.owner = THIS_MODULE,
--
1.5.6.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] OMAP OneNAND: add missing __devexit_p wrappers
2009-04-29 11:59 [PATCH] OMAP OneNAND: add missing __devexit_p wrappers Mika Korhonen
@ 2009-04-29 13:15 ` Adrian Hunter
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Hunter @ 2009-04-29 13:15 UTC (permalink / raw)
To: Mika Korhonen
Cc: linux-mtd Mailing List, linux-omap@vger.kernel.org,
David Woodhouse
[-- Attachment #1: Type: text/plain, Size: 168 bytes --]
Mika Korhonen wrote:
> The patch follows as attachment as gmail damages whitespaces and
> git-send-mail is right now out of question.
This goes via MTD mailing list.
[-- Attachment #2: 0001-OMAP-OneNAND-add-missing-__devexit_p-wrappers.patch --]
[-- Type: text/x-diff, Size: 1047 bytes --]
>From b72b537ff229a8d62540569bc543c419702ecb05 Mon Sep 17 00:00:00 2001
From: Mika Korhonen <mika.j.korhonen@gmail.com>
Date: Wed, 29 Apr 2009 14:10:34 +0300
Subject: [PATCH] OMAP OneNAND: add missing __devexit_p wrappers
Fixes build in configurations where devexit functions get discarded
Signed-off-by: Mika Korhonen <mika.j.korhonen@gmail.com>
---
drivers/mtd/onenand/omap2.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c
index f2e9de1..4882935 100644
--- a/drivers/mtd/onenand/omap2.c
+++ b/drivers/mtd/onenand/omap2.c
@@ -778,8 +778,8 @@ static int __devexit omap2_onenand_remove(struct platform_device *pdev)
static struct platform_driver omap2_onenand_driver = {
.probe = omap2_onenand_probe,
- .remove = omap2_onenand_remove,
- .shutdown = omap2_onenand_shutdown,
+ .remove = __devexit_p(omap2_onenand_remove),
+ .shutdown = __devexit_p(omap2_onenand_shutdown),
.driver = {
.name = DRIVER_NAME,
.owner = THIS_MODULE,
--
1.5.6.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] OMAP OneNAND: add missing __devexit_p wrappers
@ 2009-04-29 13:15 ` Adrian Hunter
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Hunter @ 2009-04-29 13:15 UTC (permalink / raw)
To: Mika Korhonen
Cc: linux-omap@vger.kernel.org, David Woodhouse,
linux-mtd Mailing List
[-- Attachment #1: Type: text/plain, Size: 168 bytes --]
Mika Korhonen wrote:
> The patch follows as attachment as gmail damages whitespaces and
> git-send-mail is right now out of question.
This goes via MTD mailing list.
[-- Attachment #2: 0001-OMAP-OneNAND-add-missing-__devexit_p-wrappers.patch --]
[-- Type: text/x-diff, Size: 1047 bytes --]
>From b72b537ff229a8d62540569bc543c419702ecb05 Mon Sep 17 00:00:00 2001
From: Mika Korhonen <mika.j.korhonen@gmail.com>
Date: Wed, 29 Apr 2009 14:10:34 +0300
Subject: [PATCH] OMAP OneNAND: add missing __devexit_p wrappers
Fixes build in configurations where devexit functions get discarded
Signed-off-by: Mika Korhonen <mika.j.korhonen@gmail.com>
---
drivers/mtd/onenand/omap2.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c
index f2e9de1..4882935 100644
--- a/drivers/mtd/onenand/omap2.c
+++ b/drivers/mtd/onenand/omap2.c
@@ -778,8 +778,8 @@ static int __devexit omap2_onenand_remove(struct platform_device *pdev)
static struct platform_driver omap2_onenand_driver = {
.probe = omap2_onenand_probe,
- .remove = omap2_onenand_remove,
- .shutdown = omap2_onenand_shutdown,
+ .remove = __devexit_p(omap2_onenand_remove),
+ .shutdown = __devexit_p(omap2_onenand_shutdown),
.driver = {
.name = DRIVER_NAME,
.owner = THIS_MODULE,
--
1.5.6.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] OMAP OneNAND: add missing __devexit_p wrappers
2009-04-29 13:15 ` Adrian Hunter
@ 2009-04-29 17:55 ` David Brownell
-1 siblings, 0 replies; 6+ messages in thread
From: David Brownell @ 2009-04-29 17:55 UTC (permalink / raw)
To: Adrian Hunter
Cc: Mika Korhonen, linux-mtd Mailing List, linux-omap@vger.kernel.org,
David Woodhouse
On Wednesday 29 April 2009, Adrian Hunter wrote:
> + .shutdown = __devexit_p(omap2_onenand_shutdown),
That looks wrong. Shutdown functions shouldn't get discarded
like exit functions. I'd think the fix for that would be taking
away any __devexit annotation on the shutdown function.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] OMAP OneNAND: add missing __devexit_p wrappers
@ 2009-04-29 11:10 Mika Korhonen
0 siblings, 0 replies; 6+ messages in thread
From: Mika Korhonen @ 2009-04-29 11:10 UTC (permalink / raw)
To: linux-mtd
Fixes build in configurations where devexit functions get discarded
Signed-off-by: Mika Korhonen <mika.j.korhonen@gmail.com>
---
drivers/mtd/onenand/omap2.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c
index f2e9de1..4882935 100644
--- a/drivers/mtd/onenand/omap2.c
+++ b/drivers/mtd/onenand/omap2.c
@@ -778,8 +778,8 @@ static int __devexit omap2_onenand_remove(struct platform_device *pdev)
static struct platform_driver omap2_onenand_driver = {
.probe = omap2_onenand_probe,
- .remove = omap2_onenand_remove,
- .shutdown = omap2_onenand_shutdown,
+ .remove = __devexit_p(omap2_onenand_remove),
+ .shutdown = __devexit_p(omap2_onenand_shutdown),
.driver = {
.name = DRIVER_NAME,
.owner = THIS_MODULE,
--
1.5.6.5
--------------060606050107020605040104--
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-04-29 17:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-29 11:59 [PATCH] OMAP OneNAND: add missing __devexit_p wrappers Mika Korhonen
2009-04-29 13:15 ` Adrian Hunter
2009-04-29 13:15 ` Adrian Hunter
2009-04-29 17:55 ` David Brownell
2009-04-29 17:55 ` David Brownell
-- strict thread matches above, loose matches on Subject: below --
2009-04-29 11:10 Mika Korhonen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.