From: Andrew Gallatin <gallatin@myri.com>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
David Miller <davem@davemloft.net>,
brice@myri.com, sgruszka@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH] myr10ge: again fix lro_gen_skb() alignment
Date: Thu, 30 Apr 2009 15:14:05 -0400 [thread overview]
Message-ID: <49F9F87D.5060309@myri.com> (raw)
In-Reply-To: <49F95E9B.5020005@cosmosbay.com>
Eric Dumazet wrote:
>
>
> I wonder if you could try to enlarge 'struct page' by 8 bytes and
redo a test...
>
> Here is a patch to combine two ideas. But it wont allow GRO to go
much faster I guess :(
The patch seems to help both GRO and LRO a little with timestamps disabled,
but seems to hurt a little with them. I don't pretend to understand why:
LRO:
87380 65536 65536 60.00 8279.36 8.10 77.55 0.160 1.535
LRO + patch:
87380 65536 65536 60.01 7897.51 7.45 74.92 0.155 1.554
LRO + timestamp disable:
87380 65536 65536 60.02 7753.55 8.01 74.06 0.169 1.565
LRO + patch + timestamp disable:
87380 65536 65536 60.01 7915.63 7.74 74.57 0.160 1.544
GRO:
87380 65536 65536 60.00 8053.19 7.86 85.47 0.160 1.739
GRO + patch
87380 65536 65536 60.00 7910.02 7.69 85.86 0.159 1.778
GRO + timestamp disable:
87380 65536 65536 60.02 7535.12 7.27 84.57 0.158 1.839
GRO + timestamp disable + patch
87380 65536 65536 60.02 7735.26 7.92 83.68 0.168 1.772
Drew
next prev parent reply other threads:[~2009-04-30 19:15 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-15 8:09 [PATCH] myr10ge: again fix lro_gen_skb() alignment Stanislaw Gruszka
2009-04-15 9:28 ` David Miller
2009-04-15 9:48 ` Brice Goglin
2009-04-15 10:02 ` David Miller
2009-04-15 13:01 ` Andrew Gallatin
2009-04-15 21:04 ` Andrew Gallatin
2009-04-15 23:42 ` David Miller
2009-04-16 8:50 ` Herbert Xu
2009-04-16 9:02 ` David Miller
2009-04-21 19:19 ` Andrew Gallatin
2009-04-22 10:48 ` Herbert Xu
2009-04-22 15:37 ` Andrew Gallatin
2009-04-24 5:45 ` Herbert Xu
2009-04-24 12:45 ` Andrew Gallatin
2009-04-24 12:51 ` Herbert Xu
2009-04-24 17:13 ` Rick Jones
2009-04-24 16:16 ` Andrew Gallatin
2009-04-24 16:30 ` Herbert Xu
2009-04-24 16:31 ` Herbert Xu
2009-04-27 8:05 ` Herbert Xu
2009-04-27 8:07 ` Herbert Xu
2009-04-27 9:32 ` David Miller
2009-04-27 11:01 ` Herbert Xu
2009-04-27 12:45 ` David Miller
2009-04-27 12:45 ` David Miller
2009-04-28 6:12 ` Herbert Xu
2009-04-28 15:00 ` Andrew Gallatin
2009-04-28 15:02 ` David Miller
2009-04-28 15:20 ` Herbert Xu
2009-04-28 15:44 ` Andrew Gallatin
2009-04-28 21:12 ` Andrew Gallatin
2009-04-29 13:42 ` Andrew Gallatin
2009-04-29 13:53 ` Eric Dumazet
2009-04-29 14:18 ` Andrew Gallatin
2009-04-29 15:26 ` Eric Dumazet
2009-04-29 17:28 ` Andrew Gallatin
2009-04-30 8:10 ` Herbert Xu
2009-04-30 8:14 ` Herbert Xu
2009-04-30 8:17 ` Eric Dumazet
2009-04-30 19:14 ` Andrew Gallatin [this message]
2009-04-23 8:00 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F9F87D.5060309@myri.com \
--to=gallatin@myri.com \
--cc=brice@myri.com \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.