[RFC]: Remove #####...##### lines

[RFC]: Remove #####...##### lines

[Leon Woestenberg]

#############################################################################
#I am a bit annoyed by the hash lines in some of the files
#############################################################################
# They distract me from the real content of the files.
#############################################################################
RFC_REMOVE_HASHLINES ?= 1

Regards,
-- 
Leon

Re: [RFC]: Remove #####...##### lines

[Philip Balister]

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

Leon Woestenberg wrote:
> #############################################################################
> #I am a bit annoyed by the hash lines in some of the files
> #############################################################################
> # They distract me from the real content of the files.
> #############################################################################
> RFC_REMOVE_HASHLINES ?= 1

Although this might start a coding style war, I also find them distracting.

Philip

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/x-pkcs7-signature, Size: 3303 bytes --]

Re: [RFC]: Remove #####...##### lines

[Mike (mwester)]

Philip Balister wrote:
> Leon Woestenberg wrote:
>> #############################################################################
>>
>> #I am a bit annoyed by the hash lines in some of the files
>> #############################################################################
>>
>> # They distract me from the real content of the files.
>> #############################################################################
>>
>> RFC_REMOVE_HASHLINES ?= 1
> 
> Although this might start a coding style war, I also find them distracting.

Hehe!

Let's replace them with prettier formats:

#=#=#=#==#=#=#==#=#=#==#=#=#==#=#=#==#=#=#==#=#=#==#=#=#==#=#=#==#=#=#
#
#  I prefer this style.  For Major Section headers, anyway.
#
#=#=#=#==#=#=#==#=#=#==#=#=#==#=#=#==#=#=#==#=#=#==#=#=#==#=#=#==#=#=#

#---------------------------------------------------------------------
#
# And of course, this style is alway popular for Minor Section headers.
#
#---------------------------------------------------------------------



Consider the coding style war begun...  Seriously, I'd prefer we don't
worry too much about the comment styles.

Yes, some of the structures annoy me, and I would organize some of the
conf files differently, and some files have more blank lines than I
would like, and others need some  carefully-place blank lines in my
opinion, and while we're discussing this, I think the style rules that
PR = "r0" should never appear in a recipe is baloney; I feel very
strongly that should appear in all recipes....  this could become quite
the can of worms, I think.  :-)


RFC_REMOVE_HASHLINES--;

Or, rfcRemoveHashlines-- if camelCase is your preferred style... :-)


Mike (mwester)

Oops - or should that be:

~Mike (mwester)

;-D

Re: [RFC]: Remove #####...##### lines

[Frans Meulenbroeks]

2009/5/3 Mike (mwester) <mwester@dls.net>:
> Philip Balister wrote:
>> Leon Woestenberg wrote:
>>> #############################################################################
>>>
>>> #I am a bit annoyed by the hash lines in some of the files
>>> #############################################################################
>>>
>>> # They distract me from the real content of the files.
>>> #############################################################################
>>>
>>> RFC_REMOVE_HASHLINES ?= 1
>>
>> Although this might start a coding style war, I also find them distracting.
>
> Hehe!
>
> Let's replace them with prettier formats:
>
> #=#=#=#==#=#=#==#=#=#==#=#=#==#=#=#==#=#=#==#=#=#==#=#=#==#=#=#==#=#=#
> #
> #  I prefer this style.  For Major Section headers, anyway.
> #
> #=#=#=#==#=#=#==#=#=#==#=#=#==#=#=#==#=#=#==#=#=#==#=#=#==#=#=#==#=#=#
>
> #---------------------------------------------------------------------
> #
> # And of course, this style is alway popular for Minor Section headers.
> #
> #---------------------------------------------------------------------
>
>
>
> Consider the coding style war begun...  Seriously, I'd prefer we don't
> worry too much about the comment styles.
>
> Yes, some of the structures annoy me, and I would organize some of the
> conf files differently, and some files have more blank lines than I
> would like, and others need some  carefully-place blank lines in my
> opinion, and while we're discussing this, I think the style rules that
> PR = "r0" should never appear in a recipe is baloney; I feel very
> strongly that should appear in all recipes....  this could become quite
> the can of worms, I think.  :-)
>
>
> RFC_REMOVE_HASHLINES--;
>
> Or, rfcRemoveHashlines-- if camelCase is your preferred style... :-)
>
>
> Mike (mwester)
>
> Oops - or should that be:
>
> ~Mike (mwester)
>
> ;-D
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Hm. I don't like the hashes, but the alternative from Mike even seems
more disturbing ...

I do agree that PR = "r0" in a recipe should be ok. (actually I think
that unaware of this I violated that rule a number of times :-) )

Re: [RFC]: Remove #####...##### lines

[Bernhard Guillon]

Frans Meulenbroeks wrote:
> I do agree that PR = "r0" in a recipe should be ok. (actually I think
> that unaware of this I violated that rule a number of times :-) )
>
>   
I like PR = "r0"
Else it is easy to forget to bump it on updates. The manual also mention 
it [1].

best regards
Bernhard Guillon

1 http://docs.openembedded.org/usermanual/usermanual.html#recipes_versioning

Re: [RFC]: Remove #####...##### lines

[Denys Dmytriyenko]

On Sun, May 03, 2009 at 06:49:12PM +0200, Bernhard Guillon wrote:
> Frans Meulenbroeks wrote:
>> I do agree that PR = "r0" in a recipe should be ok. (actually I think
>> that unaware of this I violated that rule a number of times :-) )
>>
>>   
> I like PR = "r0"
> Else it is easy to forget to bump it on updates. The manual also mention it 
> [1].

+1 - I agree it's easy to forget to bump it, if it's not there...

-- 
Denys

Re: [RFC]: Remove #####...##### lines

[Phil Blundell]

On Sun, 2009-05-03 at 18:49 +0200, Bernhard Guillon wrote:
> Frans Meulenbroeks wrote:
> > I do agree that PR = "r0" in a recipe should be ok. (actually I think
> > that unaware of this I violated that rule a number of times :-) )
> >
> >   
> I like PR = "r0"
> Else it is easy to forget to bump it on updates. The manual also mention 
> it [1].

Yes, agreed.  I don't know where this idea came from that it's somehow a
bad thing to set PR = "r0" explicitly, but whatever its source I think
it is a mistaken belief.  It seems obviously silly to delete the PR
definition whenever a package is upgraded to a new upstream version, and
then re-insert it again on the next packaging change; aside from
anything else, it's just more typing than keeping the line intact and
just changing the value.

p.

Re: [RFC]: Remove #####...##### lines

[Leon Woestenberg]

Hello,

On Sun, May 3, 2009 at 3:40 PM, Mike (mwester) <mwester@dls.net> wrote:
> Philip Balister wrote:
>> Leon Woestenberg wrote:
>>> #############################################################################
>>>
>>> #I am a bit annoyed by the hash lines in some of the files
>>> #############################################################################
>>>
>>> # They distract me from the real content of the files.
>>> #############################################################################
>>>
>>> RFC_REMOVE_HASHLINES ?= 1
>>
>> Although this might start a coding style war, I also find them distracting.
>
> Let's replace them with prettier formats:
>

My proposal was to *remove* the hash lines, so we cannot have wars on them. :-)

Regards,
-- 
Leon 'peacekeeper' Woestenberg