[Xenomai-help] IXXAT-PCI-CAN driver hijacks my pci board

[Xenomai-help] IXXAT-PCI-CAN driver hijacks my pci board

[Stefan Kisdaroczi]

[-- Attachment #1: Type: text/plain, Size: 1276 bytes --]

Hi,

my pci board has the same pci-interface-chip as the IXXAT-PCI board.
The vendor and device id's are identical, but the subsys id is different.

The documentation for my board says that it is essential to check all ID values,
because vendor and device id are standard values for the pci-interface-chip.

dmesg output, there is no IXXAT-PCI-CAN board installed:
> RT-Socket-CAN 0.90.2 - (C) 2006 RT-Socket-CAN Development Team
> RTCAN SJA1000 driver initialized
> PCI: setting IRQ 12 as level-triggered
> IXXAT-PCI-CAN 0000:00:11.0: found PCI INT A -> IRQ 12
> IXXAT-PCI-CAN: Initializing device 10b5:9050:2503

The following patch fixed it for me (my own driver loads again).
However, i could not check if it still detects the CAN board,
as i dont have one.

Thanks
kisda

--- xenomai-2.4.7.orig/ksrc/drivers/can/sja1000/rtcan_ixxat_pci.c
+++ xenomai-2.4.7/ksrc/drivers/can/sja1000/rtcan_ixxat_pci.c
@@ -73,7 +73,7 @@
 #define IXXAT_BASE_PORT_SIZE 0x0400

 static struct pci_device_id ixxat_pci_tbl[] = {
-	{IXXAT_PCI_VENDOR_ID, IXXAT_PCI_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
+	{IXXAT_PCI_VENDOR_ID, IXXAT_PCI_DEVICE_ID, IXXAT_PCI_VENDOR_ID, IXXAT_PCI_SUB_SYS_ID, 0, 0, 0},
 	{ }
 };
 MODULE_DEVICE_TABLE (pci, ixxat_pci_tbl);



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]

Re: [Xenomai-core] [Xenomai-help] IXXAT-PCI-CAN driver hijacks my pci board

[Philippe Gerum]

It looks like this patch is still pending an ack/nak. Wolfgang, any
comment on this? TIA,

On Tue, 2009-05-05 at 21:04 +0200, Stefan Kisdaroczi wrote:
> Hi,
> 
> my pci board has the same pci-interface-chip as the IXXAT-PCI board.
> The vendor and device id's are identical, but the subsys id is different.
> 
> The documentation for my board says that it is essential to check all ID values,
> because vendor and device id are standard values for the pci-interface-chip.
> 
> dmesg output, there is no IXXAT-PCI-CAN board installed:
> > RT-Socket-CAN 0.90.2 - (C) 2006 RT-Socket-CAN Development Team
> > RTCAN SJA1000 driver initialized
> > PCI: setting IRQ 12 as level-triggered
> > IXXAT-PCI-CAN 0000:00:11.0: found PCI INT A -> IRQ 12
> > IXXAT-PCI-CAN: Initializing device 10b5:9050:2503
> 
> The following patch fixed it for me (my own driver loads again).
> However, i could not check if it still detects the CAN board,
> as i dont have one.
> 
> Thanks
> kisda
> 
> --- xenomai-2.4.7.orig/ksrc/drivers/can/sja1000/rtcan_ixxat_pci.c
> +++ xenomai-2.4.7/ksrc/drivers/can/sja1000/rtcan_ixxat_pci.c
> @@ -73,7 +73,7 @@
>  #define IXXAT_BASE_PORT_SIZE 0x0400
> 
>  static struct pci_device_id ixxat_pci_tbl[] = {
> -	{IXXAT_PCI_VENDOR_ID, IXXAT_PCI_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
> +	{IXXAT_PCI_VENDOR_ID, IXXAT_PCI_DEVICE_ID, IXXAT_PCI_VENDOR_ID, IXXAT_PCI_SUB_SYS_ID, 0, 0, 0},
>  	{ }
>  };
>  MODULE_DEVICE_TABLE (pci, ixxat_pci_tbl);
> 
> 
> _______________________________________________
> Xenomai-help mailing list
> Xenomai-help@domain.hid
> https://mail.gna.org/listinfo/xenomai-help
-- 
Philippe.

Re: [Xenomai-core] [Xenomai-help] IXXAT-PCI-CAN driver hijacks my pci board

[Wolfgang Grandegger]

Hi Philippe,

Philippe Gerum wrote:
> It looks like this patch is still pending an ack/nak. Wolfgang, any
> comment on this? TIA,

FIFO overrun, sorry.

> On Tue, 2009-05-05 at 21:04 +0200, Stefan Kisdaroczi wrote:
>> Hi,
>>
>> my pci board has the same pci-interface-chip as the IXXAT-PCI board.
>> The vendor and device id's are identical, but the subsys id is different.
>>
>> The documentation for my board says that it is essential to check all ID values,
>> because vendor and device id are standard values for the pci-interface-chip.
>>
>> dmesg output, there is no IXXAT-PCI-CAN board installed:
>>> RT-Socket-CAN 0.90.2 - (C) 2006 RT-Socket-CAN Development Team
>>> RTCAN SJA1000 driver initialized
>>> PCI: setting IRQ 12 as level-triggered
>>> IXXAT-PCI-CAN 0000:00:11.0: found PCI INT A -> IRQ 12
>>> IXXAT-PCI-CAN: Initializing device 10b5:9050:2503

OK, it finding a variant of the PLX9050, but it will not use the device  
because of the following lines after the above printout:

    if (sub_sys_id != IXXAT_PCI_SUB_SYS_ID)
             return -ENODEV;
                
But ...

>> The following patch fixed it for me (my own driver loads again).

... obviously it does  not probe again.

>> However, i could not check if it still detects the CAN board,
>> as i dont have one.




>>
>> Thanks
>> kisda
>>
>> --- xenomai-2.4.7.orig/ksrc/drivers/can/sja1000/rtcan_ixxat_pci.c
>> +++ xenomai-2.4.7/ksrc/drivers/can/sja1000/rtcan_ixxat_pci.c
>> @@ -73,7 +73,7 @@
>>  #define IXXAT_BASE_PORT_SIZE 0x0400
>>
>>  static struct pci_device_id ixxat_pci_tbl[] = {
>> -	{IXXAT_PCI_VENDOR_ID, IXXAT_PCI_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
>> +	{IXXAT_PCI_VENDOR_ID, IXXAT_PCI_DEVICE_ID, IXXAT_PCI_VENDOR_ID, IXXAT_PCI_SUB_SYS_ID, 0, 0, 0},
>>  	{ }
>>  };
>>  MODULE_DEVICE_TABLE (pci, ixxat_pci_tbl);

I don't have a IXXAT CAN card to check if the sub-vendor id is really
IXXAT_PCI_VENDOR_ID. Does 

  {IXXAT_PCI_VENDOR_ID, IXXAT_PCI_DEVICE_ID, PCI_ANY_ID, IXXAT_PCI_SUB_SYS_ID, 0, 0, 0},

work as well? A work-around would be to disable the IXXAT-PCI driver in the kernel config.

Wolfgang.

Re: [Xenomai-core] [Xenomai-help] IXXAT-PCI-CAN driver hijacks my pci board

[Wolfgang Grandegger]

Wolfgang Grandegger wrote:
> Hi Philippe,
> 
> Philippe Gerum wrote:
>> It looks like this patch is still pending an ack/nak. Wolfgang, any
>> comment on this? TIA,
> 
> FIFO overrun, sorry.
> 
>> On Tue, 2009-05-05 at 21:04 +0200, Stefan Kisdaroczi wrote:
>>> Hi,
>>>
>>> my pci board has the same pci-interface-chip as the IXXAT-PCI board.
>>> The vendor and device id's are identical, but the subsys id is different.
>>>
>>> The documentation for my board says that it is essential to check all ID values,
>>> because vendor and device id are standard values for the pci-interface-chip.
>>>
>>> dmesg output, there is no IXXAT-PCI-CAN board installed:
>>>> RT-Socket-CAN 0.90.2 - (C) 2006 RT-Socket-CAN Development Team
>>>> RTCAN SJA1000 driver initialized
>>>> PCI: setting IRQ 12 as level-triggered
>>>> IXXAT-PCI-CAN 0000:00:11.0: found PCI INT A -> IRQ 12
>>>> IXXAT-PCI-CAN: Initializing device 10b5:9050:2503
> 
> OK, it finding a variant of the PLX9050, but it will not use the device  
> because of the following lines after the above printout:
> 
>     if (sub_sys_id != IXXAT_PCI_SUB_SYS_ID)
>              return -ENODEV;
>                 
> But ...
> 
>>> The following patch fixed it for me (my own driver loads again).
> 
> ... obviously it does  not probe again.
> 
>>> However, i could not check if it still detects the CAN board,
>>> as i dont have one.
> 
> 
> 
> 
>>> Thanks
>>> kisda
>>>
>>> --- xenomai-2.4.7.orig/ksrc/drivers/can/sja1000/rtcan_ixxat_pci.c
>>> +++ xenomai-2.4.7/ksrc/drivers/can/sja1000/rtcan_ixxat_pci.c
>>> @@ -73,7 +73,7 @@
>>>  #define IXXAT_BASE_PORT_SIZE 0x0400
>>>
>>>  static struct pci_device_id ixxat_pci_tbl[] = {
>>> -	{IXXAT_PCI_VENDOR_ID, IXXAT_PCI_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
>>> +	{IXXAT_PCI_VENDOR_ID, IXXAT_PCI_DEVICE_ID, IXXAT_PCI_VENDOR_ID, IXXAT_PCI_SUB_SYS_ID, 0, 0, 0},
>>>  	{ }
>>>  };
>>>  MODULE_DEVICE_TABLE (pci, ixxat_pci_tbl);
> 
> I don't have a IXXAT CAN card to check if the sub-vendor id is really
> IXXAT_PCI_VENDOR_ID. Does 
> 
>   {IXXAT_PCI_VENDOR_ID, IXXAT_PCI_DEVICE_ID, PCI_ANY_ID, IXXAT_PCI_SUB_SYS_ID, 0, 0, 0},
> 
> work as well? A work-around would be to disable the IXXAT-PCI driver in the kernel config.

I just found a lspci output for an IXXAT card and Stefan's patch should
 work fine. Are you going to apply it or should I take care?

Thanks,

Wolfgang.

Re: [Xenomai-core] [Xenomai-help] IXXAT-PCI-CAN driver hijacks my pci board

[Philippe Gerum]

On Wed, 2009-05-20 at 12:36 +0200, Wolfgang Grandegger wrote:
> Wolfgang Grandegger wrote:
> > Hi Philippe,
> > 
> > Philippe Gerum wrote:
> >> It looks like this patch is still pending an ack/nak. Wolfgang, any
> >> comment on this? TIA,
> > 
> > FIFO overrun, sorry.
> > 
> >> On Tue, 2009-05-05 at 21:04 +0200, Stefan Kisdaroczi wrote:
> >>> Hi,
> >>>
> >>> my pci board has the same pci-interface-chip as the IXXAT-PCI board.
> >>> The vendor and device id's are identical, but the subsys id is different.
> >>>
> >>> The documentation for my board says that it is essential to check all ID values,
> >>> because vendor and device id are standard values for the pci-interface-chip.
> >>>
> >>> dmesg output, there is no IXXAT-PCI-CAN board installed:
> >>>> RT-Socket-CAN 0.90.2 - (C) 2006 RT-Socket-CAN Development Team
> >>>> RTCAN SJA1000 driver initialized
> >>>> PCI: setting IRQ 12 as level-triggered
> >>>> IXXAT-PCI-CAN 0000:00:11.0: found PCI INT A -> IRQ 12
> >>>> IXXAT-PCI-CAN: Initializing device 10b5:9050:2503
> > 
> > OK, it finding a variant of the PLX9050, but it will not use the device  
> > because of the following lines after the above printout:
> > 
> >     if (sub_sys_id != IXXAT_PCI_SUB_SYS_ID)
> >              return -ENODEV;
> >                 
> > But ...
> > 
> >>> The following patch fixed it for me (my own driver loads again).
> > 
> > ... obviously it does  not probe again.
> > 
> >>> However, i could not check if it still detects the CAN board,
> >>> as i dont have one.
> > 
> > 
> > 
> > 
> >>> Thanks
> >>> kisda
> >>>
> >>> --- xenomai-2.4.7.orig/ksrc/drivers/can/sja1000/rtcan_ixxat_pci.c
> >>> +++ xenomai-2.4.7/ksrc/drivers/can/sja1000/rtcan_ixxat_pci.c
> >>> @@ -73,7 +73,7 @@
> >>>  #define IXXAT_BASE_PORT_SIZE 0x0400
> >>>
> >>>  static struct pci_device_id ixxat_pci_tbl[] = {
> >>> -	{IXXAT_PCI_VENDOR_ID, IXXAT_PCI_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
> >>> +	{IXXAT_PCI_VENDOR_ID, IXXAT_PCI_DEVICE_ID, IXXAT_PCI_VENDOR_ID, IXXAT_PCI_SUB_SYS_ID, 0, 0, 0},
> >>>  	{ }
> >>>  };
> >>>  MODULE_DEVICE_TABLE (pci, ixxat_pci_tbl);
> > 
> > I don't have a IXXAT CAN card to check if the sub-vendor id is really
> > IXXAT_PCI_VENDOR_ID. Does 
> > 
> >   {IXXAT_PCI_VENDOR_ID, IXXAT_PCI_DEVICE_ID, PCI_ANY_ID, IXXAT_PCI_SUB_SYS_ID, 0, 0, 0},
> > 
> > work as well? A work-around would be to disable the IXXAT-PCI driver in the kernel config.
> 
> I just found a lspci output for an IXXAT card and Stefan's patch should
>  work fine. Are you going to apply it or should I take care?
> 

It's in my queue already, so I can commit directly. Thanks,

> Thanks,
> 
> Wolfgang.
-- 
Philippe.

Re: [Xenomai-help] IXXAT-PCI-CAN driver hijacks my pci board

[Stefan Kisdaroczi]

[-- Attachment #1: Type: text/plain, Size: 980 bytes --]

Hi Wolfgang,

Wolfgang Grandegger schrieb:
> [...]
>>> dmesg output, there is no IXXAT-PCI-CAN board installed:
>>>> RT-Socket-CAN 0.90.2 - (C) 2006 RT-Socket-CAN Development Team
>>>> RTCAN SJA1000 driver initialized
>>>> PCI: setting IRQ 12 as level-triggered
>>>> IXXAT-PCI-CAN 0000:00:11.0: found PCI INT A -> IRQ 12
>>>> IXXAT-PCI-CAN: Initializing device 10b5:9050:2503
> 
> OK, it finding a variant of the PLX9050, but it will not use the device  
> because of the following lines after the above printout:
> 
>     if (sub_sys_id != IXXAT_PCI_SUB_SYS_ID)
>              return -ENODEV;
>                 
> But ...
> 
>>> The following patch fixed it for me (my own driver loads again).
> 
> ... obviously it does  not probe again.

it probes again, but pci_request_regions() failed in my driver.

In the -ENODEV case, the function pci_release_regions() is not
called in the ixxat driver, so access is blocked for other drivers.

Stefan




[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]

Re: [Xenomai-help] IXXAT-PCI-CAN driver hijacks my pci board

[Wolfgang Grandegger]

Stefan Kisdaroczi wrote:
> Hi Wolfgang,
> 
> Wolfgang Grandegger schrieb:
>> [...]
>>>> dmesg output, there is no IXXAT-PCI-CAN board installed:
>>>>> RT-Socket-CAN 0.90.2 - (C) 2006 RT-Socket-CAN Development Team
>>>>> RTCAN SJA1000 driver initialized
>>>>> PCI: setting IRQ 12 as level-triggered
>>>>> IXXAT-PCI-CAN 0000:00:11.0: found PCI INT A -> IRQ 12
>>>>> IXXAT-PCI-CAN: Initializing device 10b5:9050:2503
>> OK, it finding a variant of the PLX9050, but it will not use the device  
>> because of the following lines after the above printout:
>>
>>     if (sub_sys_id != IXXAT_PCI_SUB_SYS_ID)
>>              return -ENODEV;
>>                 
>> But ...
>>
>>>> The following patch fixed it for me (my own driver loads again).
>> ... obviously it does  not probe again.
> 
> it probes again, but pci_request_regions() failed in my driver.
> 
> In the -ENODEV case, the function pci_release_regions() is not
> called in the ixxat driver, so access is blocked for other drivers.

That's a bug. Will fix.

Thanks,

Wolfgang.

Re: [Xenomai-help] IXXAT-PCI-CAN driver hijacks my pci board

[Sebastian Smolorz]

Hi Wolfgang,

Wolfgang Grandegger wrote:
> Stefan Kisdaroczi wrote:
> > Hi Wolfgang,
> >
> > Wolfgang Grandegger schrieb:
> >> [...]
> >>
> >>>> dmesg output, there is no IXXAT-PCI-CAN board installed:
> >>>>> RT-Socket-CAN 0.90.2 - (C) 2006 RT-Socket-CAN Development Team
> >>>>> RTCAN SJA1000 driver initialized
> >>>>> PCI: setting IRQ 12 as level-triggered
> >>>>> IXXAT-PCI-CAN 0000:00:11.0: found PCI INT A -> IRQ 12
> >>>>> IXXAT-PCI-CAN: Initializing device 10b5:9050:2503
> >>
> >> OK, it finding a variant of the PLX9050, but it will not use the device
> >> because of the following lines after the above printout:
> >>
> >>     if (sub_sys_id != IXXAT_PCI_SUB_SYS_ID)
> >>              return -ENODEV;
> >>
> >> But ...
> >>
> >>>> The following patch fixed it for me (my own driver loads again).
> >>
> >> ... obviously it does  not probe again.
> >
> > it probes again, but pci_request_regions() failed in my driver.
> >
> > In the -ENODEV case, the function pci_release_regions() is not
> > called in the ixxat driver, so access is blocked for other drivers.
>
> That's a bug. Will fix.

please see:

https://mail.gna.org/public/xenomai-core/2009-03/msg00055.html

I sent a patch for exactly this issue on March 10.

-- 
Sebastian

Re: [Xenomai-help] IXXAT-PCI-CAN driver hijacks my pci board

[Wolfgang Grandegger]

Sebastian Smolorz wrote:
> Hi Wolfgang,
> 
> Wolfgang Grandegger wrote:
>> Stefan Kisdaroczi wrote:
>>> Hi Wolfgang,
>>>
>>> Wolfgang Grandegger schrieb:
>>>> [...]
>>>>
>>>>>> dmesg output, there is no IXXAT-PCI-CAN board installed:
>>>>>>> RT-Socket-CAN 0.90.2 - (C) 2006 RT-Socket-CAN Development Team
>>>>>>> RTCAN SJA1000 driver initialized
>>>>>>> PCI: setting IRQ 12 as level-triggered
>>>>>>> IXXAT-PCI-CAN 0000:00:11.0: found PCI INT A -> IRQ 12
>>>>>>> IXXAT-PCI-CAN: Initializing device 10b5:9050:2503
>>>> OK, it finding a variant of the PLX9050, but it will not use the device
>>>> because of the following lines after the above printout:
>>>>
>>>>     if (sub_sys_id != IXXAT_PCI_SUB_SYS_ID)
>>>>              return -ENODEV;
>>>>
>>>> But ...
>>>>
>>>>>> The following patch fixed it for me (my own driver loads again).
>>>> ... obviously it does  not probe again.
>>> it probes again, but pci_request_regions() failed in my driver.
>>>
>>> In the -ENODEV case, the function pci_release_regions() is not
>>> called in the ixxat driver, so access is blocked for other drivers.
>> That's a bug. Will fix.
> 
> please see:
> 
> https://mail.gna.org/public/xenomai-core/2009-03/msg00055.html
> 
> I sent a patch for exactly this issue on March 10.

Obviously I missed that one as well, sorry. Will send a proper patch
later today or tomorrow. Sebastian, does that mean that you have an
IXXAT PCI card available for testing?

Wolfgang.

Re: [Xenomai-help] IXXAT-PCI-CAN driver hijacks my pci board

[Sebastian Smolorz]

Wolfgang Grandegger wrote:
> Obviously I missed that one as well, sorry. Will send a proper patch
> later today or tomorrow. Sebastian, does that mean that you have an
> IXXAT PCI card available for testing?

No, unfortunately not. But I was playing with the source code for that card 
while trying to get an ESD card to work with Xenomai. BTW that reminds me of 
sending a patch for that card to the ML ... maybe next week.

-- 
Sebastian

Re: [Xenomai-core] [Xenomai-help] IXXAT-PCI-CAN driver hijacks my pci board

[Wolfgang Grandegger]

Hi Philipe,

Philippe Gerum wrote:
> On Wed, 2009-05-20 at 12:36 +0200, Wolfgang Grandegger wrote:
>> Wolfgang Grandegger wrote:
>>> Hi Philippe,
>>>
>>> Philippe Gerum wrote:
>>>> It looks like this patch is still pending an ack/nak. Wolfgang, any
>>>> comment on this? TIA,
>>> FIFO overrun, sorry.
>>>
>>>> On Tue, 2009-05-05 at 21:04 +0200, Stefan Kisdaroczi wrote:
>>>>> Hi,
>>>>>
>>>>> my pci board has the same pci-interface-chip as the IXXAT-PCI board.
>>>>> The vendor and device id's are identical, but the subsys id is different.
>>>>>
>>>>> The documentation for my board says that it is essential to check all ID values,
>>>>> because vendor and device id are standard values for the pci-interface-chip.
>>>>>
>>>>> dmesg output, there is no IXXAT-PCI-CAN board installed:
>>>>>> RT-Socket-CAN 0.90.2 - (C) 2006 RT-Socket-CAN Development Team
>>>>>> RTCAN SJA1000 driver initialized
>>>>>> PCI: setting IRQ 12 as level-triggered
>>>>>> IXXAT-PCI-CAN 0000:00:11.0: found PCI INT A -> IRQ 12
>>>>>> IXXAT-PCI-CAN: Initializing device 10b5:9050:2503
>>> OK, it finding a variant of the PLX9050, but it will not use the device  
>>> because of the following lines after the above printout:
>>>
>>>     if (sub_sys_id != IXXAT_PCI_SUB_SYS_ID)
>>>              return -ENODEV;
>>>                 
>>> But ...
>>>
>>>>> The following patch fixed it for me (my own driver loads again).
>>> ... obviously it does  not probe again.
>>>
>>>>> However, i could not check if it still detects the CAN board,
>>>>> as i dont have one.
>>>
>>>
>>>
>>>>> Thanks
>>>>> kisda
>>>>>
>>>>> --- xenomai-2.4.7.orig/ksrc/drivers/can/sja1000/rtcan_ixxat_pci.c
>>>>> +++ xenomai-2.4.7/ksrc/drivers/can/sja1000/rtcan_ixxat_pci.c
>>>>> @@ -73,7 +73,7 @@
>>>>>  #define IXXAT_BASE_PORT_SIZE 0x0400
>>>>>
>>>>>  static struct pci_device_id ixxat_pci_tbl[] = {
>>>>> -	{IXXAT_PCI_VENDOR_ID, IXXAT_PCI_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
>>>>> +	{IXXAT_PCI_VENDOR_ID, IXXAT_PCI_DEVICE_ID, IXXAT_PCI_VENDOR_ID, IXXAT_PCI_SUB_SYS_ID, 0, 0, 0},
>>>>>  	{ }
>>>>>  };
>>>>>  MODULE_DEVICE_TABLE (pci, ixxat_pci_tbl);
>>> I don't have a IXXAT CAN card to check if the sub-vendor id is really
>>> IXXAT_PCI_VENDOR_ID. Does 
>>>
>>>   {IXXAT_PCI_VENDOR_ID, IXXAT_PCI_DEVICE_ID, PCI_ANY_ID, IXXAT_PCI_SUB_SYS_ID, 0, 0, 0},
>>>
>>> work as well? A work-around would be to disable the IXXAT-PCI driver in the kernel config.
>> I just found a lspci output for an IXXAT card and Stefan's patch should
>>  work fine. Are you going to apply it or should I take care?
>>
> 
> It's in my queue already, so I can commit directly. Thanks,

Two patches for the IXXAT-PCI and MSCAN will follow. Sorry for delay.

Wolfgang.