Re: [Qemu-devel] [PATCH] Change virtio-console to PCI_CLASS_SERIAL_OTHER

[Avi Kivity <avi@redhat.com>]

Mark McLoughlin wrote:
> From: Adam Jackson <ajax@redhat.com>
>
> We're using PCI_CLASS_DISPLAY_OTHER now, but qemu-kvm.git is using
> PCI_CLASS_OTHERS because:
>
>   "As a PCI_CLASS_DISPLAY_OTHER, it reduces primary display somehow on
>    Windows XP (possibly Windows disables acceleration since it fails
>    to find a driver)."
>   

That's really unnecessary now, since virtio-console is not enabled by 
default.

> While this is valid, many versions of X will get confused by it.
> Class major number of 0 gets treated as a possibly prehistoric VGA
> device, and then the autoconfig logic gets confused trying to figure
> out whether the virtio console or the pv vga device are the real VGA.
>
> We should really set a proper class ID. 0x0780 (serial / other) seems
> most appropriate. This shouldn't require any kernel changes, the
> modalias for virtio looks like:
>   

Yes, serial is a much better fit.

-- 
error compiling committee.c: too many arguments to function