All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: Mark McLoughlin <markmc@redhat.com>
Cc: Dor Laor <dlaor@redhat.com>,
	ajax@redhat.com, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Change virtio-console to PCI_CLASS_SERIAL_OTHER
Date: Wed, 27 May 2009 17:37:52 -0500	[thread overview]
Message-ID: <4A1DC0C0.2060200@us.ibm.com> (raw)
In-Reply-To: <1243446153.4852.9.camel@blaa>

Mark McLoughlin wrote:
> On Wed, 2009-05-27 at 09:21 -0500, Anthony Liguori wrote:
>
>   
>> We need a mechanism to toggle this for both this and virtio-blk.  The 
>> reason a toggle is needed is so that 0.11 can create the same device 
>> model as 0.10.
>>     
>
> Okay, so the scenario is:
>
>   - 0.10 guest running on source machine
>
>   - migrate to dest machine running 0.11
>
>   - the device model cannot change or the guest OS will get confused
>   

Correct, but in this case, the problem is when you shutdown and start up 
the VM again.  In the process, it may trigger something like a driver 
reinstallation or worse, reactivation.  It's necessary to be able to 
prevent this by creating exactly the same device model that was 
previously created.

This is can't really be a hard rule yet without the machine config, but 
we should do our best when we can.

> How about running qemu on the dest machine with -model-version=0.10 ?
>   

Linear versioning is a bit too fickle esp due to distro backporting.

> Nasty thing about it is that the distributions couldn't cherry-pick
> changes like this because they'd deviate from the device model contract
> for a given upstream version.
>
> Could we not put this stuff in savevm and change the device model
> post-init?
>   

It's shutdown/restart that's the problem.  Windows uses a lot of 
different information to calculate whether activation is required again 
and even small changes can end up pushing things over the edge.

Regards,

Anthony Liguori

> Cheers,
> Mark.
>
>   

  reply	other threads:[~2009-05-27 22:38 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-22 17:14 [Qemu-devel] [PATCH] Change virtio-console to PCI_CLASS_SERIAL_OTHER Mark McLoughlin
2009-05-24  9:11 ` Avi Kivity
2009-05-27 14:21 ` Anthony Liguori
2009-05-27 17:42   ` Mark McLoughlin
2009-05-27 22:37     ` Anthony Liguori [this message]
2009-05-28  9:33       ` Mark McLoughlin
2009-05-28  9:44         ` Anthony Liguori
2009-05-28 12:53     ` Paul Brook
2009-05-28 12:56       ` Anthony Liguori
2009-05-28 13:22         ` Paul Brook
2009-05-28 13:29           ` Anthony Liguori
2009-05-28 21:45             ` Dor Laor
2009-05-29  9:43               ` Mark McLoughlin
2009-05-29  9:50                 ` Anthony Liguori
2009-05-31 14:32                   ` Avi Kivity
2009-05-29  9:55                 ` Anthony Liguori
2009-05-29 10:09                 ` Mark McLoughlin
2009-05-31 14:47                   ` Dor Laor
2009-06-02  8:49                     ` Mark McLoughlin
2009-06-02 13:08                       ` Dor Laor
2009-06-02 13:39                         ` Mark McLoughlin
2009-05-31 14:35                 ` Dor Laor
2009-06-02  8:49                   ` Mark McLoughlin
2009-05-28 13:04       ` Daniel P. Berrange
2009-05-28 13:19         ` Anthony Liguori
2009-05-31 18:48           ` Jamie Lokier
2009-05-28 13:20         ` Paul Brook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A1DC0C0.2060200@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=ajax@redhat.com \
    --cc=dlaor@redhat.com \
    --cc=markmc@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.