From: Avi Kivity <avi@redhat.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [PATCH] qemu-kvm: Flush icache after dma operations for ia64
Date: Mon, 01 Jun 2009 07:45:57 +0000 [thread overview]
Message-ID: <4A238735.1050006@redhat.com> (raw)
In-Reply-To: <706158FABBBA044BAD4FE898A02E4BC236B1935F@pdsmsx503.ccr.corp.intel.com>
Zhang, Xiantao wrote:
> Avi Kivity wrote:
>
>> Jes Sorensen wrote:
>>
>>> Ok,
>>>
>>> Trying once more. After spending a couple of hours trying to follow
>>> the QEMU dma codeflow, I have convinced myself Avi is right and those
>>> two functions don't need to do the flushing as they all end up
>>> calling dma_bdrv_cb() which calls dma_brdv_unmap(). I have added a
>>> couple comments to the code, which will hopefully save the next
>>> person the 'pleasure' of trying to figure out this too.
>>>
>>>
>> It looks right to me. Xiantao?
>>
>
> Fine to me. But seems the change in qemu_iovec_from_buffer is lost in this patch or that change is also not unnecessary ?
>
I think the fixed unmap handles that case. Can you test to make sure?
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: "Zhang, Xiantao" <xiantao.zhang@intel.com>
Cc: Jes Sorensen <jes@sgi.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"kvm-ia64@vger.kernel.org" <kvm-ia64@vger.kernel.org>,
Hollis Blanchard <hollisb@us.ibm.com>
Subject: Re: [PATCH] qemu-kvm: Flush icache after dma operations for ia64
Date: Mon, 01 Jun 2009 10:45:57 +0300 [thread overview]
Message-ID: <4A238735.1050006@redhat.com> (raw)
In-Reply-To: <706158FABBBA044BAD4FE898A02E4BC201BD66196B@pdsmsx503.ccr.corp.intel.com>
Zhang, Xiantao wrote:
> Avi Kivity wrote:
>
>> Jes Sorensen wrote:
>>
>>> Ok,
>>>
>>> Trying once more. After spending a couple of hours trying to follow
>>> the QEMU dma codeflow, I have convinced myself Avi is right and those
>>> two functions don't need to do the flushing as they all end up
>>> calling dma_bdrv_cb() which calls dma_brdv_unmap(). I have added a
>>> couple comments to the code, which will hopefully save the next
>>> person the 'pleasure' of trying to figure out this too.
>>>
>>>
>> It looks right to me. Xiantao?
>>
>
> Fine to me. But seems the change in qemu_iovec_from_buffer is lost in this patch or that change is also not unnecessary ?
>
I think the fixed unmap handles that case. Can you test to make sure?
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2009-06-01 7:45 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 10:20 [PATCH] qemu-kvm: Flush icache after dma operations for ia64 Zhang, Xiantao
2009-05-11 10:20 ` Zhang, Xiantao
2009-05-11 11:11 ` Avi Kivity
2009-05-11 11:11 ` Avi Kivity
2009-05-25 10:55 ` Jes Sorensen
2009-05-25 10:55 ` Jes Sorensen
2009-05-25 10:56 ` Jes Sorensen
2009-05-25 10:56 ` Jes Sorensen
2009-05-25 11:25 ` Avi Kivity
2009-05-25 11:25 ` Avi Kivity
2009-05-25 13:12 ` Jes Sorensen
2009-05-25 13:12 ` Jes Sorensen
2009-05-26 12:30 ` Avi Kivity
2009-05-26 12:30 ` Avi Kivity
2009-06-01 5:40 ` Zhang, Xiantao
2009-06-01 5:40 ` Zhang, Xiantao
2009-06-01 7:45 ` Avi Kivity [this message]
2009-06-01 7:45 ` Avi Kivity
2009-06-02 10:56 ` Jes Sorensen
2009-06-02 10:56 ` Jes Sorensen
2009-06-02 15:20 ` Zhang, Xiantao
2009-06-02 15:20 ` Zhang, Xiantao
2009-06-04 13:09 ` Jes Sorensen
2009-06-04 13:09 ` Jes Sorensen
2009-06-05 1:38 ` Zhang, Xiantao
2009-06-05 1:38 ` Zhang, Xiantao
2009-06-05 11:13 ` Jes Sorensen
2009-06-05 11:13 ` Jes Sorensen
2009-06-07 6:28 ` Avi Kivity
2009-06-07 6:28 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A238735.1050006@redhat.com \
--to=avi@redhat.com \
--cc=kvm-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.