All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jes Sorensen <jes@sgi.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [PATCH] qemu-kvm: Flush icache after dma operations for ia64
Date: Tue, 02 Jun 2009 10:56:54 +0000	[thread overview]
Message-ID: <4A250576.1030702@sgi.com> (raw)
In-Reply-To: <706158FABBBA044BAD4FE898A02E4BC236B1935F@pdsmsx503.ccr.corp.intel.com>

Avi Kivity wrote:
> Zhang, Xiantao wrote:
>> Fine to me.  But seems the change in qemu_iovec_from_buffer is lost in 
>> this patch or that change is also not unnecessary ?
> 
> I think the fixed unmap handles that case.  Can you test to make sure?
> 

Avi and I went through the code and verified that it was all covered by
the unmap case. It was pretty messy to come to the conclusion, which is
why I tried to document it in the code and the patch description.

Cheers,
Jes

WARNING: multiple messages have this Message-ID (diff)
From: Jes Sorensen <jes@sgi.com>
To: Avi Kivity <avi@redhat.com>
Cc: "Zhang, Xiantao" <xiantao.zhang@intel.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"kvm-ia64@vger.kernel.org" <kvm-ia64@vger.kernel.org>,
	Hollis Blanchard <hollisb@us.ibm.com>
Subject: Re: [PATCH] qemu-kvm: Flush icache after dma operations for ia64
Date: Tue, 02 Jun 2009 12:56:54 +0200	[thread overview]
Message-ID: <4A250576.1030702@sgi.com> (raw)
In-Reply-To: <4A238735.1050006@redhat.com>

Avi Kivity wrote:
> Zhang, Xiantao wrote:
>> Fine to me.  But seems the change in qemu_iovec_from_buffer is lost in 
>> this patch or that change is also not unnecessary ?
> 
> I think the fixed unmap handles that case.  Can you test to make sure?
> 

Avi and I went through the code and verified that it was all covered by
the unmap case. It was pretty messy to come to the conclusion, which is
why I tried to document it in the code and the patch description.

Cheers,
Jes

  parent reply	other threads:[~2009-06-02 10:56 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-11 10:20 [PATCH] qemu-kvm: Flush icache after dma operations for ia64 Zhang, Xiantao
2009-05-11 10:20 ` Zhang, Xiantao
2009-05-11 11:11 ` Avi Kivity
2009-05-11 11:11   ` Avi Kivity
2009-05-25 10:55 ` Jes Sorensen
2009-05-25 10:55   ` Jes Sorensen
2009-05-25 10:56 ` Jes Sorensen
2009-05-25 10:56   ` Jes Sorensen
2009-05-25 11:25 ` Avi Kivity
2009-05-25 11:25   ` Avi Kivity
2009-05-25 13:12 ` Jes Sorensen
2009-05-25 13:12   ` Jes Sorensen
2009-05-26 12:30 ` Avi Kivity
2009-05-26 12:30   ` Avi Kivity
2009-06-01  5:40 ` Zhang, Xiantao
2009-06-01  5:40   ` Zhang, Xiantao
2009-06-01  7:45 ` Avi Kivity
2009-06-01  7:45   ` Avi Kivity
2009-06-02 10:56 ` Jes Sorensen [this message]
2009-06-02 10:56   ` Jes Sorensen
2009-06-02 15:20 ` Zhang, Xiantao
2009-06-02 15:20   ` Zhang, Xiantao
2009-06-04 13:09 ` Jes Sorensen
2009-06-04 13:09   ` Jes Sorensen
2009-06-05  1:38 ` Zhang, Xiantao
2009-06-05  1:38   ` Zhang, Xiantao
2009-06-05 11:13 ` Jes Sorensen
2009-06-05 11:13   ` Jes Sorensen
2009-06-07  6:28 ` Avi Kivity
2009-06-07  6:28   ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A250576.1030702@sgi.com \
    --to=jes@sgi.com \
    --cc=kvm-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.