All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	kvm-devel <kvm@vger.kernel.org>
Subject: Live migration broken when under heavy IO
Date: Mon, 15 Jun 2009 15:33:41 -0500	[thread overview]
Message-ID: <4A36B025.2080602@us.ibm.com> (raw)

The basic issue is that:

migrate_fd_put_ready():    bdrv_flush_all();

Does:

block.c:

foreach block driver:
   drv->flush(bs);

Which in the case of raw, is just fsync(s->fd).

Any submitted request is not queued or flushed which will lead to the 
request being dropped after the live migration.

Is anyone working on fixing this?  Does anyone have a clever idea how to 
fix this without just waiting for all IO requests to complete?

---

Regards,

Anthony Liguori


WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <aliguori@us.ibm.com>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	kvm-devel <kvm@vger.kernel.org>
Subject: [Qemu-devel] Live migration broken when under heavy IO
Date: Mon, 15 Jun 2009 15:33:41 -0500	[thread overview]
Message-ID: <4A36B025.2080602@us.ibm.com> (raw)

The basic issue is that:

migrate_fd_put_ready():    bdrv_flush_all();

Does:

block.c:

foreach block driver:
   drv->flush(bs);

Which in the case of raw, is just fsync(s->fd).

Any submitted request is not queued or flushed which will lead to the 
request being dropped after the live migration.

Is anyone working on fixing this?  Does anyone have a clever idea how to 
fix this without just waiting for all IO requests to complete?

---

Regards,

Anthony Liguori

             reply	other threads:[~2009-06-15 20:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-15 20:33 Anthony Liguori [this message]
2009-06-15 20:33 ` [Qemu-devel] Live migration broken when under heavy IO Anthony Liguori
2009-06-15 20:48 ` Glauber Costa
2009-06-16  9:10 ` Avi Kivity
2009-06-16  9:10   ` [Qemu-devel] " Avi Kivity
2009-06-16  9:13   ` Avi Kivity
2009-06-16  9:13     ` [Qemu-devel] " Avi Kivity
2009-06-16 12:50   ` Anthony Liguori
2009-06-16 12:50     ` [Qemu-devel] " Anthony Liguori
2009-06-16 12:54     ` Avi Kivity
2009-06-16 12:54       ` [Qemu-devel] " Avi Kivity
2009-06-16 12:57       ` Anthony Liguori
2009-06-16 12:57         ` [Qemu-devel] " Anthony Liguori
2009-06-16 13:12         ` Avi Kivity
2009-06-16 13:12           ` [Qemu-devel] " Avi Kivity
2009-06-16 18:19 ` Charles Duffy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A36B025.2080602@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.