All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: Avi Kivity <avi@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	kvm-devel <kvm@vger.kernel.org>
Subject: Re: Live migration broken when under heavy IO
Date: Tue, 16 Jun 2009 07:57:21 -0500	[thread overview]
Message-ID: <4A3796B1.8060003@us.ibm.com> (raw)
In-Reply-To: <4A3795F4.9080507@redhat.com>

Avi Kivity wrote:
> Yes, that's even better (though without linux-aio, it's equivalent).

Not absolutely equivalent.  There many be queued requests that haven't 
yet been dispatched to the thread pool, but yeah, I understand what you 
mean.

>>
>> The tricky bit is that this has to happen at the device layer because 
>> the opaques cannot be saved in a meaningful way.
>>
>
> Do you mean the device has to record all cancelled requests and replay 
> them?  I think we can do it at the block layer (though we have to 
> avoid it for nested requests).

In order to complete the requests, you have to call a callback and pass 
an opaque with the results.  The callback/opaque cannot be saved in the 
block layer in a meaningful way.

-- 
Regards,

Anthony Liguori


WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <aliguori@us.ibm.com>
To: Avi Kivity <avi@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	kvm-devel <kvm@vger.kernel.org>
Subject: [Qemu-devel] Re: Live migration broken when under heavy IO
Date: Tue, 16 Jun 2009 07:57:21 -0500	[thread overview]
Message-ID: <4A3796B1.8060003@us.ibm.com> (raw)
In-Reply-To: <4A3795F4.9080507@redhat.com>

Avi Kivity wrote:
> Yes, that's even better (though without linux-aio, it's equivalent).

Not absolutely equivalent.  There many be queued requests that haven't 
yet been dispatched to the thread pool, but yeah, I understand what you 
mean.

>>
>> The tricky bit is that this has to happen at the device layer because 
>> the opaques cannot be saved in a meaningful way.
>>
>
> Do you mean the device has to record all cancelled requests and replay 
> them?  I think we can do it at the block layer (though we have to 
> avoid it for nested requests).

In order to complete the requests, you have to call a callback and pass 
an opaque with the results.  The callback/opaque cannot be saved in the 
block layer in a meaningful way.

-- 
Regards,

Anthony Liguori

  reply	other threads:[~2009-06-16 12:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-15 20:33 Live migration broken when under heavy IO Anthony Liguori
2009-06-15 20:33 ` [Qemu-devel] " Anthony Liguori
2009-06-15 20:48 ` Glauber Costa
2009-06-16  9:10 ` Avi Kivity
2009-06-16  9:10   ` [Qemu-devel] " Avi Kivity
2009-06-16  9:13   ` Avi Kivity
2009-06-16  9:13     ` [Qemu-devel] " Avi Kivity
2009-06-16 12:50   ` Anthony Liguori
2009-06-16 12:50     ` [Qemu-devel] " Anthony Liguori
2009-06-16 12:54     ` Avi Kivity
2009-06-16 12:54       ` [Qemu-devel] " Avi Kivity
2009-06-16 12:57       ` Anthony Liguori [this message]
2009-06-16 12:57         ` Anthony Liguori
2009-06-16 13:12         ` Avi Kivity
2009-06-16 13:12           ` [Qemu-devel] " Avi Kivity
2009-06-16 18:19 ` Charles Duffy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A3796B1.8060003@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.