[Qemu-devel] Re: [Qemu-commits] [COMMIT 537fe2d] Make sure to use SDL_CFLAGS everywhere we includeSDL headers

[Qemu-devel] Re: [Qemu-commits] [COMMIT 537fe2d] Make sure to use SDL_CFLAGS everywhere we includeSDL headers

[Filip Navara]

[-- Attachment #1: Type: text/plain, Size: 1346 bytes --]

On Tue, Jun 16, 2009 at 10:33 PM, Anthony Liguori <aliguori@us.ibm.com>wrote:

> From: Anthony Liguori <aliguori@us.ibm.com>
>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>
> diff --git a/Makefile b/Makefile
> index 3177616..209b21f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -208,7 +208,7 @@ keymaps.o: keymaps.c keymaps.h
>
>  sdl.o: sdl.c keymaps.h sdl_keysym.h
>
> -sdl.o audio/sdlaudio.o: CFLAGS += $(SDL_CFLAGS)
> +sdl.o audio/sdlaudio.o baum.o: CFLAGS += $(SDL_CFLAGS)
>
>  acl.o: acl.h acl.c
>
> diff --git a/Makefile.target b/Makefile.target
> index 27de4b9..0159bf7 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -730,6 +730,8 @@ LDFLAGS+=-p
>  main.o: CFLAGS+=-p
>  endif
>
> +vl.o: CFLAGS+=$(SDL_CFLAGS)
> +
>  vl.o: qemu-options.h
>
>  monitor.o: qemu-monitor.h
>
>
>
Please note that this commits breaks the Win32 port in several ways. First
problem is the SDL_main definition as already pointed out on the mailing
list. The other problem is that default mingw32 builds of SDL redirect
stderr/stdout through the SDL_main hack (and in incorrect way too, but I
will leave that for the SDL folks), so it's nearly impossible to get console
output - ie. error messages or help.

The only workaround I know is to build SDL with the
--disable-stdio-redirect, which is a bit annoying.

Best regards,
Filip Navara

[-- Attachment #2: Type: text/html, Size: 1846 bytes --]

[Qemu-devel] Re: [Qemu-commits] [COMMIT 537fe2d] Make sure to use SDL_CFLAGS everywhere we includeSDL headers

[Filip Navara]

On Sun, Jun 21, 2009 at 12:02 PM, Filip Navara <filip.navara@gmail.com> wrote:
>
> On Tue, Jun 16, 2009 at 10:33 PM, Anthony Liguori <aliguori@us.ibm.com> wrote:
>>
>> From: Anthony Liguori <aliguori@us.ibm.com>
>>
>> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>>
>> diff --git a/Makefile b/Makefile
>> index 3177616..209b21f 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -208,7 +208,7 @@ keymaps.o: keymaps.c keymaps.h
>>
>>  sdl.o: sdl.c keymaps.h sdl_keysym.h
>>
>> -sdl.o audio/sdlaudio.o: CFLAGS += $(SDL_CFLAGS)
>> +sdl.o audio/sdlaudio.o baum.o: CFLAGS += $(SDL_CFLAGS)
>>
>>  acl.o: acl.h acl.c
>>
>> diff --git a/Makefile.target b/Makefile.target
>> index 27de4b9..0159bf7 100644
>> --- a/Makefile.target
>> +++ b/Makefile.target
>> @@ -730,6 +730,8 @@ LDFLAGS+=-p
>>  main.o: CFLAGS+=-p
>>  endif
>>
>> +vl.o: CFLAGS+=$(SDL_CFLAGS)
>> +
>>  vl.o: qemu-options.h
>>
>>  monitor.o: qemu-monitor.h
>>
>>
>
> Please note that this commits breaks the Win32 port in several ways. First problem is the SDL_main definition as already pointed out on the mailing list. The other problem is that default mingw32 builds of SDL redirect stderr/stdout through the SDL_main hack (and in incorrect way too, but I will leave that for the SDL folks), so it's nearly impossible to get console output - ie. error messages or help.
> The only workaround I know is to build SDL with the --disable-stdio-redirect, which is a bit annoying.

Or rather "./configure --enable-stdio-redirect=no".

F.

Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT 537fe2d] Make sure to use SDL_CFLAGS everywhere we includeSDL headers

[Anthony Liguori]

Filip Navara wrote:
>
> Please note that this commits breaks the Win32 port in several ways. 
> First problem is the SDL_main definition as already pointed out on the 
> mailing list. The other problem is that default mingw32 builds of SDL 
> redirect stderr/stdout through the SDL_main hack (and in incorrect way 
> too, but I will leave that for the SDL folks), so it's nearly 
> impossible to getconsole output - ie. error messages or help.

I have a fix in queue, but...

For mingw32 we don't want to use SDL_main?

But we want to use it for OS X?

Regards,

Anthony Liguori

Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT 537fe2d] Make sure to use SDL_CFLAGS everywhere we includeSDL headers

[Filip Navara]

On Mon, Jun 22, 2009 at 1:45 AM, Anthony Liguori<anthony@codemonkey.ws> wrote:
> Filip Navara wrote:
>>
>> Please note that this commits breaks the Win32 port in several ways. First
>> problem is the SDL_main definition as already pointed out on the mailing
>> list. The other problem is that default mingw32 builds of SDL redirect
>> stderr/stdout through the SDL_main hack (and in incorrect way too, but I
>> will leave that for the SDL folks), so it's nearly impossible to getconsole
>> output - ie. error messages or help.
>
> I have a fix in queue, but...
>
> For mingw32 we don't want to use SDL_main?

I guess a cleaner approach would be to use SDL_main to keep the code
simple and portable. I've seen some crashes in the the past that could
be related to the DirectX initialization in the SDL's main wrapper. On
the other hand it requires a custom SDL build (only libSDLmain.a, not
the sdl.dll) and that should be documented at least.

> But we want to use it for OS X?

For OS X it's absolutely necessary, it initializes the QuickDraw libraries.

Best regards,
Filip Navara

Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT 537fe2d] Make sure to use SDL_CFLAGS everywhere we includeSDL headers

[Filip Navara]

On Mon, Jun 22, 2009 at 7:02 AM, Filip Navara<filip.navara@gmail.com> wrote:
> On Mon, Jun 22, 2009 at 1:45 AM, Anthony Liguori<anthony@codemonkey.ws> wrote:
>> Filip Navara wrote:
>>>
>>> Please note that this commits breaks the Win32 port in several ways. First
>>> problem is the SDL_main definition as already pointed out on the mailing
>>> list. The other problem is that default mingw32 builds of SDL redirect
>>> stderr/stdout through the SDL_main hack (and in incorrect way too, but I
>>> will leave that for the SDL folks), so it's nearly impossible to getconsole
>>> output - ie. error messages or help.
>>
>> I have a fix in queue, but...
>>
>> For mingw32 we don't want to use SDL_main?
>
> I guess a cleaner approach would be to use SDL_main to keep the code
> simple and portable. I've seen some crashes in the the past that could
> be related to the DirectX initialization in the SDL's main wrapper. On
> the other hand it requires a custom SDL build (only libSDLmain.a, not
> the sdl.dll) and that should be documented at least.
>
>> But we want to use it for OS X?
>
> For OS X it's absolutely necessary, it initializes the QuickDraw libraries.

I've checked the latest SDL source code in their svn since the
official SDL release (1.2.13) is two years old already. SDL_main for
OS X has been removed completely and on Win32 it no longer does any of
the nasty stuff it used to do and is unnecessary too. Hopefully an
official SDL 1.3 will be released soon and none of the hacks or custom
builds will be required anymore... Wishful thinking, I know.

Best regards,
Filip Navara