[Qemu-devel] [patch 0/2] QEMU maxcpus support

[Qemu-devel] [patch 0/2] QEMU maxcpus support

[Jes Sorensen]

Hi,

This patch set adds the -maxcpus argument to QEMU and provides the
needed patches to the BOCHS patch queue to make the BIOS use it.

Specifying -maxcpus allows the user to cap the limit of possibly cpus
of the system, as opposed to -smp which specifies the number of
running cpus at startup. This allows us to build BIOS tables
accordingly when trying to scale up in size, and it also allows for
the BIOS to build smaller tables when not needed.

I am going to submit a set of patches directly for BOCHS as well
covering the BIOS part, but I am still waiting for my bochs-developers
subscription to be enabled.

Avi asked me to post this both for QEMU and the BIOS part for BOCHS.

Cheers,
Jes

[Qemu-devel] [patch 1/2] Introduce -maxcpus flag to QEMU and pass the value to the BIOS through FW_CFG.

[Jes Sorensen]

[-- Attachment #1: 0001-qemu-cfg-maxcpus.patch --]
[-- Type: text/plain, Size: 3145 bytes --]

Follow on patch will use it to determine the size of the MADT and
other BIOS tables.

Signed-off-by: Jes Sorensen <jes@sgi.com>

---
 hw/fw_cfg.c     |    1 +
 hw/fw_cfg.h     |    1 +
 qemu-options.hx |    9 +++++++++
 sysemu.h        |    1 +
 vl.c            |    8 ++++++++
 5 files changed, 20 insertions(+)

Index: qemu/hw/fw_cfg.c
===================================================================
--- qemu.orig/hw/fw_cfg.c
+++ qemu/hw/fw_cfg.c
@@ -279,6 +279,7 @@ void *fw_cfg_init(uint32_t ctl_port, uin
     fw_cfg_add_bytes(s, FW_CFG_UUID, qemu_uuid, 16);
     fw_cfg_add_i16(s, FW_CFG_NOGRAPHIC, (uint16_t)(display_type == DT_NOGRAPHIC));
     fw_cfg_add_i16(s, FW_CFG_NB_CPUS, (uint16_t)smp_cpus);
+    fw_cfg_add_i16(s, FW_CFG_MAX_CPUS, (uint16_t)max_cpus);
 
     register_savevm("fw_cfg", -1, 1, fw_cfg_save, fw_cfg_load, s);
     qemu_register_reset(fw_cfg_reset, 0, s);
Index: qemu/hw/fw_cfg.h
===================================================================
--- qemu.orig/hw/fw_cfg.h
+++ qemu/hw/fw_cfg.h
@@ -15,6 +15,7 @@
 #define FW_CFG_INITRD_SIZE      0x0b
 #define FW_CFG_BOOT_DEVICE      0x0c
 #define FW_CFG_NUMA             0x0d
+#define FW_CFG_MAX_CPUS         0x0e
 #define FW_CFG_MAX_ENTRY        0x10
 
 #define FW_CFG_WRITE_CHANNEL    0x4000
Index: qemu/qemu-options.hx
===================================================================
--- qemu.orig/qemu-options.hx
+++ qemu/qemu-options.hx
@@ -47,6 +47,15 @@ CPUs are supported. On Sparc32 target, L
 to 4.
 ETEXI
 
+DEF("maxcpus", HAS_ARG, QEMU_OPTION_maxcpus,
+    "-maxcpus n      set maximum number of possibly CPUs to 'n'\n")
+STEXI
+@item -maxcpus @var{n}
+Set the maximum number of possible CPUs to @var(n). @var(n) has to be
+bigger or equal to the value of -smp. If @var(n) is equal to -smp,
+there will be no space for hotplug cpus to be added later.
+ETEXI
+
 DEF("numa", HAS_ARG, QEMU_OPTION_numa,
     "-numa node[,mem=size][,cpus=cpu[-cpu]][,nodeid=node]\n")
 STEXI
Index: qemu/sysemu.h
===================================================================
--- qemu.orig/sysemu.h
+++ qemu/sysemu.h
@@ -118,6 +118,7 @@ extern int alt_grab;
 extern int usb_enabled;
 extern int no_virtio_balloon;
 extern int smp_cpus;
+extern int max_cpus;
 extern int cursor_hide;
 extern int graphic_rotate;
 extern int no_quit;
Index: qemu/vl.c
===================================================================
--- qemu.orig/vl.c
+++ qemu/vl.c
@@ -241,6 +241,7 @@ int rtc_td_hack = 0;
 int usb_enabled = 0;
 int singlestep = 0;
 int smp_cpus = 1;
+int max_cpus = 16;
 const char *vnc_display;
 int acpi_enabled = 1;
 int no_hpet = 0;
@@ -5556,6 +5557,13 @@ int main(int argc, char **argv, char **e
                     exit(1);
                 }
                 break;
+            case QEMU_OPTION_maxcpus:
+                max_cpus = atoi(optarg);
+                if ((max_cpus < 1) || (max_cpus > machine->max_cpus)) {
+                    fprintf(stderr, "Invalid number of CPUs\n");
+                    exit(1);
+                }
+                break;
 	    case QEMU_OPTION_vnc:
                 display_type = DT_VNC;
 		vnc_display = optarg;

[Qemu-devel] [patch 2/2] QEMU BOCHS bios patches to use maxcpus value.

[Jes Sorensen]

[-- Attachment #1: 0002-qemu-bios-patches.patch --]
[-- Type: text/plain, Size: 6708 bytes --]

Signed-off-by: Jes Sorensen <jes@sgi.com>
---
 pc-bios/bios-pq/0017-qemu-kvm-cfg-maxcpus.patch |   57 +++++++++++++
 pc-bios/bios-pq/0018-qemu-madt-maxcpus.patch    |  105 ++++++++++++++++++++++++
 pc-bios/bios-pq/series                          |    2 
 3 files changed, 164 insertions(+)

Index: qemu/pc-bios/bios-pq/0017-qemu-kvm-cfg-maxcpus.patch
===================================================================
--- /dev/null
+++ qemu/pc-bios/bios-pq/0017-qemu-kvm-cfg-maxcpus.patch
@@ -0,0 +1,57 @@
+Read max_cpus variable from QEMU_CFG. If not provided, use value of
+smp_cpus.
+
+Signed-off-by: Jes Sorensen <jes@sgi.com>
+
+diff --git a/bios/rombios32.c b/bios/rombios32.c
+index f861f81..f4a6300 100644
+--- a/bios/rombios32.c
++++ b/bios/rombios32.c
+@@ -436,6 +436,7 @@ void delay_ms(int n)
+ }
+ 
+ uint16_t smp_cpus;
++uint16_t max_cpus;
+ uint32_t cpuid_signature;
+ uint32_t cpuid_features;
+ uint32_t cpuid_ext_features;
+@@ -474,6 +475,7 @@ void wrmsr_smp(uint32_t index, uint64_t val)
+ #define QEMU_CFG_ID         0x01
+ #define QEMU_CFG_UUID       0x02
+ #define QEMU_CFG_NUMA       0x0D
++#define QEMU_CFG_MAX_CPUS   0x0E
+ #define QEMU_CFG_ARCH_LOCAL     0x8000
+ #define QEMU_CFG_ACPI_TABLES  (QEMU_CFG_ARCH_LOCAL + 0)
+ #define QEMU_CFG_SMBIOS_ENTRIES  (QEMU_CFG_ARCH_LOCAL + 1)
+@@ -536,6 +538,19 @@ static uint16_t smbios_entries(void)
+     return cnt;
+ }
+ 
++static uint16_t get_max_cpus(void)
++{
++    uint16_t cnt;
++
++    qemu_cfg_select(QEMU_CFG_MAX_CPUS);
++    qemu_cfg_read((uint8_t*)&cnt, sizeof(cnt));
++
++    if (!cnt)
++        cnt = smp_cpus;
++
++    return cnt;
++}
++
+ uint64_t qemu_cfg_get64 (void)
+ {
+     uint64_t ret;
+@@ -1655,6 +1670,11 @@ void acpi_bios_init(void)
+     uint16_t i, external_tables;
+     int nb_numa_nodes;
+ 
++#ifdef BX_QEMU
++    max_cpus = get_max_cpus();
++#else
++    max_cpus = smp_cpus;
++#endif
+     /* reserve memory space for tables */
+ #ifdef BX_USE_EBDA_TABLES
+     ebda_cur_addr = align(ebda_cur_addr, 16);
Index: qemu/pc-bios/bios-pq/0018-qemu-madt-maxcpus.patch
===================================================================
--- /dev/null
+++ qemu/pc-bios/bios-pq/0018-qemu-madt-maxcpus.patch
@@ -0,0 +1,105 @@
+Use max_cpus when building bios tables.
+
+Signed-off-by: Jes Sorensen <jes@sgi.com>
+
+diff --git a/bios/rombios32.c b/bios/rombios32.c
+index f4a6300..fb4d663 100644
+--- a/bios/rombios32.c
++++ b/bios/rombios32.c
+@@ -1155,13 +1155,13 @@ static void mptable_init(void)
+     putstr(&q, "0.1         "); /* vendor id */
+     putle32(&q, 0); /* OEM table ptr */
+     putle16(&q, 0); /* OEM table size */
+-    putle16(&q, smp_cpus + 18); /* entry count */
++    putle16(&q, max_cpus + 18); /* entry count */
+     putle32(&q, 0xfee00000); /* local APIC addr */
+     putle16(&q, 0); /* ext table length */
+     putb(&q, 0); /* ext table checksum */
+     putb(&q, 0); /* reserved */
+ 
+-    for(i = 0; i < smp_cpus; i++) {
++    for(i = 0; i < max_cpus; i++) {
+         putb(&q, 0); /* entry type = processor */
+         putb(&q, i); /* APIC id */
+         putb(&q, 0x11); /* local APIC version number */
+@@ -1188,7 +1188,7 @@ static void mptable_init(void)
+     putstr(&q, "ISA   ");
+ 
+     /* ioapic */
+-    ioapic_id = smp_cpus;
++    ioapic_id = max_cpus;
+     putb(&q, 2); /* entry type = I/O APIC */
+     putb(&q, ioapic_id); /* apic ID */
+     putb(&q, 0x11); /* I/O APIC version number */
+@@ -1588,7 +1588,7 @@ int acpi_build_processor_ssdt(uint8_t *ssdt)
+ {
+     uint8_t *ssdt_ptr = ssdt;
+     int i, length;
+-    int acpi_cpus = smp_cpus > 0xff ? 0xff : smp_cpus;
++    int acpi_cpus = max_cpus > 0xff ? 0xff : max_cpus;
+ 
+     ssdt_ptr[9] = 0; // checksum;
+     ssdt_ptr += sizeof(struct acpi_table_header);
+@@ -1725,7 +1725,7 @@ void acpi_bios_init(void)
+         addr = (addr + 7) & ~7;
+         srat_addr = addr;
+         srat_size = sizeof(*srat) +
+-            sizeof(struct srat_processor_affinity) * smp_cpus +
++            sizeof(struct srat_processor_affinity) * max_cpus +
+             sizeof(struct srat_memory_affinity) * (nb_numa_nodes + 2);
+         srat = (void *)(addr);
+         addr += srat_size;
+@@ -1738,7 +1738,7 @@ void acpi_bios_init(void)
+     addr = (addr + 7) & ~7;
+     madt_addr = addr;
+     madt_size = sizeof(*madt) +
+-        sizeof(struct madt_processor_apic) * smp_cpus +
++        sizeof(struct madt_processor_apic) * max_cpus +
+ #ifdef BX_QEMU
+         sizeof(struct madt_io_apic) + sizeof(struct madt_int_override);
+ #else
+@@ -1811,7 +1811,7 @@ void acpi_bios_init(void)
+         madt->local_apic_address = cpu_to_le32(0xfee00000);
+         madt->flags = cpu_to_le32(1);
+         apic = (void *)(madt + 1);
+-        for(i=0;i<smp_cpus;i++) {
++        for(i = 0;i < max_cpus; i++) {
+             apic->type = APIC_PROCESSOR;
+             apic->length = sizeof(*apic);
+             apic->processor_id = i;
+@@ -1822,7 +1822,7 @@ void acpi_bios_init(void)
+         io_apic = (void *)apic;
+         io_apic->type = APIC_IO;
+         io_apic->length = sizeof(*io_apic);
+-        io_apic->io_apic_id = smp_cpus;
++        io_apic->io_apic_id = max_cpus;
+         io_apic->address = cpu_to_le32(0xfec00000);
+         io_apic->interrupt = cpu_to_le32(0);
+ #ifdef BX_QEMU
+@@ -1856,7 +1856,7 @@ void acpi_bios_init(void)
+         srat->reserved1=1;
+  
+         core = (void*)(srat + 1);
+-        for (i = 0; i < smp_cpus; ++i) {
++        for (i = 0; i < max_cpus; ++i) {
+              core->type = SRAT_PROCESSOR;
+              core->length = sizeof(*core);
+              core->local_apic_id = i;
+@@ -1864,7 +1864,7 @@ void acpi_bios_init(void)
+              core->proximity_lo = curnode;
+              memset (core->proximity_hi, 0, 3);
+              core->local_sapic_eid = 0;
+-             if (i < smp_cpus)
++             if (i < max_cpus)
+                  core->flags = cpu_to_le32(1);
+              else
+                  core->flags = 0;
+@@ -2614,7 +2614,7 @@ void smbios_init(void)
+     add_struct(0, p);
+     add_struct(1, p);
+     add_struct(3, p);
+-    for (cpu_num = 1; cpu_num <= smp_cpus; cpu_num++)
++    for (cpu_num = 1; cpu_num <= max_cpus; cpu_num++)
+         add_struct(4, p, cpu_num);
+ 
+     /* Each 'memory device' covers up to 16GB of address space. */
Index: qemu/pc-bios/bios-pq/series
===================================================================
--- qemu.orig/pc-bios/bios-pq/series
+++ qemu/pc-bios/bios-pq/series
@@ -14,3 +14,5 @@
 0014_add-srat-acpi-table-support.patch
 0015_enable-power-button-even-generation.patch
 0016-use-correct-mask-to-size-pci-option-rom-bar.patch
+0017-qemu-kvm-cfg-maxcpus.patch
+0018-qemu-madt-maxcpus.patch

[Qemu-devel] Re: [patch 0/2] QEMU maxcpus support

[Avi Kivity]

On 06/23/2009 01:00 PM, Jes Sorensen wrote:
> Hi,
>
> This patch set adds the -maxcpus argument to QEMU and provides the
> needed patches to the BOCHS patch queue to make the BIOS use it.
>
> Specifying -maxcpus allows the user to cap the limit of possibly cpus
> of the system, as opposed to -smp which specifies the number of
> running cpus at startup. This allows us to build BIOS tables
> accordingly when trying to scale up in size, and it also allows for
> the BIOS to build smaller tables when not needed.
>
> I am going to submit a set of patches directly for BOCHS as well
> covering the BIOS part, but I am still waiting for my bochs-developers
> subscription to be enabled.
>
> Avi asked me to post this both for QEMU and the BIOS part for BOCHS.
>    

I should have said this at your previous post, but it only occurred to 
me now:  we could have -smp 4,maxcpus=65536 instead of a new parameter.

-- 
error compiling committee.c: too many arguments to function

[Qemu-devel] Re: [patch 0/2] QEMU maxcpus support

[Jes Sorensen]

On 06/23/2009 01:37 PM, Avi Kivity wrote:
> On 06/23/2009 01:00 PM, Jes Sorensen wrote:
>> Avi asked me to post this both for QEMU and the BIOS part for BOCHS.
>
> I should have said this at your previous post, but it only occurred to
> me now: we could have -smp 4,maxcpus=65536 instead of a new parameter.
>

We could do that too, but is it really worth it? It seems to me -maxcpus
is fine?

Cheers,
Jes

[Qemu-devel] Re: [patch 0/2] QEMU maxcpus support

[Avi Kivity]

On 06/23/2009 04:32 PM, Jes Sorensen wrote:
>> I should have said this at your previous post, but it only occurred to
>> me now: we could have -smp 4,maxcpus=65536 instead of a new parameter.
>>
>
>
> We could do that too, but is it really worth it? It seems to me -maxcpus
> is fine?

The trend is to consolidate related options into a single option, -to 
-avoid -command -lines -with -too -many -dashes.

-- 
error compiling committee.c: too many arguments to function

[Qemu-devel] Re: [patch 0/2] QEMU maxcpus support

[Jes Sorensen]

[-- Attachment #1: Type: text/plain, Size: 489 bytes --]

On 06/23/2009 03:36 PM, Avi Kivity wrote:
> On 06/23/2009 04:32 PM, Jes Sorensen wrote:
>>> I should have said this at your previous post, but it only occurred to
>>> me now: we could have -smp 4,maxcpus=65536 instead of a new parameter.
>>
>> We could do that too, but is it really worth it? It seems to me -maxcpus
>> is fine?
>
> The trend is to consolidate related options into a single option, -to
> -avoid -command -lines -with -too -many -dashes.

Ok, so how about this then?

Jes


[-- Attachment #2: 0001-qemu-cfg-maxcpus.patch --]
[-- Type: text/x-patch, Size: 3847 bytes --]

Introduce -smp ,maxcpus= flag to specify maximum number of CPUS.

Follow on patch will use it to determine the size of the MADT and
other BIOS tables.

Signed-off-by: Jes Sorensen <jes@sgi.com>

---
 hw/fw_cfg.c     |    1 +
 hw/fw_cfg.h     |    1 +
 qemu-options.hx |    5 ++++-
 sysemu.h        |    1 +
 vl.c            |   20 +++++++++++++++++++-
 5 files changed, 26 insertions(+), 2 deletions(-)

Index: qemu/hw/fw_cfg.c
===================================================================
--- qemu.orig/hw/fw_cfg.c
+++ qemu/hw/fw_cfg.c
@@ -279,6 +279,7 @@ void *fw_cfg_init(uint32_t ctl_port, uin
     fw_cfg_add_bytes(s, FW_CFG_UUID, qemu_uuid, 16);
     fw_cfg_add_i16(s, FW_CFG_NOGRAPHIC, (uint16_t)(display_type == DT_NOGRAPHIC));
     fw_cfg_add_i16(s, FW_CFG_NB_CPUS, (uint16_t)smp_cpus);
+    fw_cfg_add_i16(s, FW_CFG_MAX_CPUS, (uint16_t)max_cpus);
 
     register_savevm("fw_cfg", -1, 1, fw_cfg_save, fw_cfg_load, s);
     qemu_register_reset(fw_cfg_reset, 0, s);
Index: qemu/hw/fw_cfg.h
===================================================================
--- qemu.orig/hw/fw_cfg.h
+++ qemu/hw/fw_cfg.h
@@ -15,6 +15,7 @@
 #define FW_CFG_INITRD_SIZE      0x0b
 #define FW_CFG_BOOT_DEVICE      0x0c
 #define FW_CFG_NUMA             0x0d
+#define FW_CFG_MAX_CPUS         0x0e
 #define FW_CFG_MAX_ENTRY        0x10
 
 #define FW_CFG_WRITE_CHANNEL    0x4000
Index: qemu/qemu-options.hx
===================================================================
--- qemu.orig/qemu-options.hx
+++ qemu/qemu-options.hx
@@ -39,7 +39,10 @@ Select CPU model (-cpu ? for list and ad
 ETEXI
 
 DEF("smp", HAS_ARG, QEMU_OPTION_smp,
-    "-smp n          set the number of CPUs to 'n' [default=1]\n")
+    "-smp n,[maxcpus=cpus]\n"
+    "                set the number of CPUs to 'n' [default=1]\n"
+    "                maxcpus= maximum number of total cpus, including\n"
+    "                offline CPUs for hotplug etc.\n")
 STEXI
 @item -smp @var{n}
 Simulate an SMP system with @var{n} CPUs. On the PC target, up to 255
Index: qemu/sysemu.h
===================================================================
--- qemu.orig/sysemu.h
+++ qemu/sysemu.h
@@ -118,6 +118,7 @@ extern int alt_grab;
 extern int usb_enabled;
 extern int no_virtio_balloon;
 extern int smp_cpus;
+extern int max_cpus;
 extern int cursor_hide;
 extern int graphic_rotate;
 extern int no_quit;
Index: qemu/vl.c
===================================================================
--- qemu.orig/vl.c
+++ qemu/vl.c
@@ -241,6 +241,7 @@ int rtc_td_hack = 0;
 int usb_enabled = 0;
 int singlestep = 0;
 int smp_cpus = 1;
+int max_cpus = 16;
 const char *vnc_display;
 int acpi_enabled = 1;
 int no_hpet = 0;
@@ -5550,12 +5551,29 @@ int main(int argc, char **argv, char **e
                 usb_devices_index++;
                 break;
             case QEMU_OPTION_smp:
-                smp_cpus = atoi(optarg);
+            {
+                char *p;
+                char option[128];
+                smp_cpus = strtol(optarg, &p, 10);
                 if (smp_cpus < 1) {
                     fprintf(stderr, "Invalid number of CPUs\n");
                     exit(1);
                 }
+                if (*p++ != ',')
+                    break;
+                if (get_param_value(option, 128, "maxcpus", p))
+                    max_cpus = strtol(option, NULL, 0);
+                if (max_cpus < smp_cpus) {
+                    fprintf(stderr, "maxcpus must be equal to or greater than "
+                            "smp\n");
+                    exit(1);
+                }
+                if (max_cpus > 255) {
+                    fprintf(stderr, "Unsupported number of maxcpus\n");
+                    exit(1);
+                }
                 break;
+            }
 	    case QEMU_OPTION_vnc:
                 display_type = DT_VNC;
 		vnc_display = optarg;

[Qemu-devel] Re: [patch 0/2] QEMU maxcpus support

[Avi Kivity]

On 06/23/2009 06:07 PM, Jes Sorensen wrote:
> On 06/23/2009 03:36 PM, Avi Kivity wrote:
>> On 06/23/2009 04:32 PM, Jes Sorensen wrote:
>>>> I should have said this at your previous post, but it only occurred to
>>>> me now: we could have -smp 4,maxcpus=65536 instead of a new parameter.
>>>
>>> We could do that too, but is it really worth it? It seems to me 
>>> -maxcpus
>>> is fine?
>>
>> The trend is to consolidate related options into a single option, -to
>> -avoid -command -lines -with -too -many -dashes.
>
> Ok, so how about this then?
>
>
>   DEF("smp", HAS_ARG, QEMU_OPTION_smp,
> -    "-smp n          set the number of CPUs to 'n' [default=1]\n")
> +    "-smp n,[maxcpus=cpus]\n"
>    

-smp n[,maxcpus=cpus]

> @@ -5550,12 +5551,29 @@ int main(int argc, char **argv, char **e
>                   usb_devices_index++;
>                   break;
>               case QEMU_OPTION_smp:
> -                smp_cpus = atoi(optarg);
> +            {
> +                char *p;
> +                char option[128];
> +                smp_cpus = strtol(optarg,&p, 10);
>                   if (smp_cpus<  1) {
>                       fprintf(stderr, "Invalid number of CPUs\n");
>                       exit(1);
>                   }
> +                if (*p++ != ',')
> +                    break;
>    

Won't this misparse "-smp 17z"?

> +                if (get_param_value(option, 128, "maxcpus", p))
> +                    max_cpus = strtol(option, NULL, 0);
> +                if (max_cpus<  smp_cpus) {
> +                    fprintf(stderr, "maxcpus must be equal to or greater than "
> +                            "smp\n");
> +                    exit(1);
> +                }
> +                if (max_cpus>  255) {
> +                    fprintf(stderr, "Unsupported number of maxcpus\n");
> +                    exit(1);
> +                }
>                   break;
> +            }
>    

We really need a table-driven parser for options.

-- 
error compiling committee.c: too many arguments to function

[Qemu-devel] Re: [patch 0/2] QEMU maxcpus support

[Jes Sorensen]

On 06/23/2009 05:47 PM, Avi Kivity wrote:
> On 06/23/2009 06:07 PM, Jes Sorensen wrote:
>> DEF("smp", HAS_ARG, QEMU_OPTION_smp,
>> - "-smp n set the number of CPUs to 'n' [default=1]\n")
>> + "-smp n,[maxcpus=cpus]\n"
>
> -smp n[,maxcpus=cpus]

I don't follow you there, please elaborate.

>> + if (*p++ != ',')
>> + break;
>
> Won't this misparse "-smp 17z"?

It will be parsed as -smp 17, which is consistent with how the rest of
the options are parsed in QEMU. I am not going to rewrite the whole
parser for you :)

Cheers,
Jes

Re: [Qemu-devel] Re: [patch 0/2] QEMU maxcpus support

[Filip Navara]

On Wed, Jun 24, 2009 at 9:16 AM, Jes Sorensen<jes@sgi.com> wrote:
> On 06/23/2009 05:47 PM, Avi Kivity wrote:
>>
>> On 06/23/2009 06:07 PM, Jes Sorensen wrote:
>>>
>>> DEF("smp", HAS_ARG, QEMU_OPTION_smp,
>>> - "-smp n set the number of CPUs to 'n' [default=1]\n")
>>> + "-smp n,[maxcpus=cpus]\n"
>>
>> -smp n[,maxcpus=cpus]
>
> I don't follow you there, please elaborate.
>

The comma should be inside the brackets, not outside.

Best regards,
Filip Navara