From: Wei Huang <wei.huang2@amd.com>
To: "'xen-devel@lists.xensource.com'" <xen-devel@lists.xensource.com>,
stefano.stabellini@eu.citrix.com
Subject: A typo in vram dirty tracking function?
Date: Wed, 24 Jun 2009 18:01:50 -0500 [thread overview]
Message-ID: <4A42B05E.8060108@amd.com> (raw)
Is this a typo? I haven't tried it myself. But did you want to convert
logdirty to rw mode?
-Wei
--- a/xen/arch/x86/mm/hap/hap.c Sun Jun 28 22:17:37 2009 -0500
+++ b/xen/arch/x86/mm/hap/hap.c Mon Jun 29 07:43:11 2009 -0500
@@ -90,7 +90,7 @@ int hap_disable_vram_tracking(struct dom
/* set l1e entries of P2M table with normal mode */
for (i = dirty_vram->begin_pfn; i < dirty_vram->end_pfn; i++)
- p2m_change_type(d, i, p2m_ram_rw, p2m_ram_logdirty);
+ p2m_change_type(d, i, p2m_ram_logdirty, p2m_ram_rw);
flush_tlb_mask(&d->domain_dirty_cpumask);
next reply other threads:[~2009-06-24 23:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-24 23:01 Wei Huang [this message]
2009-06-25 12:26 ` A typo in vram dirty tracking function? Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A42B05E.8060108@amd.com \
--to=wei.huang2@amd.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.