* A typo in vram dirty tracking function?
@ 2009-06-24 23:01 Wei Huang
2009-06-25 12:26 ` Stefano Stabellini
0 siblings, 1 reply; 2+ messages in thread
From: Wei Huang @ 2009-06-24 23:01 UTC (permalink / raw)
To: 'xen-devel@lists.xensource.com', stefano.stabellini
Is this a typo? I haven't tried it myself. But did you want to convert
logdirty to rw mode?
-Wei
--- a/xen/arch/x86/mm/hap/hap.c Sun Jun 28 22:17:37 2009 -0500
+++ b/xen/arch/x86/mm/hap/hap.c Mon Jun 29 07:43:11 2009 -0500
@@ -90,7 +90,7 @@ int hap_disable_vram_tracking(struct dom
/* set l1e entries of P2M table with normal mode */
for (i = dirty_vram->begin_pfn; i < dirty_vram->end_pfn; i++)
- p2m_change_type(d, i, p2m_ram_rw, p2m_ram_logdirty);
+ p2m_change_type(d, i, p2m_ram_logdirty, p2m_ram_rw);
flush_tlb_mask(&d->domain_dirty_cpumask);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: A typo in vram dirty tracking function?
2009-06-24 23:01 A typo in vram dirty tracking function? Wei Huang
@ 2009-06-25 12:26 ` Stefano Stabellini
0 siblings, 0 replies; 2+ messages in thread
From: Stefano Stabellini @ 2009-06-25 12:26 UTC (permalink / raw)
To: Wei Huang; +Cc: 'xen-devel@lists.xensource.com'
Wei Huang wrote:
> Is this a typo? I haven't tried it myself. But did you want to convert
> logdirty to rw mode?
>
> -Wei
>
> --- a/xen/arch/x86/mm/hap/hap.c Sun Jun 28 22:17:37 2009 -0500
> +++ b/xen/arch/x86/mm/hap/hap.c Mon Jun 29 07:43:11 2009 -0500
> @@ -90,7 +90,7 @@ int hap_disable_vram_tracking(struct dom
>
> /* set l1e entries of P2M table with normal mode */
> for (i = dirty_vram->begin_pfn; i < dirty_vram->end_pfn; i++)
> - p2m_change_type(d, i, p2m_ram_rw, p2m_ram_logdirty);
> + p2m_change_type(d, i, p2m_ram_logdirty, p2m_ram_rw);
>
> flush_tlb_mask(&d->domain_dirty_cpumask);
>
>
Yes, this is a typo. Thanks for pointing it out!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-25 12:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-24 23:01 A typo in vram dirty tracking function? Wei Huang
2009-06-25 12:26 ` Stefano Stabellini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.