Re: A typo in vram dirty tracking function?

[Stefano Stabellini <stefano.stabellini@eu.citrix.com>]

Wei Huang wrote:

> Is this a typo? I haven't tried it myself. But did you want to convert 
> logdirty to rw mode?
> 
> -Wei
> 
> --- a/xen/arch/x86/mm/hap/hap.c Sun Jun 28 22:17:37 2009 -0500
> +++ b/xen/arch/x86/mm/hap/hap.c Mon Jun 29 07:43:11 2009 -0500
> @@ -90,7 +90,7 @@ int hap_disable_vram_tracking(struct dom
> 
>       /* set l1e entries of P2M table with normal mode */
>       for (i = dirty_vram->begin_pfn; i < dirty_vram->end_pfn; i++)
> -        p2m_change_type(d, i, p2m_ram_rw, p2m_ram_logdirty);
> +        p2m_change_type(d, i, p2m_ram_logdirty, p2m_ram_rw);
> 
>       flush_tlb_mask(&d->domain_dirty_cpumask);
> 
> 


Yes, this is a typo. Thanks for pointing it out!