From: Steve Dickson <SteveD@redhat.com>
To: David Howells <dhowells@redhat.com>
Cc: bfields@fieldses.org,
rasmus-tUP8e6pgWdNlY7y4Fx5NiA@public.gmane.org,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NFSD: Don't hold unrefcounted creds over call to nfsd_setuser()
Date: Thu, 02 Jul 2009 09:59:42 -0400 [thread overview]
Message-ID: <4A4CBD4E.90802@RedHat.com> (raw)
In-Reply-To: <20090702133532.28297.89635.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
On 07/02/2009 09:35 AM, David Howells wrote:
> nfsd_open() gets an unrefcounted pointer to the current process's effective
> credentials at the top of the function, then calls nfsd_setuser() via
> fh_verify() - which may replace and destroy the current process's effective
> credentials - and then passes the unrefcounted pointer to dentry_open() - but
> the credentials may have been destroyed by this point.
>
> Instead, the value from current_cred() should be passed directly to
> dentry_open() as one of its arguments, rather than being cached in a variable.
>
> Possibly fh_verify() should return the creds to use.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
Tested-and-Verified-By: Steve Dickson <steved@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Steve Dickson <SteveD@redhat.com>
To: David Howells <dhowells@redhat.com>
Cc: bfields@fieldses.org, rasmus@msconsult.dk,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NFSD: Don't hold unrefcounted creds over call to nfsd_setuser()
Date: Thu, 02 Jul 2009 09:59:42 -0400 [thread overview]
Message-ID: <4A4CBD4E.90802@RedHat.com> (raw)
In-Reply-To: <20090702133532.28297.89635.stgit@warthog.procyon.org.uk>
On 07/02/2009 09:35 AM, David Howells wrote:
> nfsd_open() gets an unrefcounted pointer to the current process's effective
> credentials at the top of the function, then calls nfsd_setuser() via
> fh_verify() - which may replace and destroy the current process's effective
> credentials - and then passes the unrefcounted pointer to dentry_open() - but
> the credentials may have been destroyed by this point.
>
> Instead, the value from current_cred() should be passed directly to
> dentry_open() as one of its arguments, rather than being cached in a variable.
>
> Possibly fh_verify() should return the creds to use.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
Tested-and-Verified-By: Steve Dickson <steved@redhat.com>
next prev parent reply other threads:[~2009-07-02 14:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-02 13:35 [PATCH] NFSD: Don't hold unrefcounted creds over call to nfsd_setuser() David Howells
2009-07-02 13:35 ` David Howells
[not found] ` <20090702133532.28297.89635.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2009-07-02 13:59 ` Steve Dickson [this message]
2009-07-02 13:59 ` Steve Dickson
2009-07-02 20:39 ` J. Bruce Fields
2009-07-02 20:39 ` J. Bruce Fields
2009-07-02 21:31 ` David Howells
2009-07-02 21:31 ` David Howells
2009-07-02 23:09 ` J. Bruce Fields
2009-07-02 23:09 ` J. Bruce Fields
2009-07-03 14:22 ` J. Bruce Fields
2009-07-03 14:22 ` J. Bruce Fields
2009-07-03 14:41 ` David Howells
2009-07-03 14:41 ` David Howells
2009-07-03 15:47 ` J. Bruce Fields
2009-07-03 15:47 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4CBD4E.90802@RedHat.com \
--to=steved@redhat.com \
--cc=bfields@fieldses.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=rasmus-tUP8e6pgWdNlY7y4Fx5NiA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.