* [PATCH] Fix g_isi_client_destroy segfault
@ 2009-07-09 12:37 Marko Saukko
2009-07-09 13:19 ` Aki Niemi
0 siblings, 1 reply; 2+ messages in thread
From: Marko Saukko @ 2009-07-09 12:37 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 521 bytes --]
If null pointer is given to g_isi_client_destroy it segfaults. Currently
this is happening when signal 15 is sent to ofonod.
---
diff --git a/gisi/client.c b/gisi/client.c
index b12dc85..a12640d 100644
--- a/gisi/client.c
+++ b/gisi/client.c
@@ -143,6 +143,8 @@ void g_isi_client_destroy(GIsiClient *client)
{
unsigned id;
+ if (!client)
+ return;
g_source_remove(client->source);
for (id = 0; id < 256; id++)
if (client->timeout[id] > 0)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix g_isi_client_destroy segfault
2009-07-09 12:37 [PATCH] Fix g_isi_client_destroy segfault Marko Saukko
@ 2009-07-09 13:19 ` Aki Niemi
0 siblings, 0 replies; 2+ messages in thread
From: Aki Niemi @ 2009-07-09 13:19 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 425 bytes --]
On Thu, 09 Jul 2009 15:37:48 +0300, Marko Saukko <marko.saukko@gmail.com>
wrote:
> If null pointer is given to g_isi_client_destroy it segfaults. Currently
> this is happening when signal 15 is sent to ofonod.
I pushed a patch to isimodem.c that should fix this, as well as another
problem related to the current lack of support for multiple parallel ISI
modems in Phonet.
Thanks for reporting.
Cheers,
Aki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-09 13:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-09 12:37 [PATCH] Fix g_isi_client_destroy segfault Marko Saukko
2009-07-09 13:19 ` Aki Niemi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.