[PATCH] Fix g_isi_client_destroy segfault

[PATCH] Fix g_isi_client_destroy segfault

[Marko Saukko]

[-- Attachment #1: Type: text/plain, Size: 521 bytes --]

If null pointer is given to g_isi_client_destroy it segfaults. Currently
this is happening when signal 15 is sent to ofonod.

---

diff --git a/gisi/client.c b/gisi/client.c
index b12dc85..a12640d 100644
--- a/gisi/client.c
+++ b/gisi/client.c
@@ -143,6 +143,8 @@ void g_isi_client_destroy(GIsiClient *client)
 {
        unsigned id;

+       if (!client)
+               return;
        g_source_remove(client->source);
        for (id = 0; id < 256; id++)
                if (client->timeout[id] > 0)

Re: [PATCH] Fix g_isi_client_destroy segfault

[Aki Niemi]

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]


On Thu, 09 Jul 2009 15:37:48 +0300, Marko Saukko <marko.saukko@gmail.com>
wrote:
> If null pointer is given to g_isi_client_destroy it segfaults. Currently
> this is happening when signal 15 is sent to ofonod.

I pushed a patch to isimodem.c that should fix this, as well as another
problem related to the current lack of support for multiple parallel ISI
modems in Phonet.

Thanks for reporting.

Cheers,
Aki