All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Jenkins <alan-jenkins-cCz0Lq7MMjm9FHfhHBbuYA@public.gmane.org>
To: Ondrej Zary <linux-ZCIryABCsrmttCpgsWEBFmD2FQJk+8+b@public.gmane.org>
Cc: Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>,
	Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>,
	Jens Axboe <jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	linux-kernel
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Kernel Testers List
	<kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: "floppy: fix hibernation" causes error on resume from ram
Date: Sat, 18 Jul 2009 19:27:34 +0100	[thread overview]
Message-ID: <4A621416.2060609@tuffmail.co.uk> (raw)
In-Reply-To: <200907182019.57909.linux-ZCIryABCsrmttCpgsWEBFmD2FQJk+8+b@public.gmane.org>

Ondrej Zary wrote:
> On Saturday 18 July 2009 20:06:54 Alan Jenkins wrote:
>   
>> Thanks for the hibernation fix!  Until recently I thought my floppy was
>> just dead.  Unfortunately, the fix seems to cause me errors on resume
>> from suspend to ram.  The floppy works fine afterwards, it just spams
>> the log.
>>
>> On 2.6.30 there were no errors, and the floppy survived suspend-to-ram.
>> So I guess the quick fix would be to only do the fix-up on resume from
>> hibernation, and not suspend-to-ram.
>>     
>
> My machine has no suspend-to-RAM so I haven't tested it.
>
> That would be probably the correct fix. But how to do it? AFAIK, there's only 
> one suspend() and one resume() for everything. And that looks very wrong as 
> resume-from-hibernation is fundamentally different from resume-from-RAM.
>   

Ok.  Looking at drivers/base/platform.c, we want "restore()".  I guess I
can do the patch myself :-).

Thanks
Alan

WARNING: multiple messages have this Message-ID (diff)
From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: Ingo Molnar <mingo@elte.hu>, Pavel Machek <pavel@ucw.cz>,
	Jens Axboe <jens.axboe@oracle.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Kernel Testers List <kernel-testers@vger.kernel.org>
Subject: Re: "floppy: fix hibernation" causes error on resume from ram
Date: Sat, 18 Jul 2009 19:27:34 +0100	[thread overview]
Message-ID: <4A621416.2060609@tuffmail.co.uk> (raw)
In-Reply-To: <200907182019.57909.linux@rainbow-software.org>

Ondrej Zary wrote:
> On Saturday 18 July 2009 20:06:54 Alan Jenkins wrote:
>   
>> Thanks for the hibernation fix!  Until recently I thought my floppy was
>> just dead.  Unfortunately, the fix seems to cause me errors on resume
>> from suspend to ram.  The floppy works fine afterwards, it just spams
>> the log.
>>
>> On 2.6.30 there were no errors, and the floppy survived suspend-to-ram.
>> So I guess the quick fix would be to only do the fix-up on resume from
>> hibernation, and not suspend-to-ram.
>>     
>
> My machine has no suspend-to-RAM so I haven't tested it.
>
> That would be probably the correct fix. But how to do it? AFAIK, there's only 
> one suspend() and one resume() for everything. And that looks very wrong as 
> resume-from-hibernation is fundamentally different from resume-from-RAM.
>   

Ok.  Looking at drivers/base/platform.c, we want "restore()".  I guess I
can do the patch myself :-).

Thanks
Alan

  parent reply	other threads:[~2009-07-18 18:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-18 18:06 "floppy: fix hibernation" causes error on resume from ram Alan Jenkins
2009-07-18 18:06 ` Alan Jenkins
     [not found] ` <4A620F3E.8080900-cCz0Lq7MMjm9FHfhHBbuYA@public.gmane.org>
2009-07-18 18:19   ` Ondrej Zary
2009-07-18 18:19     ` Ondrej Zary
     [not found]     ` <200907182019.57909.linux-ZCIryABCsrmttCpgsWEBFmD2FQJk+8+b@public.gmane.org>
2009-07-18 18:27       ` Alan Jenkins [this message]
2009-07-18 18:27         ` Alan Jenkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A621416.2060609@tuffmail.co.uk \
    --to=alan-jenkins-ccz0lq7mmjm9fhfhhbbuya@public.gmane.org \
    --cc=jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-ZCIryABCsrmttCpgsWEBFmD2FQJk+8+b@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mingo-X9Un+BFzKDI@public.gmane.org \
    --cc=pavel-+ZI9xUNit7I@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.