[Ocfs2-devel] [PATCH 1/1] fixes a dangerous typo

[Ocfs2-devel] [PATCH 1/1] fixes a dangerous typo

[Wengang Wang]

Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
---
 fs/ocfs2/aops.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c
index b730010..a10c989 100644
--- a/fs/ocfs2/aops.c
+++ b/fs/ocfs2/aops.c
@@ -1397,7 +1397,7 @@ static int ocfs2_write_cluster(struct address_space *mapping,
 		if (tmpret) {
 			mlog_errno(tmpret);
 			if (ret == 0)
-				tmpret = ret;
+				ret = tmpret;
 		}
 	}
 
-- 
1.6.2.5

[Ocfs2-devel] [PATCH 1/1] fixes a dangerous typo

[Joel Becker]

On Mon, Jul 13, 2009 at 11:38:23AM +0800, Wengang Wang wrote:
> Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>

This change is in the fixes branch of ocfs2.git.  However, in the
future, the commit message needs more information.  The commit message
above doesn't even mention what the dangerous typo is.  Someone reading
the message wouldn't know what had changed at all.

I've fixed the message, but in the future please try to be descriptive.

Joel

-- 

"Practice random acts of kindness and senseless acts of beauty."

 Oh, and don't forget where your towel is.

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127

[Ocfs2-devel] [PATCH 1/1] fixes a dangerous typo

[Wengang Wang]

Ok, I will be descriptive for posts in the future.

regards,
wengang.

Joel Becker wrote:
> On Mon, Jul 13, 2009 at 11:38:23AM +0800, Wengang Wang wrote:
>> Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
> 
> This change is in the fixes branch of ocfs2.git.  However, in the
> future, the commit message needs more information.  The commit message
> above doesn't even mention what the dangerous typo is.  Someone reading
> the message wouldn't know what had changed at all.
> 
> I've fixed the message, but in the future please try to be descriptive.
> 
> Joel