* [Ocfs2-devel] [PATCH 1/1] fixes a dangerous typo
@ 2009-07-13 3:38 Wengang Wang
2009-07-21 0:38 ` Joel Becker
0 siblings, 1 reply; 3+ messages in thread
From: Wengang Wang @ 2009-07-13 3:38 UTC (permalink / raw)
To: ocfs2-devel
Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
---
fs/ocfs2/aops.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c
index b730010..a10c989 100644
--- a/fs/ocfs2/aops.c
+++ b/fs/ocfs2/aops.c
@@ -1397,7 +1397,7 @@ static int ocfs2_write_cluster(struct address_space *mapping,
if (tmpret) {
mlog_errno(tmpret);
if (ret == 0)
- tmpret = ret;
+ ret = tmpret;
}
}
--
1.6.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* [Ocfs2-devel] [PATCH 1/1] fixes a dangerous typo
2009-07-13 3:38 [Ocfs2-devel] [PATCH 1/1] fixes a dangerous typo Wengang Wang
@ 2009-07-21 0:38 ` Joel Becker
2009-07-21 1:55 ` Wengang Wang
0 siblings, 1 reply; 3+ messages in thread
From: Joel Becker @ 2009-07-21 0:38 UTC (permalink / raw)
To: ocfs2-devel
On Mon, Jul 13, 2009 at 11:38:23AM +0800, Wengang Wang wrote:
> Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
This change is in the fixes branch of ocfs2.git. However, in the
future, the commit message needs more information. The commit message
above doesn't even mention what the dangerous typo is. Someone reading
the message wouldn't know what had changed at all.
I've fixed the message, but in the future please try to be descriptive.
Joel
--
"Practice random acts of kindness and senseless acts of beauty."
Oh, and don't forget where your towel is.
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Ocfs2-devel] [PATCH 1/1] fixes a dangerous typo
2009-07-21 0:38 ` Joel Becker
@ 2009-07-21 1:55 ` Wengang Wang
0 siblings, 0 replies; 3+ messages in thread
From: Wengang Wang @ 2009-07-21 1:55 UTC (permalink / raw)
To: ocfs2-devel
Ok, I will be descriptive for posts in the future.
regards,
wengang.
Joel Becker wrote:
> On Mon, Jul 13, 2009 at 11:38:23AM +0800, Wengang Wang wrote:
>> Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
>
> This change is in the fixes branch of ocfs2.git. However, in the
> future, the commit message needs more information. The commit message
> above doesn't even mention what the dangerous typo is. Someone reading
> the message wouldn't know what had changed at all.
>
> I've fixed the message, but in the future please try to be descriptive.
>
> Joel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-07-21 1:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-13 3:38 [Ocfs2-devel] [PATCH 1/1] fixes a dangerous typo Wengang Wang
2009-07-21 0:38 ` Joel Becker
2009-07-21 1:55 ` Wengang Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.