From: Artem Bityutskiy <dedekind1@gmail.com>
To: JiSheng Zhang <jszhang3@gmail.com>
Cc: Artem.Bityutskiy@nokia.com, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org, dwmw2@infradead.org,
rmk@arm.linux.org.uk, adrian.hunter@nokia.com
Subject: Re: [PATCH] UBI: Fix allocation of volume table
Date: Fri, 14 Aug 2009 19:05:30 +0300 [thread overview]
Message-ID: <4A858B4A.9000705@gmail.com> (raw)
In-Reply-To: <20090811094455.6f9cbbfe@ustc>
On 08/11/2009 04:44 AM, JiSheng Zhang wrote:
> We can't use vmalloc for the buffer used for volume table for some NAND
> or NOR drivers may pass the buffer to DMA. And the volume table size
> a.k.a vtbl_size is small so we can use kmalloc or kzalloc for it instead
>
> Signed-off-by: JiSheng Zhang<jszhang3@gmail.com>
I do not have objections if this patch becomes a member of a series of
patches which kick vmalloc from whole UBI. Applying just this patch does
not make much sense.
You may go through UBI code and try to split large vmalloc-ed buffers on
smaller kmalloc-ed ones.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: JiSheng Zhang <jszhang3@gmail.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Artem.Bityutskiy@nokia.com, adrian.hunter@nokia.com,
rmk@arm.linux.org.uk, dwmw2@infradead.org
Subject: Re: [PATCH] UBI: Fix allocation of volume table
Date: Fri, 14 Aug 2009 19:05:30 +0300 [thread overview]
Message-ID: <4A858B4A.9000705@gmail.com> (raw)
In-Reply-To: <20090811094455.6f9cbbfe@ustc>
On 08/11/2009 04:44 AM, JiSheng Zhang wrote:
> We can't use vmalloc for the buffer used for volume table for some NAND
> or NOR drivers may pass the buffer to DMA. And the volume table size
> a.k.a vtbl_size is small so we can use kmalloc or kzalloc for it instead
>
> Signed-off-by: JiSheng Zhang<jszhang3@gmail.com>
I do not have objections if this patch becomes a member of a series of
patches which kick vmalloc from whole UBI. Applying just this patch does
not make much sense.
You may go through UBI code and try to split large vmalloc-ed buffers on
smaller kmalloc-ed ones.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2009-08-14 16:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-11 1:44 [PATCH] UBI: Fix allocation of volume table JiSheng Zhang
2009-08-11 1:44 ` JiSheng Zhang
2009-08-14 16:05 ` Artem Bityutskiy [this message]
2009-08-14 16:05 ` Artem Bityutskiy
-- strict thread matches above, loose matches on Subject: below --
2009-08-11 1:25 JiSheng Zhang
2009-08-11 1:25 ` JiSheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A858B4A.9000705@gmail.com \
--to=dedekind1@gmail.com \
--cc=Artem.Bityutskiy@nokia.com \
--cc=adrian.hunter@nokia.com \
--cc=dwmw2@infradead.org \
--cc=jszhang3@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.