All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Lord <liml@rtr.ca>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	jens.axboe@oracle.com
Subject: Re: [PATCH, RFC] xfs: batched discard support
Date: Sun, 16 Aug 2009 09:00:35 -0400	[thread overview]
Message-ID: <4A8802F3.6010908@rtr.ca> (raw)
In-Reply-To: <20090816022500.GA12392@infradead.org>

Christoph Hellwig wrote:
> On Sat, Aug 15, 2009 at 10:19:21PM -0400, Mark Lord wrote:
>> Mark Lord wrote:
>>> Christoph Hellwig wrote:
>> ..
>>>> Mark, any chance to try it?  Just create an XFS filesystem, age it a
>>>> bit and then call the attached little trim.c program on the mountmoint
>>>> (or any file inside the filesystem for that matter)
>>> ..
>>>
>>> Looking at it now.  Thanks, Christoph!
>> ..
>>
>> Fails to work on 64-bit kernel w/ 32-bit userspace (no compat ioctl).
>> Rebuilding with 32-bit kernel now..
> 
> The actual ioctl is compatible, just add the
> 
> 	case XFS_IOC_TRIM:
> 		return xfs_ioc_trim(mp, arg);
> 
> to xfs_file_compat_ioctl().  I'll add this to the next spin of the patch.
..

Okay, this gives me ENOSYS now --> discard/trim support is missing from
the lower layers.

What other patches do I need to make this work?

The latest from Matthew's discard tree (May 2009) don't appear to be sufficient,
even after updating them for 2.6.31-rc6.

???

WARNING: multiple messages have this Message-ID (diff)
From: Mark Lord <liml@rtr.ca>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, jens.axboe@oracle.com,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	xfs@oss.sgi.com
Subject: Re: [PATCH, RFC] xfs: batched discard support
Date: Sun, 16 Aug 2009 09:00:35 -0400	[thread overview]
Message-ID: <4A8802F3.6010908@rtr.ca> (raw)
In-Reply-To: <20090816022500.GA12392@infradead.org>

Christoph Hellwig wrote:
> On Sat, Aug 15, 2009 at 10:19:21PM -0400, Mark Lord wrote:
>> Mark Lord wrote:
>>> Christoph Hellwig wrote:
>> ..
>>>> Mark, any chance to try it?  Just create an XFS filesystem, age it a
>>>> bit and then call the attached little trim.c program on the mountmoint
>>>> (or any file inside the filesystem for that matter)
>>> ..
>>>
>>> Looking at it now.  Thanks, Christoph!
>> ..
>>
>> Fails to work on 64-bit kernel w/ 32-bit userspace (no compat ioctl).
>> Rebuilding with 32-bit kernel now..
> 
> The actual ioctl is compatible, just add the
> 
> 	case XFS_IOC_TRIM:
> 		return xfs_ioc_trim(mp, arg);
> 
> to xfs_file_compat_ioctl().  I'll add this to the next spin of the patch.
..

Okay, this gives me ENOSYS now --> discard/trim support is missing from
the lower layers.

What other patches do I need to make this work?

The latest from Matthew's discard tree (May 2009) don't appear to be sufficient,
even after updating them for 2.6.31-rc6.

???

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2009-08-16 13:00 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-16  0:47 [PATCH, RFC] xfs: batched discard support Christoph Hellwig
2009-08-16  0:47 ` Christoph Hellwig
2009-08-16  1:35 ` Mark Lord
2009-08-16  1:35   ` Mark Lord
2009-08-16  2:19   ` Mark Lord
2009-08-16  2:19     ` Mark Lord
2009-08-16  2:25     ` Christoph Hellwig
2009-08-16  2:25       ` Christoph Hellwig
2009-08-16  2:49       ` Mark Lord
2009-08-16  2:49         ` Mark Lord
2009-08-16  3:25         ` Mark Lord
2009-08-16  3:25           ` Mark Lord
2009-08-16 13:00       ` Mark Lord [this message]
2009-08-16 13:00         ` Mark Lord
2009-08-16 13:53         ` Christoph Hellwig
2009-08-16 13:53           ` Christoph Hellwig
2009-08-16 13:59         ` Mark Lord
2009-08-16 13:59           ` Mark Lord
2009-08-16 14:06           ` Mark Lord
2009-08-16 14:06             ` Mark Lord
2009-08-16 14:23           ` Christoph Hellwig
2009-08-16 14:23             ` Christoph Hellwig
2009-08-16 14:26             ` Mark Lord
2009-08-16 14:26               ` Mark Lord
2009-08-19 20:39 ` Ingo Molnar
2009-08-19 20:39   ` Ingo Molnar
2009-08-20  1:05   ` Christoph Hellwig
2009-08-20  1:05     ` Christoph Hellwig
2009-08-20  1:10     ` Jamie Lokier
2009-08-20  1:10       ` Jamie Lokier
2009-08-20  1:38       ` Douglas Gilbert
2009-08-20  1:38         ` Douglas Gilbert
2009-08-20  1:38       ` Mark Lord
2009-08-20  1:38         ` Mark Lord
2009-08-21 12:46     ` Ingo Molnar
2009-08-21 12:46       ` Ingo Molnar
2009-08-21 18:18       ` ioctls vs syscalls once again Christoph Hellwig
2009-08-21 20:35         ` Ingo Molnar
2009-08-20  1:39   ` [PATCH, RFC] xfs: batched discard support Mark Lord
2009-08-20  1:39     ` Mark Lord
2009-08-20 13:48     ` Ric Wheeler
2009-08-20 14:38       ` Mark Lord
2009-08-20 14:38         ` Mark Lord
2009-08-20 14:42         ` Ric Wheeler
2009-08-20 14:42           ` Ric Wheeler
2009-08-20 17:19           ` Greg Freemyer
2009-08-20 17:19             ` Greg Freemyer
2009-08-20 14:42         ` James Bottomley
2009-08-20 14:42           ` James Bottomley
2009-08-20 15:43         ` Rolf Eike Beer
2009-08-20 15:43           ` Rolf Eike Beer
2009-08-20 17:00           ` Ric Wheeler
2009-08-20 17:00             ` Ric Wheeler
2009-08-20 14:58       ` Douglas Gilbert
2009-08-20 14:58         ` Douglas Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A8802F3.6010908@rtr.ca \
    --to=liml@rtr.ca \
    --cc=hch@infradead.org \
    --cc=jens.axboe@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.