All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Lord <liml@rtr.ca>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	jens.axboe@oracle.com,
	IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH, RFC] xfs: batched discard support
Date: Sun, 16 Aug 2009 10:26:03 -0400	[thread overview]
Message-ID: <4A8816FB.8070408@rtr.ca> (raw)
In-Reply-To: <20090816142331.GA4284@infradead.org>

Christoph Hellwig wrote:
> On Sun, Aug 16, 2009 at 09:59:32AM -0400, Mark Lord wrote:
>> Okay, I got Matthews patches updated onto 2.6.31, and fixed the incompatibilities
>> between those and the XFS TRIM patch (from Christoph), plus a sector_t printk issue.
>>
>> My apologies for attachments, but I am attaching the updated Christoph patch,
>> as well as my hacked-up forward-port of Matthew's patches.
>>
>> Not pretty, but they work.  :)
>>
>> Now.. running Christoph's "xfs trim" on a 4.6GB mostly already-trimmed
>> XFS partition gave this for the first time around:
> 
>> The problem is, it still issues TRIMs to the LLD one extent at a time.
>> Compare this with doing it all in a single TRIM command
>> with the wiper.sh script (filesystem unmounted):
> 
> I could do a variant which issues a single TRIM, but that would require
> us to lock out all other allocations for the time the trim takes.  I'll
> hack that up once I get some time.
..

Matthew's stuff will have to change to support that, too.

WARNING: multiple messages have this Message-ID (diff)
From: Mark Lord <liml@rtr.ca>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	xfs@oss.sgi.com,
	IDE/ATA development list <linux-ide@vger.kernel.org>,
	jens.axboe@oracle.com, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH, RFC] xfs: batched discard support
Date: Sun, 16 Aug 2009 10:26:03 -0400	[thread overview]
Message-ID: <4A8816FB.8070408@rtr.ca> (raw)
In-Reply-To: <20090816142331.GA4284@infradead.org>

Christoph Hellwig wrote:
> On Sun, Aug 16, 2009 at 09:59:32AM -0400, Mark Lord wrote:
>> Okay, I got Matthews patches updated onto 2.6.31, and fixed the incompatibilities
>> between those and the XFS TRIM patch (from Christoph), plus a sector_t printk issue.
>>
>> My apologies for attachments, but I am attaching the updated Christoph patch,
>> as well as my hacked-up forward-port of Matthew's patches.
>>
>> Not pretty, but they work.  :)
>>
>> Now.. running Christoph's "xfs trim" on a 4.6GB mostly already-trimmed
>> XFS partition gave this for the first time around:
> 
>> The problem is, it still issues TRIMs to the LLD one extent at a time.
>> Compare this with doing it all in a single TRIM command
>> with the wiper.sh script (filesystem unmounted):
> 
> I could do a variant which issues a single TRIM, but that would require
> us to lock out all other allocations for the time the trim takes.  I'll
> hack that up once I get some time.
..

Matthew's stuff will have to change to support that, too.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2009-08-16 14:26 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-16  0:47 [PATCH, RFC] xfs: batched discard support Christoph Hellwig
2009-08-16  0:47 ` Christoph Hellwig
2009-08-16  1:35 ` Mark Lord
2009-08-16  1:35   ` Mark Lord
2009-08-16  2:19   ` Mark Lord
2009-08-16  2:19     ` Mark Lord
2009-08-16  2:25     ` Christoph Hellwig
2009-08-16  2:25       ` Christoph Hellwig
2009-08-16  2:49       ` Mark Lord
2009-08-16  2:49         ` Mark Lord
2009-08-16  3:25         ` Mark Lord
2009-08-16  3:25           ` Mark Lord
2009-08-16 13:00       ` Mark Lord
2009-08-16 13:00         ` Mark Lord
2009-08-16 13:53         ` Christoph Hellwig
2009-08-16 13:53           ` Christoph Hellwig
2009-08-16 13:59         ` Mark Lord
2009-08-16 13:59           ` Mark Lord
2009-08-16 14:06           ` Mark Lord
2009-08-16 14:06             ` Mark Lord
2009-08-16 14:23           ` Christoph Hellwig
2009-08-16 14:23             ` Christoph Hellwig
2009-08-16 14:26             ` Mark Lord [this message]
2009-08-16 14:26               ` Mark Lord
2009-08-19 20:39 ` Ingo Molnar
2009-08-19 20:39   ` Ingo Molnar
2009-08-20  1:05   ` Christoph Hellwig
2009-08-20  1:05     ` Christoph Hellwig
2009-08-20  1:10     ` Jamie Lokier
2009-08-20  1:10       ` Jamie Lokier
2009-08-20  1:38       ` Douglas Gilbert
2009-08-20  1:38         ` Douglas Gilbert
2009-08-20  1:38       ` Mark Lord
2009-08-20  1:38         ` Mark Lord
2009-08-21 12:46     ` Ingo Molnar
2009-08-21 12:46       ` Ingo Molnar
2009-08-21 18:18       ` ioctls vs syscalls once again Christoph Hellwig
2009-08-21 20:35         ` Ingo Molnar
2009-08-20  1:39   ` [PATCH, RFC] xfs: batched discard support Mark Lord
2009-08-20  1:39     ` Mark Lord
2009-08-20 13:48     ` Ric Wheeler
2009-08-20 14:38       ` Mark Lord
2009-08-20 14:38         ` Mark Lord
2009-08-20 14:42         ` Ric Wheeler
2009-08-20 14:42           ` Ric Wheeler
2009-08-20 17:19           ` Greg Freemyer
2009-08-20 17:19             ` Greg Freemyer
2009-08-20 14:42         ` James Bottomley
2009-08-20 14:42           ` James Bottomley
2009-08-20 15:43         ` Rolf Eike Beer
2009-08-20 15:43           ` Rolf Eike Beer
2009-08-20 17:00           ` Ric Wheeler
2009-08-20 17:00             ` Ric Wheeler
2009-08-20 14:58       ` Douglas Gilbert
2009-08-20 14:58         ` Douglas Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A8816FB.8070408@rtr.ca \
    --to=liml@rtr.ca \
    --cc=hch@infradead.org \
    --cc=jens.axboe@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.