From: "H. Peter Anvin" <hpa@zytor.com>
To: Mark Kelly <mark@bifferos.com>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Florian Fainelli <florian@openwrt.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [patch] x86 CPU detection for RDC
Date: Mon, 17 Aug 2009 10:57:49 -0700 [thread overview]
Message-ID: <4A899A1D.8060808@zytor.com> (raw)
In-Reply-To: <alpine.LNX.2.00.0908160404300.20653@cent.localnet>
On 08/15/2009 08:35 PM, Mark Kelly wrote:
> diff --git a/arch/x86/kernel/cpu/Makefile b/arch/x86/kernel/cpu/Makefile
> index 4e242f9..9906064 100644
> --- a/arch/x86/kernel/cpu/Makefile
> +++ b/arch/x86/kernel/cpu/Makefile
> @@ -22,6 +22,7 @@ obj-$(CONFIG_CPU_SUP_CYRIX_32) += cyrix.o
> obj-$(CONFIG_CPU_SUP_CENTAUR) += centaur.o
> obj-$(CONFIG_CPU_SUP_TRANSMETA_32) += transmeta.o
> obj-$(CONFIG_CPU_SUP_UMC_32) += umc.o
> +obj-$(CONFIG_X86_RDC321X) += rdc.o
>
> obj-$(CONFIG_X86_MCE) += mcheck/
> obj-$(CONFIG_MTRR) += mtrr/
I don't see this defined anywhere. Where it is defined, it needs to
depend on or select CONFIG_PCI, since the detection code you're
proposing is using unguarded PCI references.
-hpa
next prev parent reply other threads:[~2009-08-17 17:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-16 15:46 [patch] x86 CPU detection for RDC Mark Kelly
2009-08-16 15:55 ` Ingo Molnar
2009-08-16 2:20 ` Mark Kelly
2009-08-16 17:52 ` Ingo Molnar
2009-08-16 3:35 ` Mark Kelly
2009-08-17 17:57 ` H. Peter Anvin [this message]
2009-08-17 18:08 ` Ingo Molnar
2009-08-17 18:22 ` H. Peter Anvin
2009-08-17 18:46 ` Andi Kleen
2009-08-17 18:53 ` H. Peter Anvin
2009-08-17 21:31 ` Andi Kleen
2009-08-17 22:00 ` H. Peter Anvin
2009-08-17 7:13 ` [patch, v2] x86: " Mark Kelly
2009-08-18 9:21 ` Florian Fainelli
2009-08-18 10:15 ` Ingo Molnar
2009-08-18 2:56 ` [patch, v3] " Mark Kelly
2009-08-17 18:58 ` [patch] x86 " H. Peter Anvin
2009-08-17 13:44 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A899A1D.8060808@zytor.com \
--to=hpa@zytor.com \
--cc=florian@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@bifferos.com \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.