From: "H. Peter Anvin" <hpa@zytor.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Ingo Molnar <mingo@elte.hu>, Mark Kelly <mark@bifferos.com>,
linux-kernel@vger.kernel.org,
Florian Fainelli <florian@openwrt.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [patch] x86 CPU detection for RDC
Date: Mon, 17 Aug 2009 11:53:24 -0700 [thread overview]
Message-ID: <4A89A724.406@zytor.com> (raw)
In-Reply-To: <871vnas2gn.fsf@basil.nowhere.org>
On 08/17/2009 11:46 AM, Andi Kleen wrote:
> "H. Peter Anvin" <hpa@zytor.com> writes:
>
>> On 08/17/2009 11:08 AM, Ingo Molnar wrote:
>>> X86_RDC321X already exists in arch/x86/Kconfig. It should probably
>>> grow a 'depends on PCI' rline or so.
>>>
>> Sounds like it.
>
> iirc the patch used early pci which is actually self contained
> in its header. The main problem was that it didn't use it correctly.
>
It isn't a matter of if compilation works, it is a matter of if we
should even try to probe PCI if the user has explicitly disabled
CONFIG_PCI. arch/x86/kernel/cpu/cyrix.c disables its PCI probing if
CONFIG_PCI is off, even though it also uses <asm/pci-direct.h>.
Given that the benefit of this CPU detection patch is extremely small
(all it does it get better information in /proc/cpuinfo) and that blind
probing can have disastrous consequences, I would say it should not.
-hpa
next prev parent reply other threads:[~2009-08-17 18:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-16 15:46 [patch] x86 CPU detection for RDC Mark Kelly
2009-08-16 15:55 ` Ingo Molnar
2009-08-16 2:20 ` Mark Kelly
2009-08-16 17:52 ` Ingo Molnar
2009-08-16 3:35 ` Mark Kelly
2009-08-17 17:57 ` H. Peter Anvin
2009-08-17 18:08 ` Ingo Molnar
2009-08-17 18:22 ` H. Peter Anvin
2009-08-17 18:46 ` Andi Kleen
2009-08-17 18:53 ` H. Peter Anvin [this message]
2009-08-17 21:31 ` Andi Kleen
2009-08-17 22:00 ` H. Peter Anvin
2009-08-17 7:13 ` [patch, v2] x86: " Mark Kelly
2009-08-18 9:21 ` Florian Fainelli
2009-08-18 10:15 ` Ingo Molnar
2009-08-18 2:56 ` [patch, v3] " Mark Kelly
2009-08-17 18:58 ` [patch] x86 " H. Peter Anvin
2009-08-17 13:44 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89A724.406@zytor.com \
--to=hpa@zytor.com \
--cc=andi@firstfloor.org \
--cc=florian@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@bifferos.com \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.