All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Tyser <ptyser@xes-inc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] omap: move TI's boards to board/ti/
Date: Sun, 23 Aug 2009 12:39:50 -0500	[thread overview]
Message-ID: <4A917EE6.5080108@xes-inc.com> (raw)
In-Reply-To: <4A9165AF.6050705@googlemail.com>

Hi Dirk,

<snip>

> Third, I don't like the mixing of board and vendor name as directory 
> names. It seems to me that where you think you know the vendor, you 
> use the vendor name, and where you seem to not know it, you use the 
> board name. So, to be consistent, and to overcome vendor name issue 
> above, I'd like to use the board name everywhere. That is:

Jean-Christophe's patches seem to follow the current U-Boot convention - 
use board/<vendor> when a vendor has multiple boards, and use 
board/<boardname> when a vendor only has 1 board.  I can't speak to the 
accuracy of how he split boards up, but his idea seems correct.

> board/beagle/
> board/omap3evm/
> board/omap1510inn/
> ...
> board/omap5912osk/
> ...
> board/omap2420h4/
> ...
> board/zoom1/
> board/zoom2/
> board/overo/
> board/pandora/
> ...

This isn't in line with how U-Boot currently organizes the board/ directory.

> To improve this even more, something like this would be nice:
> 
> board/omap3beagle/
> board/omap3evm/
> board/omap1innovator/
> ...
> board/omap1osk/
> ...
> board/omap2h4/
> ...
> board/omap3zoom1/
> board/omap3zoom2/
> board/omap3overo/
> board/omap3pandora/
> ...

Neither is this.  Jean-Christophe seems to be doing the "right" thing 
with his patches and I'd ACK them assuming the boards are put in the 
proper board/<vendor> and board/<boardname> directory.

Best,
Peter

  reply	other threads:[~2009-08-23 17:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-23 14:32 [U-Boot] [PATCH 1/3] omap: move TI's boards to board/ti/ Jean-Christophe PLAGNIOL-VILLARD
2009-08-23 14:32 ` [U-Boot] [PATCH 2/3] arm: move Logicpd's boards to board/logicpd/ Jean-Christophe PLAGNIOL-VILLARD
2009-08-23 14:32   ` [U-Boot] [PATCH 3/3] omap3: move the other boards to board/ Jean-Christophe PLAGNIOL-VILLARD
2009-08-23 15:52 ` [U-Boot] [PATCH 1/3] omap: move TI's boards to board/ti/ Dirk Behme
2009-08-23 17:39   ` Peter Tyser [this message]
2009-08-23 19:09   ` Wolfgang Denk
2009-08-25  5:18   ` Jean-Christophe PLAGNIOL-VILLARD
2009-09-06 21:43 ` Wolfgang Denk
2009-09-06 22:56   ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A917EE6.5080108@xes-inc.com \
    --to=ptyser@xes-inc.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.