From: Amerigo Wang <amwang@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, tony.luck@intel.com,
linux-ia64@vger.kernel.org, nhorman@redhat.com,
ebiederm@xmission.com, andi@firstfloor.org,
bernhard.walle@gmx.de, fenghua.yu@intel.com,
kamezawa.hiroyu@jp.fujitsu.com, avorontsov@ru.mvista.com
Subject: Re: [Patch 5/8] ia64: implement crashkernel=auto
Date: Mon, 24 Aug 2009 02:05:49 +0000 [thread overview]
Message-ID: <4A91F57D.10708@redhat.com> (raw)
In-Reply-To: <20090822111816.GA12281@elte.hu>
Ingo Molnar wrote:
>
> e) All the 'else' statements are superflous and make it all harder
> to read.
>
> f) 2ULL<<30 should be written as 1ULL<31, to keep things consistent.
>
Hi,
The reason that I kept 2ULL<<30 instead of 1ULL<<31 is that '1<<30' is
exactly 1G, so 2ULL<<30 can be easily read as 2G. ;)
> g) A nice comment explaining the purpose and logic wouldnt hurt.
>
Yup, in fact patch 8/8 has the doc for this, but I will copy that here
as a comment too.
Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Amerigo Wang <amwang@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, tony.luck@intel.com,
linux-ia64@vger.kernel.org, nhorman@redhat.com,
ebiederm@xmission.com, andi@firstfloor.org,
bernhard.walle@gmx.de, fenghua.yu@intel.com,
kamezawa.hiroyu@jp.fujitsu.com, avorontsov@ru.mvista.com
Subject: Re: [Patch 5/8] ia64: implement crashkernel=auto
Date: Mon, 24 Aug 2009 10:05:49 +0800 [thread overview]
Message-ID: <4A91F57D.10708@redhat.com> (raw)
In-Reply-To: <20090822111816.GA12281@elte.hu>
Ingo Molnar wrote:
>
> e) All the 'else' statements are superflous and make it all harder
> to read.
>
> f) 2ULL<<30 should be written as 1ULL<31, to keep things consistent.
>
Hi,
The reason that I kept 2ULL<<30 instead of 1ULL<<31 is that '1<<30' is
exactly 1G, so 2ULL<<30 can be easily read as 2G. ;)
> g) A nice comment explaining the purpose and logic wouldnt hurt.
>
Yup, in fact patch 8/8 has the doc for this, but I will copy that here
as a comment too.
Thanks!
next prev parent reply other threads:[~2009-08-24 2:05 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-21 6:54 [Patch 0/8] V4 Implement crashkernel=auto Amerigo Wang
2009-08-21 6:54 ` Amerigo Wang
2009-08-21 6:54 ` [Patch 1/8] kexec: allow to shrink reserved memory Amerigo Wang
2009-08-21 6:54 ` Amerigo Wang
2009-08-22 0:17 ` Andrew Morton
2009-08-22 0:17 ` Andrew Morton
2009-08-24 1:36 ` Amerigo Wang
2009-08-24 1:36 ` Amerigo Wang
2009-08-22 1:39 ` Eric W. Biederman
2009-08-22 1:39 ` Eric W. Biederman
2009-08-24 2:02 ` Amerigo Wang
2009-08-24 2:02 ` Amerigo Wang
2009-08-21 6:54 ` [Patch 2/8] x86: add CONFIG_KEXEC_AUTO_RESERVE Amerigo Wang
2009-08-21 6:54 ` Amerigo Wang
2009-08-21 6:54 ` [Patch 3/8] x86: implement crashkernel=auto Amerigo Wang
2009-08-21 6:54 ` Amerigo Wang
2009-08-21 6:54 ` [Patch 4/8] ia64: add CONFIG_KEXEC_AUTO_RESERVE Amerigo Wang
2009-08-21 6:54 ` Amerigo Wang
2009-08-21 6:55 ` [Patch 5/8] ia64: implement crashkernel=auto Amerigo Wang
2009-08-21 6:55 ` Amerigo Wang
2009-08-22 0:24 ` Andrew Morton
2009-08-22 0:24 ` Andrew Morton
2009-08-22 11:18 ` Ingo Molnar
2009-08-22 11:18 ` Ingo Molnar
2009-08-24 2:05 ` Amerigo Wang [this message]
2009-08-24 2:05 ` Amerigo Wang
2009-08-24 7:43 ` Ingo Molnar
2009-08-24 7:43 ` Ingo Molnar
2009-08-24 8:21 ` Bernhard Walle
2009-08-24 8:21 ` Bernhard Walle
2009-08-24 10:23 ` Amerigo Wang
2009-08-24 10:23 ` Amerigo Wang
2009-08-24 1:59 ` Amerigo Wang
2009-08-24 1:59 ` Amerigo Wang
2009-08-21 6:55 ` [Patch 6/8] powerpc: add CONFIG_KEXEC_AUTO_RESERVE Amerigo Wang
2009-08-21 6:55 ` Amerigo Wang
2009-08-24 13:44 ` Michael Ellerman
2009-08-24 13:44 ` Michael Ellerman
2009-08-24 14:45 ` M. Mohan Kumar
2009-08-24 14:57 ` M. Mohan Kumar
2009-08-25 6:37 ` Amerigo Wang
2009-08-25 6:37 ` Amerigo Wang
2009-08-25 10:24 ` M. Mohan Kumar
2009-08-25 10:36 ` M. Mohan Kumar
2009-08-25 6:23 ` Amerigo Wang
2009-08-25 6:23 ` Amerigo Wang
2009-08-25 10:28 ` M. Mohan Kumar
2009-08-25 10:40 ` M. Mohan Kumar
2009-08-26 6:59 ` Amerigo Wang
2009-08-26 6:59 ` Amerigo Wang
2009-08-21 6:55 ` [Patch 7/8] powerpc: implement crashkernel=auto Amerigo Wang
2009-08-21 6:55 ` Amerigo Wang
2009-08-21 6:55 ` [Patch 8/8] doc: update the kdump document Amerigo Wang
2009-08-21 6:55 ` Amerigo Wang
2009-08-22 0:06 ` [Patch 0/8] V4 Implement crashkernel=auto Andrew Morton
2009-08-22 0:06 ` Andrew Morton
2009-08-22 0:06 ` Andrew Morton
2009-08-24 1:34 ` Amerigo Wang
2009-08-24 1:34 ` Amerigo Wang
2009-08-24 1:34 ` Amerigo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A91F57D.10708@redhat.com \
--to=amwang@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=avorontsov@ru.mvista.com \
--cc=bernhard.walle@gmx.de \
--cc=ebiederm@xmission.com \
--cc=fenghua.yu@intel.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nhorman@redhat.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.