All of lore.kernel.org
 help / color / mirror / Atom feed
From: Izik Eidus <ieidus@redhat.com>
To: Hugh Dickins <hugh.dickins@tiscali.co.uk>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
	Rik van Riel <riel@redhat.com>, Chris Wright <chrisw@redhat.com>,
	Nick Piggin <nickpiggin@yahoo.com.au>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Justin M. Forbes" <jmforbes@linuxtx.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 13/12] ksm: fix munlock during exit_mmap deadlock
Date: Thu, 27 Aug 2009 22:35:27 +0300	[thread overview]
Message-ID: <4A96DFFF.1040501@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0908271958330.1973@sister.anvils>

Hugh Dickins wrote:
>
> It may be that MADV_UNMERGEABLE isn't really needed (I think I even
> admitted once that probably nobody would use it other than we testing
> it).  Yet I hesitate to rip it out: somehow it still seems right to
> have it in there.  Why did you have unregistering in the /dev/ksm KSM?
>   

It was more to give possiblaty to applications save cpu cycles of ksmd 
so it wont continue to scan memory regions that don`t need ksm anymore,
As you said if someone will ever use it?, have no idea...

>   
> I didn't seem idiotic to me, but I hadn't realized the ksmd timelapse
> uncertainty Andrea points out.  Well, I'm not keen to change the way
> it's working at present, but I do think you're right to question all
> these aspects of unmerging.
>   

Yes lets keep it like that, UNMERGEABLE sound anyway like something that 
going to break the pages..., we can always add later STOPMERGE as a call 
that tell ksm to stop merge the pages but not break the shared pages...

> Hugh
>   


WARNING: multiple messages have this Message-ID (diff)
From: Izik Eidus <ieidus@redhat.com>
To: Hugh Dickins <hugh.dickins@tiscali.co.uk>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
	Rik van Riel <riel@redhat.com>, Chris Wright <chrisw@redhat.com>,
	Nick Piggin <nickpiggin@yahoo.com.au>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Justin M. Forbes" <jmforbes@linuxtx.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 13/12] ksm: fix munlock during exit_mmap deadlock
Date: Thu, 27 Aug 2009 22:35:27 +0300	[thread overview]
Message-ID: <4A96DFFF.1040501@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0908271958330.1973@sister.anvils>

Hugh Dickins wrote:
>
> It may be that MADV_UNMERGEABLE isn't really needed (I think I even
> admitted once that probably nobody would use it other than we testing
> it).  Yet I hesitate to rip it out: somehow it still seems right to
> have it in there.  Why did you have unregistering in the /dev/ksm KSM?
>   

It was more to give possiblaty to applications save cpu cycles of ksmd 
so it wont continue to scan memory regions that don`t need ksm anymore,
As you said if someone will ever use it?, have no idea...

>   
> I didn't seem idiotic to me, but I hadn't realized the ksmd timelapse
> uncertainty Andrea points out.  Well, I'm not keen to change the way
> it's working at present, but I do think you're right to question all
> these aspects of unmerging.
>   

Yes lets keep it like that, UNMERGEABLE sound anyway like something that 
going to break the pages..., we can always add later STOPMERGE as a call 
that tell ksm to stop merge the pages but not break the shared pages...

> Hugh
>   

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-08-27 19:28 UTC|newest]

Thread overview: 106+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-03 12:08 [PATCH 0/12] ksm: stats, oom, doc, misc Hugh Dickins
2009-08-03 12:08 ` Hugh Dickins
2009-08-03 12:10 ` [PATCH 1/12] ksm: rename kernel_pages_allocated Hugh Dickins
2009-08-03 12:10   ` Hugh Dickins
2009-08-03 14:21   ` Izik Eidus
2009-08-03 14:21     ` Izik Eidus
2009-08-03 16:48     ` Andrea Arcangeli
2009-08-03 16:48       ` Andrea Arcangeli
2009-08-03 12:11 ` [PATCH 2/12] ksm: move pages_sharing updates Hugh Dickins
2009-08-03 12:11   ` Hugh Dickins
2009-08-03 14:34   ` Izik Eidus
2009-08-03 14:34     ` Izik Eidus
2009-08-03 16:53   ` Andrea Arcangeli
2009-08-03 16:53     ` Andrea Arcangeli
2009-08-03 17:34     ` Hugh Dickins
2009-08-03 17:34       ` Hugh Dickins
2009-08-03 12:11 ` [PATCH 3/12] ksm: pages_unshared and pages_volatile Hugh Dickins
2009-08-03 12:11   ` Hugh Dickins
2009-08-03 14:54   ` Izik Eidus
2009-08-03 14:54     ` Izik Eidus
2009-08-04 21:49   ` Andrew Morton
2009-08-04 21:49     ` Andrew Morton
2009-08-05 11:39     ` Hugh Dickins
2009-08-05 11:39       ` Hugh Dickins
2009-08-05 15:11       ` Andrea Arcangeli
2009-08-05 15:11         ` Andrea Arcangeli
2009-08-03 12:12 ` [PATCH 4/12] ksm: break cow once unshared Hugh Dickins
2009-08-03 12:12   ` Hugh Dickins
2009-08-03 16:00   ` Izik Eidus
2009-08-03 16:00     ` Izik Eidus
2009-08-03 12:14 ` [PATCH 5/12] ksm: keep quiet while list empty Hugh Dickins
2009-08-03 12:14   ` Hugh Dickins
2009-08-03 16:55   ` Izik Eidus
2009-08-03 16:55     ` Izik Eidus
2009-08-04 21:59   ` Andrew Morton
2009-08-04 21:59     ` Andrew Morton
2009-08-05 11:54     ` Hugh Dickins
2009-08-05 11:54       ` Hugh Dickins
2009-08-03 12:15 ` [PATCH 6/12] ksm: five little cleanups Hugh Dickins
2009-08-03 12:15   ` Hugh Dickins
2009-08-04 12:41   ` Izik Eidus
2009-08-04 12:41     ` Izik Eidus
2009-08-03 12:16 ` [PATCH 7/12] ksm: fix endless loop on oom Hugh Dickins
2009-08-03 12:16   ` Hugh Dickins
2009-08-04 12:55   ` Izik Eidus
2009-08-04 12:55     ` Izik Eidus
2009-08-03 12:17 ` [PATCH 8/12] ksm: distribute remove_mm_from_lists Hugh Dickins
2009-08-03 12:17   ` Hugh Dickins
2009-08-04 13:03   ` Izik Eidus
2009-08-04 13:03     ` Izik Eidus
2009-08-03 12:18 ` [PATCH 9/12] ksm: fix oom deadlock Hugh Dickins
2009-08-03 12:18   ` Hugh Dickins
2009-08-04 19:32   ` Izik Eidus
2009-08-04 19:32     ` Izik Eidus
2009-08-25 14:58   ` Andrea Arcangeli
2009-08-25 14:58     ` Andrea Arcangeli
2009-08-25 15:22     ` [PATCH 13/12] ksm: fix munlock during exit_mmap deadlock Andrea Arcangeli
2009-08-25 15:22       ` Andrea Arcangeli
2009-08-25 17:49       ` Hugh Dickins
2009-08-25 17:49         ` Hugh Dickins
2009-08-25 18:10         ` Andrea Arcangeli
2009-08-25 18:10           ` Andrea Arcangeli
2009-08-25 18:58           ` Hugh Dickins
2009-08-25 18:58             ` Hugh Dickins
2009-08-25 19:45             ` Andrea Arcangeli
2009-08-25 19:45               ` Andrea Arcangeli
2009-08-26 16:18               ` Justin M. Forbes
2009-08-26 16:18                 ` Justin M. Forbes
2009-08-26 19:17               ` Hugh Dickins
2009-08-26 19:17                 ` Hugh Dickins
2009-08-26 19:44                 ` Andrea Arcangeli
2009-08-26 19:44                   ` Andrea Arcangeli
2009-08-26 19:57                   ` Hugh Dickins
2009-08-26 19:57                     ` Hugh Dickins
2009-08-26 20:28                     ` Andrea Arcangeli
2009-08-26 20:28                       ` Andrea Arcangeli
2009-08-26 20:54                     ` Izik Eidus
2009-08-26 20:54                       ` Izik Eidus
2009-08-26 21:14                       ` Andrea Arcangeli
2009-08-26 21:14                         ` Andrea Arcangeli
2009-08-26 21:49                         ` Izik Eidus
2009-08-26 21:49                           ` Izik Eidus
2009-08-27 19:11                           ` Hugh Dickins
2009-08-27 19:11                             ` Hugh Dickins
2009-08-27 19:35                             ` Izik Eidus [this message]
2009-08-27 19:35                               ` Izik Eidus
2009-08-26 22:00                         ` David Rientjes
2009-08-26 22:00                           ` David Rientjes
2009-08-26 20:29                   ` Hugh Dickins
2009-08-26 20:29                     ` Hugh Dickins
2009-08-25 17:35     ` [PATCH 9/12] ksm: fix oom deadlock Hugh Dickins
2009-08-25 17:35       ` Hugh Dickins
2009-08-25 17:47       ` Andrea Arcangeli
2009-08-25 17:47         ` Andrea Arcangeli
2009-08-03 12:19 ` [PATCH 10/12] ksm: sysfs and defaults Hugh Dickins
2009-08-03 12:19   ` Hugh Dickins
2009-08-04 19:34   ` Izik Eidus
2009-08-04 19:34     ` Izik Eidus
2009-08-03 12:21 ` [PATCH 11/12] ksm: add some documentation Hugh Dickins
2009-08-03 12:21   ` Hugh Dickins
2009-08-04 19:35   ` Izik Eidus
2009-08-04 19:35     ` Izik Eidus
2009-08-03 12:22 ` [PATCH 12/12] ksm: remove VM_MERGEABLE_FLAGS Hugh Dickins
2009-08-03 12:22   ` Hugh Dickins
2009-08-04 19:35   ` Izik Eidus
2009-08-04 19:35     ` Izik Eidus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A96DFFF.1040501@redhat.com \
    --to=ieidus@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=chrisw@redhat.com \
    --cc=hugh.dickins@tiscali.co.uk \
    --cc=jmforbes@linuxtx.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nickpiggin@yahoo.com.au \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.