All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gregory Haskins <ghaskins@novell.com>
To: Rik van Riel <riel@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Christoph Lameter <cl@linux-foundation.org>,
	Chris Friesen <cfriesen@nortel.com>,
	raz ben yehuda <raziebe@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	mingo@elte.hu, peterz@infradead.org, maximlevitsky@gmail.com,
	efault@gmx.de, wiseman@macs.biu.ac.il,
	linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Subject: Re: RFC: THE OFFLINE SCHEDULER
Date: Fri, 28 Aug 2009 00:27:48 -0400	[thread overview]
Message-ID: <4A975CC4.1090208@novell.com> (raw)
In-Reply-To: <4A975025.8030500@novell.com>

[-- Attachment #1: Type: text/plain, Size: 2572 bytes --]

Gregory Haskins wrote:
> Hi Rik,
> 
> Rik van Riel wrote:
>> Gregory Haskins wrote:
>>
>>> 2) Modify FIFO so that it disables tick by default...update accounting
>>> info at next reschedule event.
>> I like it.  The only thing to watch out for is that
>> events that wake up higher-priority FIFO tasks do
>> not get deferred :)
>>
> 
> Yeah, agreed.  My (potentially half-baked) proposal should work at least
> from a pure scheduling perspective since FIFO technically does not
> reschedule based on a tick, and wakeups/migrations should still work
> bidirectionally with existing scheduler policies.
> 
> However, and to what I believe is your point: its not entirely clear to
> me what impact, if any, there would be w.r.t. any _other_ events that
> may be driven off of the scheduler tick (i.e. events other than
> scheduling policies, like timeslice expiration, etc).  Perhaps someone
> else like Thomas, Ingo, or Peter have some input here.
> 
> I guess the specific question to ask is: Does the scheduler tick code
> have any role other than timeslice policies and updating accounting
> information?  Examples would include timer-expiry, for instance.  I
> would think most of this logic is handled by finer grained components
> like HRT, but I am admittedly ignorant of the actual timer voodoo ;)
> 

Thinking about this idea some more:  I can't see why this isn't just a
trivial variation of the nohz idle code already in mainline.  In both
cases (idle and FIFO tasks) the cpu is "consumed" 100% by some arbitrary
job (spinning/HLT for idle, RT thread for FIFO) while we have the
scheduler tick disabled.  The only real difference is a matter of
power-management (HLT/mwait go to sleep-states, whereas spinning/rt-task
run full tilt).

Therefore the answer may be as simple as bracketing the FIFO task with
tick_nohz_stop_sched_tick() + tick_nohz_restart_sched_tick().  The nohz
code will probably need some minor adjustments so it is not assuming
things about the state being "idle" (e.g. "isidle") for places when it
matters (idle_calls++ stat is one example).

Potential problems:

a) disabling/renabling the tick on a per-RT task schedule() may prove to
be prohibitively expensive.

b) we will need to make sure the rt-bandwidth protection mechanism is
defeated so the task is allowed to consume 100% bandwidth.

Perhaps these states should be in the cpuset/root-domain, and configured
when you create the partition (e.g. "tick=off", "bandwidth=off" makes it
an "offline" set).

Kind Regards,
-Greg


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 267 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Gregory Haskins <ghaskins@novell.com>
To: Rik van Riel <riel@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Christoph Lameter <cl@linux-foundation.org>,
	Chris Friesen <cfriesen@nortel.com>,
	raz ben yehuda <raziebe@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	mingo@elte.hu, peterz@infradead.org, maximlevitsky@gmail.com,
	efault@gmx.de, wiseman@macs.biu.ac.il,
	linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Subject: Re: RFC: THE OFFLINE SCHEDULER
Date: Fri, 28 Aug 2009 00:27:48 -0400	[thread overview]
Message-ID: <4A975CC4.1090208@novell.com> (raw)
In-Reply-To: <4A975025.8030500@novell.com>

[-- Attachment #1: Type: text/plain, Size: 2572 bytes --]

Gregory Haskins wrote:
> Hi Rik,
> 
> Rik van Riel wrote:
>> Gregory Haskins wrote:
>>
>>> 2) Modify FIFO so that it disables tick by default...update accounting
>>> info at next reschedule event.
>> I like it.  The only thing to watch out for is that
>> events that wake up higher-priority FIFO tasks do
>> not get deferred :)
>>
> 
> Yeah, agreed.  My (potentially half-baked) proposal should work at least
> from a pure scheduling perspective since FIFO technically does not
> reschedule based on a tick, and wakeups/migrations should still work
> bidirectionally with existing scheduler policies.
> 
> However, and to what I believe is your point: its not entirely clear to
> me what impact, if any, there would be w.r.t. any _other_ events that
> may be driven off of the scheduler tick (i.e. events other than
> scheduling policies, like timeslice expiration, etc).  Perhaps someone
> else like Thomas, Ingo, or Peter have some input here.
> 
> I guess the specific question to ask is: Does the scheduler tick code
> have any role other than timeslice policies and updating accounting
> information?  Examples would include timer-expiry, for instance.  I
> would think most of this logic is handled by finer grained components
> like HRT, but I am admittedly ignorant of the actual timer voodoo ;)
> 

Thinking about this idea some more:  I can't see why this isn't just a
trivial variation of the nohz idle code already in mainline.  In both
cases (idle and FIFO tasks) the cpu is "consumed" 100% by some arbitrary
job (spinning/HLT for idle, RT thread for FIFO) while we have the
scheduler tick disabled.  The only real difference is a matter of
power-management (HLT/mwait go to sleep-states, whereas spinning/rt-task
run full tilt).

Therefore the answer may be as simple as bracketing the FIFO task with
tick_nohz_stop_sched_tick() + tick_nohz_restart_sched_tick().  The nohz
code will probably need some minor adjustments so it is not assuming
things about the state being "idle" (e.g. "isidle") for places when it
matters (idle_calls++ stat is one example).

Potential problems:

a) disabling/renabling the tick on a per-RT task schedule() may prove to
be prohibitively expensive.

b) we will need to make sure the rt-bandwidth protection mechanism is
defeated so the task is allowed to consume 100% bandwidth.

Perhaps these states should be in the cpuset/root-domain, and configured
when you create the partition (e.g. "tick=off", "bandwidth=off" makes it
an "offline" set).

Kind Regards,
-Greg


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 267 bytes --]

  reply	other threads:[~2009-08-28  4:27 UTC|newest]

Thread overview: 85+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-22 23:27 RFC: THE OFFLINE SCHEDULER raz ben yehuda
2009-08-23  5:21 ` Mike Galbraith
2009-08-23  9:09   ` raz ben yehuda
2009-08-23  7:30     ` Mike Galbraith
2009-08-23 11:05       ` raz ben yehuda
2009-08-23  9:52         ` Mike Galbraith
2009-08-25 15:23           ` Christoph Lameter
2009-08-25 17:56             ` Mike Galbraith
2009-08-25 18:03               ` Christoph Lameter
2009-08-25 18:12                 ` Mike Galbraith
     [not found]                   ` <5d96567b0908251522m3fd4ab98n76a52a34a11e874c@mail.gmail.com>
2009-08-25 22:32                     ` Fwd: " Raz
2009-08-25 19:08                 ` Peter Zijlstra
2009-08-25 19:18                   ` Christoph Lameter
2009-08-25 19:22                   ` Chris Friesen
2009-08-25 20:35                     ` Sven-Thorsten Dietrich
2009-08-26  5:31                     ` Peter Zijlstra
2009-08-26 10:29                       ` raz ben yehuda
2009-08-26  8:02                         ` Mike Galbraith
2009-08-26  8:16                           ` Raz
2009-08-26  8:16                             ` Raz
2009-08-26 13:47                         ` Christoph Lameter
2009-08-26 14:45                           ` Maxim Levitsky
2009-08-26 14:54                             ` raz ben yehuda
2009-08-26 15:06                               ` Pekka Enberg
2009-08-26 15:11                                 ` raz ben yehuda
2009-08-26 15:30                               ` Peter Zijlstra
2009-08-26 15:41                                 ` Christoph Lameter
2009-08-26 16:03                                   ` Peter Zijlstra
2009-08-26 16:16                                     ` Pekka Enberg
2009-08-26 16:20                                     ` Christoph Lameter
2009-08-26 18:04                                       ` Ingo Molnar
2009-08-26 19:15                                         ` Christoph Lameter
2009-08-26 19:32                                           ` Ingo Molnar
2009-08-26 20:40                                             ` Christoph Lameter
2009-08-26 20:50                                               ` Andrew Morton
2009-08-26 21:09                                                 ` Christoph Lameter
2009-08-26 21:15                                                 ` Chris Friesen
2009-08-26 21:37                                                   ` raz ben yehuda
2009-08-27 16:51                                                     ` Chris Friesen
2009-08-27 17:04                                                       ` Christoph Lameter
2009-08-27 21:09                                                         ` Thomas Gleixner
2009-08-27 22:22                                                           ` Gregory Haskins
2009-08-28  2:15                                                             ` Rik van Riel
2009-08-28  3:33                                                               ` Gregory Haskins
2009-08-28  3:33                                                                 ` Gregory Haskins
2009-08-28  4:27                                                                 ` Gregory Haskins [this message]
2009-08-28  4:27                                                                   ` Gregory Haskins
2009-08-28 10:26                                                                   ` Thomas Gleixner
2009-08-28 18:57                                                                     ` Christoph Lameter
2009-08-28 19:23                                                                       ` Thomas Gleixner
2009-08-28 19:52                                                                         ` Christoph Lameter
2009-08-28 20:00                                                                           ` Thomas Gleixner
2009-08-28 20:21                                                                             ` Christoph Lameter
2009-08-28 20:34                                                                               ` Thomas Gleixner
2009-08-31 19:19                                                                                 ` Christoph Lameter
2009-08-31 17:44                                                                                   ` Roland Dreier
2009-09-01 18:42                                                                                     ` Christoph Lameter
2009-09-01 16:15                                                                                       ` Roland Dreier
2009-08-29 17:03                                                                               ` jim owens
2009-08-31 19:22                                                                                 ` Christoph Lameter
2009-08-31 15:33                                                                                   ` Peter Zijlstra
2009-09-01 18:46                                                                                     ` Christoph Lameter
2009-08-28  6:14                                                             ` Peter Zijlstra
2009-08-27 23:51                                                           ` Chris Friesen
2009-08-28  0:44                                                             ` Thomas Gleixner
2009-08-28 21:20                                                               ` Chris Friesen
2009-08-28 21:20                                                                 ` Chris Friesen
2009-08-28 18:43                                                           ` Christoph Lameter
2009-08-27 21:33                                                       ` raz ben yehuda
2009-08-27 22:05                                                         ` Thomas Gleixner
2009-08-28  8:38                                                           ` raz ben yehuda
2009-08-28 10:05                                                             ` Thomas Gleixner
2009-08-28 13:25                                                             ` Rik van Riel
2009-08-28 13:37                                                               ` jim owens
2009-08-28 15:22                                                               ` raz ben yehuda
2009-08-26 21:34                                                 ` Ingo Molnar
2009-08-27  2:55                                                   ` Frank Ch. Eigler
2009-08-26 21:34                                                 ` raz ben yehuda
2009-08-26 21:08                                               ` Ingo Molnar
2009-08-26 21:26                                                 ` Christoph Lameter
2009-08-26 21:32                                             ` raz ben yehuda
2009-08-27  7:15                                           ` Mike Galbraith
2009-08-26 15:37                               ` Chetan.Loke
2009-08-26 15:21                       ` Pekka Enberg
2009-08-25 21:09                   ` Éric Piel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A975CC4.1090208@novell.com \
    --to=ghaskins@novell.com \
    --cc=akpm@linux-foundation.org \
    --cc=cfriesen@nortel.com \
    --cc=cl@linux-foundation.org \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=maximlevitsky@gmail.com \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=raziebe@gmail.com \
    --cc=riel@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=wiseman@macs.biu.ac.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.