[PATCH] armv5te mentioned twice on eabi-capable list

[PATCH] armv5te mentioned twice on eabi-capable list

[Aleksandr Koltsoff]

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

(My first patch generated with git, please be gentle :-).

armv5te is mentioned twice in the arm_eabi_supporting_arches list of
sane-toolchain.inc. Remove the latter occurance.

ak.

[-- Attachment #2: 0001-fix-armv5te-mentioned-twice-in-the-eabi-capable-list.patch --]
[-- Type: text/x-diff, Size: 942 bytes --]

From 0776995c4668d744ff96397639ac646fc4b5133c Mon Sep 17 00:00:00 2001
From: Aleksandr Koltsoff <czr@iki.fi>
Date: Wed, 16 Sep 2009 13:12:05 +0300
Subject: [PATCH] fix armv5te mentioned twice in the eabi-capable list

---
 conf/distro/include/sane-toolchain.inc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/conf/distro/include/sane-toolchain.inc b/conf/distro/include/sane-toolchain.inc
index e2c6740..d0bb8bc 100644
--- a/conf/distro/include/sane-toolchain.inc
+++ b/conf/distro/include/sane-toolchain.inc
@@ -157,7 +157,7 @@ def detect_arm_abi (d):
 def compute_os_portion_of_target_triplet (d):
 	import bb
 	arm_eabi_supporting_arches = "armv6 armv6-novfp \
-	armv5te iwmmxt armv7a armv7 armv6 armv5teb armv5te armv4t"
+	armv5te iwmmxt armv7a armv7 armv6 armv5teb armv4t"
 	ppc_spe_supporting_arches = "ppce500v2 ppce500"
 
   	if bb.data.getVar("LIBC", d, 1) == "uclibc":
-- 
1.6.4

Re: [PATCH] armv5te mentioned twice on eabi-capable list

[Cliff Brake]

On Wed, Sep 16, 2009 at 6:19 AM, Aleksandr Koltsoff <czr@iki.fi> wrote:
> (My first patch generated with git, please be gentle :-).
>
> armv5te is mentioned twice in the arm_eabi_supporting_arches list of
> sane-toolchain.inc. Remove the latter occurance.

Looks good.  I'll let Khem or some who is more familiar with toolchains apply.

One suggestion, we have a commit policy
(http://wiki.openembedded.net/index.php/Commit_Policy), so if you
follow that on future patches, we can directly git-am your patches and
push them with no extra work.

So the commit message for this might be:

sane-toolchain.inc: remove extra armv5te in eabi-capable list

This allows people to very quickly get an idea what this patch applies
to, and makes for nice formatting in the weekly change logs.

Thanks,
Cliff

Re: [PATCH] armv5te mentioned twice on eabi-capable list

[Koen Kooi]

On 16-09-09 14:48, Cliff Brake wrote:
> On Wed, Sep 16, 2009 at 6:19 AM, Aleksandr Koltsoff<czr@iki.fi>  wrote:
>> (My first patch generated with git, please be gentle :-).
>>
>> armv5te is mentioned twice in the arm_eabi_supporting_arches list of
>> sane-toolchain.inc. Remove the latter occurance.
>
> Looks good.  I'll let Khem or some who is more familiar with toolchains apply.
>
> One suggestion, we have a commit policy
> (http://wiki.openembedded.net/index.php/Commit_Policy), so if you
> follow that on future patches, we can directly git-am your patches and
> push them with no extra work.
>
> So the commit message for this might be:
>
> sane-toolchain.inc: remove extra armv5te in eabi-capable list
>
> This allows people to very quickly get an idea what this patch applies
> to, and makes for nice formatting in the weekly change logs.

Note that in general we don't like putting the filename in the commit 
message.

regards,

Koen

Re: [PATCH] armv5te mentioned twice on eabi-capable list

[Denys Dmytriyenko]

On Wed, Sep 16, 2009 at 01:19:14PM +0300, Aleksandr Koltsoff wrote:
> (My first patch generated with git, please be gentle :-).
> 
> armv5te is mentioned twice in the arm_eabi_supporting_arches list of
> sane-toolchain.inc. Remove the latter occurance.
> 
>  def compute_os_portion_of_target_triplet (d):
>  	import bb
>  	arm_eabi_supporting_arches = "armv6 armv6-novfp \
> -	armv5te iwmmxt armv7a armv7 armv6 armv5teb armv5te armv4t"
> +	armv5te iwmmxt armv7a armv7 armv6 armv5teb armv4t"

Looks like armv6 is also mentioned twice...

>  	ppc_spe_supporting_arches = "ppce500v2 ppce500"

Denys