All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Sachin Sant <sachinp@in.ibm.com>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	Nick Piggin <npiggin@suse.de>,
	Christoph Lameter <cl@linux-foundation.org>,
	heiko.carstens@de.ibm.com, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH 1/3] slqb: Do not use DEFINE_PER_CPU for per-node data
Date: Mon, 21 Sep 2009 18:53:26 +0900	[thread overview]
Message-ID: <4AB74D16.8050802@kernel.org> (raw)
In-Reply-To: <20090921094406.GI12726@csn.ul.ie>

Hello,

Mel Gorman wrote:
> On Mon, Sep 21, 2009 at 06:00:22PM +0900, Tejun Heo wrote:
>> Hello,
>>
>> Mel Gorman wrote:
>>>>> Can you please post full dmesg showing the corruption? 
>>> There isn't a useful dmesg available and my evidence that it's within the
>>> pcpu allocator is a bit weak.
>> I'd really like to see the memory layout, especially how far apart the
>> nodes are.
>>
> 
> Here is the console log with just your patch applied. The node layouts
> are included in the log although I note they are not far apart. What is
> also important is that the exact location of the bug is not reliable
> although it's always in accessing the same structure. This time it was a
> bad data access. The time after that, a BUG_ON triggered when locking a
> spinlock in the same structure. The third time, it locked up silently.
> Forth time, it was a data access error but a different address and so
> on.

One likely possibility is something accessing wrong percpu offset.
Can you please attach .config?

Thanks.

-- 
tejun

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Sachin Sant <sachinp@in.ibm.com>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	Nick Piggin <npiggin@suse.de>,
	Christoph Lameter <cl@linux-foundation.org>,
	heiko.carstens@de.ibm.com, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH 1/3] slqb: Do not use DEFINE_PER_CPU for per-node data
Date: Mon, 21 Sep 2009 18:53:26 +0900	[thread overview]
Message-ID: <4AB74D16.8050802@kernel.org> (raw)
In-Reply-To: <20090921094406.GI12726@csn.ul.ie>

Hello,

Mel Gorman wrote:
> On Mon, Sep 21, 2009 at 06:00:22PM +0900, Tejun Heo wrote:
>> Hello,
>>
>> Mel Gorman wrote:
>>>>> Can you please post full dmesg showing the corruption? 
>>> There isn't a useful dmesg available and my evidence that it's within the
>>> pcpu allocator is a bit weak.
>> I'd really like to see the memory layout, especially how far apart the
>> nodes are.
>>
> 
> Here is the console log with just your patch applied. The node layouts
> are included in the log although I note they are not far apart. What is
> also important is that the exact location of the bug is not reliable
> although it's always in accessing the same structure. This time it was a
> bad data access. The time after that, a BUG_ON triggered when locking a
> spinlock in the same structure. The third time, it locked up silently.
> Forth time, it was a data access error but a different address and so
> on.

One likely possibility is something accessing wrong percpu offset.
Can you please attach .config?

Thanks.

-- 
tejun

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-09-21  9:54 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-18 19:34 [RFC PATCH 0/3] Hatchet job for SLQB on memoryless configurations Mel Gorman
2009-09-18 19:34 ` Mel Gorman
2009-09-18 19:34 ` [PATCH 1/3] slqb: Do not use DEFINE_PER_CPU for per-node data Mel Gorman
2009-09-18 19:34   ` Mel Gorman
2009-09-20  8:45   ` Pekka Enberg
2009-09-20  8:45     ` Pekka Enberg
2009-09-20 10:00     ` Tejun Heo
2009-09-20 10:00       ` Tejun Heo
2009-09-20 10:12       ` Pekka Enberg
2009-09-20 10:12         ` Pekka Enberg
2009-09-20 15:55         ` Tejun Heo
2009-09-20 15:55           ` Tejun Heo
2009-09-21  6:24           ` Pekka Enberg
2009-09-21  6:24             ` Pekka Enberg
2009-09-21  8:46             ` Mel Gorman
2009-09-21  8:46               ` Mel Gorman
2009-09-21  8:30           ` Sachin Sant
2009-09-21  8:42             ` Mel Gorman
2009-09-21  8:42               ` Mel Gorman
2009-09-21  9:00               ` Tejun Heo
2009-09-21  9:00                 ` Tejun Heo
2009-09-21  9:44                 ` Mel Gorman
2009-09-21  9:44                   ` Mel Gorman
2009-09-21  9:53                   ` Tejun Heo [this message]
2009-09-21  9:53                     ` Tejun Heo
2009-09-21 10:04                     ` Mel Gorman
2009-09-21 10:04                       ` Mel Gorman
2009-09-21  9:02               ` Sachin Sant
2009-09-21  9:02                 ` Sachin Sant
2009-09-21  9:09                 ` Mel Gorman
2009-09-21  9:09                   ` Mel Gorman
2009-09-21 13:04               ` Mel Gorman
2009-09-21 13:04                 ` Mel Gorman
2009-09-21 13:31                 ` Pekka Enberg
2009-09-21 13:31                   ` Pekka Enberg
2009-09-21 13:45                 ` Tejun Heo
2009-09-21 13:45                   ` Tejun Heo
2009-09-21 13:57                   ` Mel Gorman
2009-09-21 13:57                     ` Mel Gorman
2009-09-21 23:54                     ` Benjamin Herrenschmidt
2009-09-21 23:54                       ` Benjamin Herrenschmidt
2009-09-20 14:04     ` Mel Gorman
2009-09-20 14:04       ` Mel Gorman
2009-09-18 19:34 ` [PATCH 2/3] slqb: Treat pages freed on a memoryless node as local node Mel Gorman
2009-09-18 19:34   ` Mel Gorman
2009-09-18 21:01   ` Christoph Lameter
2009-09-18 21:01     ` Christoph Lameter
2009-09-19 11:46     ` Mel Gorman
2009-09-19 11:46       ` Mel Gorman
2009-09-21 17:34       ` Lee Schermerhorn
2009-09-21 17:34         ` Lee Schermerhorn
2009-09-22 13:33         ` Mel Gorman
2009-09-22 13:33           ` Mel Gorman
2009-09-22 18:29           ` Lee Schermerhorn
2009-09-22 18:29             ` Lee Schermerhorn
2009-09-18 19:34 ` [PATCH 3/3] slqb: Allow SLQB to be used on PPC and S390 Mel Gorman
2009-09-18 19:34   ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AB74D16.8050802@kernel.org \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=cl@linux-foundation.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=npiggin@suse.de \
    --cc=penberg@cs.helsinki.fi \
    --cc=sachinp@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.