From: Paul Fulghum <paulkf@microgate.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: lenrek@me.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/char/pcmcia/synclink_cs.c: BKL pushdown?
Date: Fri, 02 Oct 2009 08:20:17 -0500 [thread overview]
Message-ID: <4AC5FE11.9060500@microgate.com> (raw)
In-Reply-To: <20091002124945.1814a2c3@lxorguk.ukuu.org.uk>
Alan Cox wrote:
> On Fri, 02 Oct 2009 19:37:21 +0900
> lenrek@me.com wrote:
>
>> I found the counterpart of function mgslpc_wait_until_sent
>> in drivers/char/synclinkmp.c (wait_until_sent) is modified to
>> issue (un)lock_kernel. This patch does the same modification.
>>
>> However, I'm afraid similar modifications are necessary further on
>> functions
>> mgslpc_ioctl and mgslpc_write_room.
>
> The push down work normally eliminated BKL calls that were demonstrably
> not needed and left it in anywhere that needed thought. Do those
> functions still really need the BKL ?
No, these functions use a device specific spinlock (info->lock)
when needed. Not even mgslpc_wait_until_sent needs BKL.
--
Paul Fulghum
MicroGate Systems, Ltd.
=Customer Driven, by Design=
(800)444-1982
(512)345-7791 (Direct)
(512)343-9046 (Fax)
Central Time Zone (GMT -5h)
www.microgate.com
next prev parent reply other threads:[~2009-10-02 13:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-02 10:37 [PATCH] drivers/char/pcmcia/synclink_cs.c: BKL pushdown? lenrek
2009-10-02 11:49 ` Alan Cox
2009-10-02 13:20 ` Paul Fulghum [this message]
2009-10-02 14:12 ` lenrek
2009-10-02 15:33 ` Paul Fulghum
2009-10-02 16:12 ` lenrek
2009-10-02 19:11 ` Paul Fulghum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC5FE11.9060500@microgate.com \
--to=paulkf@microgate.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=lenrek@me.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.