From: Paul Fulghum <paulkf@microgate.com>
To: lenrek@me.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/char/pcmcia/synclink_cs.c: BKL pushdown?
Date: Fri, 02 Oct 2009 09:33:34 -0600 [thread overview]
Message-ID: <4AC61D4E.4040000@microgate.com> (raw)
In-Reply-To: <0358338D-E697-4D44-96A8-E7107D50F77E@me.com>
lenrek@me.com wrote:
> How about the BKL calls in synclinkmp.c, synclink.c, and synclink_gt.c?
> Can they be safely eliminated?
I looked those over and yes, the BKL can be removed
from those as well. All 4 synclink drivers are mostly
variations on the same code.
It looks like the lock_kernel calls were blindly pushed down
for safety during the initial transition, but all of the
functions covered either use device specific locking or
do not require locking.
--
Paul Fulghum
MicroGate Systems, Ltd.
=Customer Driven, by Design=
(800)444-1982
(512)345-7791 (Direct)
(512)343-9046 (Fax)
Central Time Zone (GMT -5h)
www.microgate.com
next prev parent reply other threads:[~2009-10-02 14:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-02 10:37 [PATCH] drivers/char/pcmcia/synclink_cs.c: BKL pushdown? lenrek
2009-10-02 11:49 ` Alan Cox
2009-10-02 13:20 ` Paul Fulghum
2009-10-02 14:12 ` lenrek
2009-10-02 15:33 ` Paul Fulghum [this message]
2009-10-02 16:12 ` lenrek
2009-10-02 19:11 ` Paul Fulghum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC61D4E.4040000@microgate.com \
--to=paulkf@microgate.com \
--cc=lenrek@me.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.