All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Fulghum <paulkf@microgate.com>
To: lenrek@me.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/char/pcmcia/synclink_cs.c: BKL pushdown?
Date: Fri, 02 Oct 2009 13:11:59 -0600	[thread overview]
Message-ID: <4AC6507F.70303@microgate.com> (raw)
In-Reply-To: <0DA1DE03-4131-4257-B476-03A776A9B4A6@me.com>

lenrek@me.com wrote:
> On 2009/10/03, at 0:33, Paul Fulghum wrote:
> 
>> lenrek@me.com wrote:
>>> How about the BKL calls in synclinkmp.c, synclink.c, and  
>>> synclink_gt.c?
>>> Can they be safely eliminated?
>> I looked those over and yes, the BKL can be removed
>> from those as well. All 4 synclink drivers are mostly
>> variations on the same code.
>>
>> It looks like the lock_kernel calls were blindly pushed down
>> for safety during the initial transition, but all of the
>> functions covered either use device specific locking or
>> do not require locking.
> 
> Many thanks.  I enclose a patch against 2.6.31.1
> which eliminates the BKL calls from the synclink drivers.

Acked-by: Paul Fulghum <paulkf@microgate.com>

-- 
Paul Fulghum
MicroGate Systems, Ltd.
=Customer Driven, by Design=
(800)444-1982
(512)345-7791 (Direct)
(512)343-9046 (Fax)
Central Time Zone (GMT -5h)
www.microgate.com

      reply	other threads:[~2009-10-02 18:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-02 10:37 [PATCH] drivers/char/pcmcia/synclink_cs.c: BKL pushdown? lenrek
2009-10-02 11:49 ` Alan Cox
2009-10-02 13:20   ` Paul Fulghum
2009-10-02 14:12     ` lenrek
2009-10-02 15:33       ` Paul Fulghum
2009-10-02 16:12         ` lenrek
2009-10-02 19:11           ` Paul Fulghum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AC6507F.70303@microgate.com \
    --to=paulkf@microgate.com \
    --cc=lenrek@me.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.