ice1724 SPDIF buffer size?

ice1724 SPDIF buffer size?

[Robert Hancock]

I noticed that in the ice1724 driver, we set a default and maximum 
preallocated buffer size of 256K for the "professional" stream, but only 
64K for the SPDIF and independent stereo pair streams, even though the 
hardware supports 256K for all streams. Is there any reason why we can't 
use 256K for all of them?

I made this change here and it seems to work fine (for SPDIF at least, 
haven't tested stereo). From a power and CPU usage perspective, it makes 
sense to allow as big a buffer as possible for when latency isn't critical..

Re: ice1724 SPDIF buffer size?

[Takashi Iwai]

At Wed, 07 Oct 2009 00:01:33 -0600,
Robert Hancock wrote:
> 
> I noticed that in the ice1724 driver, we set a default and maximum 
> preallocated buffer size of 256K for the "professional" stream, but only 
> 64K for the SPDIF and independent stereo pair streams, even though the 
> hardware supports 256K for all streams. Is there any reason why we can't 
> use 256K for all of them?

I don't remember any reasons.

> I made this change here and it seems to work fine (for SPDIF at least, 
> haven't tested stereo). From a power and CPU usage perspective, it makes 
> sense to allow as big a buffer as possible for when latency isn't critical..

Care to send your fix patch so that I can merge?


thanks,

Takashi