* ice1724 SPDIF buffer size?
@ 2009-10-07 6:01 Robert Hancock
2009-10-07 9:58 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Robert Hancock @ 2009-10-07 6:01 UTC (permalink / raw)
To: Alsa-Devel
I noticed that in the ice1724 driver, we set a default and maximum
preallocated buffer size of 256K for the "professional" stream, but only
64K for the SPDIF and independent stereo pair streams, even though the
hardware supports 256K for all streams. Is there any reason why we can't
use 256K for all of them?
I made this change here and it seems to work fine (for SPDIF at least,
haven't tested stereo). From a power and CPU usage perspective, it makes
sense to allow as big a buffer as possible for when latency isn't critical..
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: ice1724 SPDIF buffer size?
2009-10-07 6:01 ice1724 SPDIF buffer size? Robert Hancock
@ 2009-10-07 9:58 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2009-10-07 9:58 UTC (permalink / raw)
To: Robert Hancock; +Cc: Alsa-Devel
At Wed, 07 Oct 2009 00:01:33 -0600,
Robert Hancock wrote:
>
> I noticed that in the ice1724 driver, we set a default and maximum
> preallocated buffer size of 256K for the "professional" stream, but only
> 64K for the SPDIF and independent stereo pair streams, even though the
> hardware supports 256K for all streams. Is there any reason why we can't
> use 256K for all of them?
I don't remember any reasons.
> I made this change here and it seems to work fine (for SPDIF at least,
> haven't tested stereo). From a power and CPU usage perspective, it makes
> sense to allow as big a buffer as possible for when latency isn't critical..
Care to send your fix patch so that I can merge?
thanks,
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-07 9:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-07 6:01 ice1724 SPDIF buffer size? Robert Hancock
2009-10-07 9:58 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.